[PR] Report the Airflow version error first when HITL review needs 3.1+ [airflow]

["kaxil (via GitHub)" <gi...@apache.org>]

kaxil opened a new pull request, #73052:
URL: https://github.com/apache/airflow/pull/73052

   `AgentOperator.__init__` checked the conflicting-argument rules for `enable_hitl_review`
   before checking whether the core supports HITL at all. The provider supports
   `apache-airflow>=3.0.0`, so on a 3.0.x core
   `AgentOperator(message_history=..., enable_hitl_review=True)` reported
   
   ```
   ValueError: message_history and enable_hitl_review=True cannot be used together.
   ```
   
   when the real blocker is the core version. Dropping `message_history` does not help: the user
   then hits "Human in the loop functionality needs Airflow 3.1+." anyway, having changed their
   Dag for nothing. `durable=True` with `enable_hitl_review=True` sat behind the same ordering.
   The version gate now runs ahead of the combination rules, so the first error names the thing
   that actually has to change.
   
   **The ordering is what the tests were resting on, which is why one of them gains a skip here
   rather than losing coverage.** `test_message_history_with_hitl_review_raises` was the only
   HITL test in the file without `skipif(not AIRFLOW_V_3_1_PLUS)`, and it passed on older cores
   only because the combination error preempted the version error. Reversing that ordering makes
   it fail there, so the skipif its siblings all carry is restored alongside. A parametrized test
   pins the ordering itself so it cannot drift back, and the `durable` + `enable_hitl_review`
   combination gains the test it never had.
   
   Related to #70628.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Report the Airflow version error first when HITL review needs 3.1+ [airflow]

["kaxil (via GitHub)" <gi...@apache.org>]

kaxil merged PR #73052:
URL: https://github.com/apache/airflow/pull/73052


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org