You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/06/24 02:09:18 UTC
[GitHub] codecov-io edited a comment on issue #4528: [wip] dashboard builder
v2
codecov-io edited a comment on issue #4528: [wip] dashboard builder v2
URL: https://github.com/apache/incubator-superset/pull/4528#issuecomment-399606943
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4528?src=pr&el=h1) Report
> Merging [#4528](https://codecov.io/gh/apache/incubator-superset/pull/4528?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/73295f25a3fad8310fa6628f20c00b5143321bca?src=pr&el=desc) will **decrease** coverage by `1.35%`.
> The diff coverage is `52.01%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/4528/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4528?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4528 +/- ##
==========================================
- Coverage 63.28% 61.93% -1.36%
==========================================
Files 259 368 +109
Lines 19689 23858 +4169
Branches 1968 2721 +753
==========================================
+ Hits 12461 14777 +2316
- Misses 7219 9069 +1850
- Partials 9 12 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4528?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rd/deprecated/v1/components/DashboardContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4528/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvZGVwcmVjYXRlZC92MS9jb21wb25lbnRzL0Rhc2hib2FyZENvbnRhaW5lci5qc3g=) | `0% <ø> (ø)` | |
| [...t/assets/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/incubator-superset/pull/4528/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9uZXdDb21wb25lbnRGYWN0b3J5Lmpz) | `100% <ø> (ø)` | |
| [superset/assets/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/4528/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL3JlZHVjZXJzL2luZGV4Lmpz) | `0% <ø> (ø)` | :arrow_up: |
| [...s/src/dashboard/util/logging/childChartsDidLoad.js](https://codecov.io/gh/apache/incubator-superset/pull/4528/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9sb2dnaW5nL2NoaWxkQ2hhcnRzRGlkTG9hZC5qcw==) | `0% <ø> (ø)` | |
| [superset/assets/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/4528/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9kbmQtcmVvcmRlci5qcw==) | `100% <ø> (ø)` | |
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/4528/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.76% <ø> (ø)` | :arrow_up: |
| [.../assets/src/dashboard/util/shouldWrapChildInRow.js](https://codecov.io/gh/apache/incubator-superset/pull/4528/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9zaG91bGRXcmFwQ2hpbGRJblJvdy5qcw==) | `100% <ø> (ø)` | |
| [...perset/assets/src/explore/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4528/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvU2F2ZU1vZGFsLmpzeA==) | `93.82% <ø> (ø)` | :arrow_up: |
| [...ssets/src/visualizations/deckgl/layers/scatter.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4528/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL3NjYXR0ZXIuanN4) | `27.83% <ø> (ø)` | :arrow_up: |
| [superset/assets/src/modules/utils.js](https://codecov.io/gh/apache/incubator-superset/pull/4528/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9tb2R1bGVzL3V0aWxzLmpz) | `45.07% <ø> (-3.14%)` | :arrow_down: |
| ... and [284 more](https://codecov.io/gh/apache/incubator-superset/pull/4528/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4528?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4528?src=pr&el=footer). Last update [73295f2...69621a9](https://codecov.io/gh/apache/incubator-superset/pull/4528?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org