[PATCH] protocol/1399: MISE 4.0 POST, then 401 Unauth, then garbage

["Roy T. Fielding" <fi...@kiwi.ics.uci.edu>]

This is what I mean by adding discard_request_body(r) to die().
Can somebody test it on the user's problem?

.....Roy

Index: http_request.c
===================================================================
RCS file: /export/home/cvs/apachen/src/main/http_request.c,v
retrieving revision 1.92
diff -u -r1.92 http_request.c
--- http_request.c	1997/11/08 21:39:11	1.92
+++ http_request.c	1997/11/12 15:28:59
@@ -887,6 +887,17 @@
     }
 
     /*
+     * If we want to keep the connection, be sure that the request body
+     * (if any) has been read.
+     */
+    if ((r->status != HTTP_NOT_MODIFIED) && (r->status != HTTP_NO_CONTENT)
+        && !status_drops_connection(r->status)
+        && r->connection && (r->connection->keepalive != -1)) {
+
+        (void) discard_request_body(r);
+    }
+
+    /*
      * Two types of custom redirects --- plain text, and URLs. Plain text has
      * a leading '"', so the URL code, here, is triggered on its absence
      */

Re: [PATCH] protocol/1399: MISE 4.0 POST, then 401 Unauth, then garbage

[Martin Kraemer <Ma...@mch.sni.de>]

On Wed, Nov 12, 1997 at 07:21:08AM -0800, Roy T. Fielding wrote:
> This is what I mean by adding discard_request_body(r) to die().
> Can somebody test it on the user's problem?
>      /*
> +     * If we want to keep the connection, be sure that the request body
> +     * (if any) has been read.
> +     */
> +    if ((r->status != HTTP_NOT_MODIFIED) && (r->status != HTTP_NO_CONTENT)
> +        && !status_drops_connection(r->status)
> +        && r->connection && (r->connection->keepalive != -1)) {
> +
> +        (void) discard_request_body(r);
> +    }

An (untested) +1: it looks like the right thing to do.
In which situation could r->connection be NULL?

   Martin
-- 
| S I E M E N S |  <Ma...@mch.sni.de>  |      Siemens Nixdorf
| ------------- |   Voice: +49-89-636-46021     |  Informationssysteme AG
| N I X D O R F |   FAX:   +49-89-636-44994     |   81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request