[GitHub] [beam] Abacn commented on a diff in pull request #25632: Expose BigQuery schema autodetect in Java SDK

["Abacn (via GitHub)" <gi...@apache.org>]

Abacn commented on code in PR #25632:
URL: https://github.com/apache/beam/pull/25632#discussion_r1126685013


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/testing/FakeJobService.java:
##########
@@ -381,10 +381,6 @@ private JobStatus runLoadJob(JobReference jobRef, JobConfigurationLoad load)
     CreateDisposition createDisposition = CreateDisposition.valueOf(load.getCreateDisposition());
 
     Table existingTable = datasetService.getTable(destination);
-    if (schema == null) {

Review Comment:
   is it possible to preserve this check?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org