[GitHub] [airflow] potiuk commented on a change in pull request #7328: [AIRFLOW-6707] Simplify Connection.get_hook method

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #7328: [AIRFLOW-6707] Simplify Connection.get_hook method
URL: https://github.com/apache/airflow/pull/7328#discussion_r373842991
 
 

 ##########
 File path: airflow/models/connection.py
 ##########
 @@ -28,6 +28,50 @@
 from airflow.models.base import ID_LEN, Base
 from airflow.models.crypto import get_fernet
 from airflow.utils.log.logging_mixin import LoggingMixin
+from airflow.utils.module_loading import import_string
+
+# A map that assigns a connection type to a tuple that contains
+# the path of the class and the name of the conn_id key parameter.
+# PLEASE KEEP BELOW LIST IN ALPHABETICAL ORDER.
 
 Review comment:
   @mik-laj - maybe add a test for that. We already have quite a few tests where we check if we have alphabetical order in source code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services