You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Daniel Gornstein <dg...@mitre.org> on 2013/06/21 16:52:36 UTC

Review Request: RequireJS Work

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12030/
-----------------------------------------------------------

Review request for rave.


Description
-------

ReqeuireJS work


Diffs
-----

  /branches/require/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/MessageBundleController.java 1495194 
  /branches/require/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/RegionWidgetTag.java 1495194 
  /branches/require/rave-portal-resources/src/main/webapp/WEB-INF/jsp/templates/base_layout.jsp 1495194 
  /branches/require/rave-portal-resources/src/main/webapp/WEB-INF/tags/third_party_js.tag 1495194 
  /branches/require/rave-portal-resources/src/main/webapp/static/script/app.js 1495194 
  /branches/require/rave-portal-resources/src/main/webapp/static/script/core/main.js 1495194 
  /branches/require/rave-portal-resources/src/main/webapp/static/script/core/rave_ajax.js 1495194 
  /branches/require/rave-portal-resources/src/main/webapp/static/script/core/rave_api.js 1495194 
  /branches/require/rave-portal-resources/src/main/webapp/static/script/core/rave_core.js 1495194 
  /branches/require/rave-portal-resources/src/main/webapp/static/script/core/rave_providers.js 1495194 
  /branches/require/rave-portal-resources/src/main/webapp/static/script/core/rave_view_manager.js 1495194 
  /branches/require/rave-portal-resources/src/main/webapp/static/script/core/rave_widget.js 1495194 
  /branches/require/rave-portal-resources/src/main/webapp/static/script/core/rave_wookie.js 1495194 
  /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_admin.js 1495194 
  /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_backbone.js 1495194 
  /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_context.js 1495194 
  /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_display.js 1495194 
  /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_event_bindings.js 1495194 
  /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_forms.js 1495194 
  /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_layout.js 1495194 
  /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_models.js 1495194 
  /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_person_profile.js 1495194 
  /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_portal.js 1495194 
  /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_store.js 1495194 
  /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_templates.js 1495194 
  /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_ui.js 1495194 
  /branches/require/rave-portal/pom.xml 1495194 
  /branches/require/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/main/java/org/apache/rave/provider/opensocial/web/renderer/OpenSocialWidgetWrapperRenderer.java 1495194 

Diff: https://reviews.apache.org/r/12030/diff/


Testing
-------


Thanks,

Daniel Gornstein

Re: Review Request: RequireJS Work

Posted by Erin Noe-Payne <er...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12030/#review22254
-----------------------------------------------------------

Ship it!


Ship It!

- Erin Noe-Payne


On June 21, 2013, 2:52 p.m., Daniel Gornstein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12030/
> -----------------------------------------------------------
> 
> (Updated June 21, 2013, 2:52 p.m.)
> 
> 
> Review request for rave.
> 
> 
> Description
> -------
> 
> ReqeuireJS work
> 
> 
> Diffs
> -----
> 
>   /branches/require/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/MessageBundleController.java 1495194 
>   /branches/require/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/RegionWidgetTag.java 1495194 
>   /branches/require/rave-portal-resources/src/main/webapp/WEB-INF/jsp/templates/base_layout.jsp 1495194 
>   /branches/require/rave-portal-resources/src/main/webapp/WEB-INF/tags/third_party_js.tag 1495194 
>   /branches/require/rave-portal-resources/src/main/webapp/static/script/app.js 1495194 
>   /branches/require/rave-portal-resources/src/main/webapp/static/script/core/main.js 1495194 
>   /branches/require/rave-portal-resources/src/main/webapp/static/script/core/rave_ajax.js 1495194 
>   /branches/require/rave-portal-resources/src/main/webapp/static/script/core/rave_api.js 1495194 
>   /branches/require/rave-portal-resources/src/main/webapp/static/script/core/rave_core.js 1495194 
>   /branches/require/rave-portal-resources/src/main/webapp/static/script/core/rave_providers.js 1495194 
>   /branches/require/rave-portal-resources/src/main/webapp/static/script/core/rave_view_manager.js 1495194 
>   /branches/require/rave-portal-resources/src/main/webapp/static/script/core/rave_widget.js 1495194 
>   /branches/require/rave-portal-resources/src/main/webapp/static/script/core/rave_wookie.js 1495194 
>   /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_admin.js 1495194 
>   /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_backbone.js 1495194 
>   /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_context.js 1495194 
>   /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_display.js 1495194 
>   /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_event_bindings.js 1495194 
>   /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_forms.js 1495194 
>   /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_layout.js 1495194 
>   /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_models.js 1495194 
>   /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_person_profile.js 1495194 
>   /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_portal.js 1495194 
>   /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_store.js 1495194 
>   /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_templates.js 1495194 
>   /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_ui.js 1495194 
>   /branches/require/rave-portal/pom.xml 1495194 
>   /branches/require/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/main/java/org/apache/rave/provider/opensocial/web/renderer/OpenSocialWidgetWrapperRenderer.java 1495194 
> 
> Diff: https://reviews.apache.org/r/12030/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Gornstein
> 
>