You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/06/27 13:07:57 UTC
[GitHub] [camel] ldrozdo opened a new pull request, #7901: Fix typos in AWS docs
ldrozdo opened a new pull request, #7901:
URL: https://github.com/apache/camel/pull/7901
<!-- Uncomment and fill this section if your PR is not trivial
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #7901: Fix typos in AWS docs
Posted by GitBox <gi...@apache.org>.
davsclaus merged PR #7901:
URL: https://github.com/apache/camel/pull/7901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #7901: Fix typos in AWS docs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7901:
URL: https://github.com/apache/camel/pull/7901#issuecomment-1167331629
:warning: This PR changes Camel components and will be tested automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a diff in pull request #7901: Fix typos in AWS docs
Posted by GitBox <gi...@apache.org>.
davsclaus commented on code in PR #7901:
URL: https://github.com/apache/camel/pull/7901#discussion_r907590157
##########
components/camel-aws/camel-aws2-s3/src/main/docs/aws2-s3-component.adoc:
##########
@@ -359,7 +359,7 @@ In this case the upload will be completed after 10 seconds.
== Bucket Autocreation
-With the option `autoCreateBucket` users are able to avoid the autocreation of an S3 Bucket in case it doesn't exist. The default for this option is `true`.
+With the option `autoCreateBucket` users are able to avoid the autocreation of an S3 Bucket in case it doesn't exist. The default for this option is `false`.
Review Comment:
Ah yeah its a bit weird that its false for s3, but we have a similar option as true for camel-google and camel-minio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #7901: Fix typos in AWS docs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7901:
URL: https://github.com/apache/camel/pull/7901#issuecomment-1167756955
:heavy_check_mark: Finished component verification: 0 component(s) test failed out of **2 component(s) tested**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a diff in pull request #7901: Fix typos in AWS docs
Posted by GitBox <gi...@apache.org>.
davsclaus commented on code in PR #7901:
URL: https://github.com/apache/camel/pull/7901#discussion_r908014876
##########
components/camel-aws/camel-aws2-s3/src/main/docs/aws2-s3-component.adoc:
##########
@@ -359,7 +359,7 @@ In this case the upload will be completed after 10 seconds.
== Bucket Autocreation
-With the option `autoCreateBucket` users are able to avoid the autocreation of an S3 Bucket in case it doesn't exist. The default for this option is `true`.
+With the option `autoCreateBucket` users are able to avoid the autocreation of an S3 Bucket in case it doesn't exist. The default for this option is `false`.
Review Comment:
Created a ticket to not forget about this: https://issues.apache.org/jira/browse/CAMEL-18235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org