[GitHub] [cassandra-builds] ekaterinadimitrova2 commented on a diff in pull request #88: Add JDK17 support [CASSANDRA-17869]

[GitBox <gi...@apache.org>]

ekaterinadimitrova2 commented on code in PR #88:
URL: https://github.com/apache/cassandra-builds/pull/88#discussion_r1066528414


##########
docker/build-rpms.sh:
##########
@@ -89,7 +91,12 @@ else
    CASSANDRA_REVISION="${dt}git${ref}"
 fi
 
-if [ $JAVA_VERSION = "11" ]; then
+if [ $JAVA_VERSION = "17" ]; then
+   sudo alternatives --set java $(alternatives --display java | grep 'family java-17-openjdk' | cut -d' ' -f1)
+   sudo alternatives --set javac $(alternatives --display javac | grep 'family java-17-openjdk' | cut -d' ' -f1)
+   export CASSANDRA_USE_JDK17=true

Review Comment:
   That branch is WIP and those things were just a switch to JDK17 for testing long ago.
   I don't mind the switch after we cleared that this is fine with the community (there were discussions). The opposite - all in :-) Simplification is always a good thing



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org