You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Namit Jain (JIRA)" <ji...@apache.org> on 2010/12/03 20:19:12 UTC

[jira] Created: (HIVE-1828) show locks should not use getTable()/getPartition

show locks should not use getTable()/getPartition 
--------------------------------------------------

                 Key: HIVE-1828
                 URL: https://issues.apache.org/jira/browse/HIVE-1828
             Project: Hive
          Issue Type: Bug
          Components: Query Processor
            Reporter: Namit Jain
            Assignee: He Yongqiang




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1828) show locks should not use getTable()/getPartition

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-1828:
-----------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

Committed. Thanks Yongqiang

> show locks should not use getTable()/getPartition 
> --------------------------------------------------
>
>                 Key: HIVE-1828
>                 URL: https://issues.apache.org/jira/browse/HIVE-1828
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: He Yongqiang
>         Attachments: HIVE-1828.2.patch, HIVE-1828.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1828) show locks should not use getTable()/getPartition

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966847#action_12966847 ] 

Namit Jain commented on HIVE-1828:
----------------------------------

One minor comment:

In case of 

show locks <T> extended;

Does anyone check that the table exists ?

The DDLTask can do that before calling zookeeper 

> show locks should not use getTable()/getPartition 
> --------------------------------------------------
>
>                 Key: HIVE-1828
>                 URL: https://issues.apache.org/jira/browse/HIVE-1828
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: He Yongqiang
>         Attachments: HIVE-1828.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1828) show locks should not use getTable()/getPartition

Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

He Yongqiang updated HIVE-1828:
-------------------------------

    Attachment: HIVE-1828.patch

> show locks should not use getTable()/getPartition 
> --------------------------------------------------
>
>                 Key: HIVE-1828
>                 URL: https://issues.apache.org/jira/browse/HIVE-1828
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: He Yongqiang
>         Attachments: HIVE-1828.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1828) show locks should not use getTable()/getPartition

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-1828:
-----------------------------

    Status: Open  (was: Patch Available)

> show locks should not use getTable()/getPartition 
> --------------------------------------------------
>
>                 Key: HIVE-1828
>                 URL: https://issues.apache.org/jira/browse/HIVE-1828
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: He Yongqiang
>         Attachments: HIVE-1828.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1828) show locks should not use getTable()/getPartition

Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

He Yongqiang updated HIVE-1828:
-------------------------------

    Attachment: HIVE-1828.2.patch

> show locks should not use getTable()/getPartition 
> --------------------------------------------------
>
>                 Key: HIVE-1828
>                 URL: https://issues.apache.org/jira/browse/HIVE-1828
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: He Yongqiang
>         Attachments: HIVE-1828.2.patch, HIVE-1828.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1828) show locks should not use getTable()/getPartition

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968459#action_12968459 ] 

Namit Jain commented on HIVE-1828:
----------------------------------

+1

running tests

> show locks should not use getTable()/getPartition 
> --------------------------------------------------
>
>                 Key: HIVE-1828
>                 URL: https://issues.apache.org/jira/browse/HIVE-1828
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: He Yongqiang
>         Attachments: HIVE-1828.2.patch, HIVE-1828.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1828) show locks should not use getTable()/getPartition

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966981#action_12966981 ] 

Namit Jain commented on HIVE-1828:
----------------------------------

can you add the new patch ?

also, can you add a negative test (if you have not done so already) ?

> show locks should not use getTable()/getPartition 
> --------------------------------------------------
>
>                 Key: HIVE-1828
>                 URL: https://issues.apache.org/jira/browse/HIVE-1828
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: He Yongqiang
>         Attachments: HIVE-1828.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1828) show locks should not use getTable()/getPartition

Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

He Yongqiang updated HIVE-1828:
-------------------------------

    Status: Patch Available  (was: Open)

> show locks should not use getTable()/getPartition 
> --------------------------------------------------
>
>                 Key: HIVE-1828
>                 URL: https://issues.apache.org/jira/browse/HIVE-1828
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: He Yongqiang
>         Attachments: HIVE-1828.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1828) show locks should not use getTable()/getPartition

Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966872#action_12966872 ] 

He Yongqiang commented on HIVE-1828:
------------------------------------

For "show locks <T> extended;", DDLTask is now validating the table and partition information in getHiveLockObject(). 

> show locks should not use getTable()/getPartition 
> --------------------------------------------------
>
>                 Key: HIVE-1828
>                 URL: https://issues.apache.org/jira/browse/HIVE-1828
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: He Yongqiang
>         Attachments: HIVE-1828.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1828) show locks should not use getTable()/getPartition

Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

He Yongqiang updated HIVE-1828:
-------------------------------

    Status: Patch Available  (was: Open)

> show locks should not use getTable()/getPartition 
> --------------------------------------------------
>
>                 Key: HIVE-1828
>                 URL: https://issues.apache.org/jira/browse/HIVE-1828
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: He Yongqiang
>         Attachments: HIVE-1828.2.patch, HIVE-1828.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.