You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/06/10 08:22:42 UTC
[GitHub] [incubator-mxnet] bgawrych opened a new pull request #20338: [1.x] [FEATURE] Add API to control denormalized computations
bgawrych opened a new pull request #20338:
URL: https://github.com/apache/incubator-mxnet/pull/20338
## Description ##
This is implementation of RFC https://github.com/apache/incubator-mxnet/issues/19361 and connected with issue https://github.com/apache/incubator-mxnet/issues/19218
```
>>> import mxnet as mx
>>> mx.nd.array([9e-45])
[0.]
<NDArray 1 @cpu(0)>
>>> mx.util.set_flush_denorms(False)
>>> mx.nd.array([9e-45])
[8.e-45]
<NDArray 1 @cpu(0)>
>>> mx.util.set_flush_denorms(True)
>>> mx.nd.array([9e-45])
[0.]
<NDArray 1 @cpu(0)>
>>> exit
```
As stated in RFC handling denormalized values is enabled by default and API for changing this behavior is available for the user
## Checklist ##
### Essentials ###
- [X] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [X] Changes are complete (i.e. I finished coding on this PR)
- [] All changes have test coverage
- [X] Code is well-documented
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #20338: [1.x] [FEATURE] Add API to control denormalized computations
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #20338:
URL: https://github.com/apache/incubator-mxnet/pull/20338#issuecomment-860747217
@mxnet-bot run ci [centos-gpu, unix-gpu, windows-cpu, windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ptrendx commented on a change in pull request #20338: [1.x] [FEATURE] Add API to control denormalized computations
Posted by GitBox <gi...@apache.org>.
ptrendx commented on a change in pull request #20338:
URL: https://github.com/apache/incubator-mxnet/pull/20338#discussion_r657207921
##########
File path: python/mxnet/util.py
##########
@@ -848,3 +848,20 @@ def setenv(name, value):
"""
passed_value = None if value is None else c_str(value)
check_call(_LIB.MXSetEnv(c_str(name), passed_value))
+
+def set_flush_denorms(value):
+ """Change floating-point calculations when dealing with denormalized values.
+ This is only applicable to architectures which supports flush-to-zero.
+ Denormalized values are positive and negative values that are very close to 0
+ (exponent is the smallest possible value).
+ Flushing denormalized values to 0 can speedup calculations if such values occurs,
+ but if fulfilling whole IEEE 754 standard is required this option should be disabled.
+ Parameters
+ ----------
+ value : bool
+ State of flush-to-zero and denormals-are-zero in MXCSR register
Review comment:
There is a `--ftz=true` compiler flag to `nvcc`, and otherwise the rounding mode is controlled per instruction, see: https://docs.nvidia.com/cuda/floating-point/index.html#rounding-modes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20338: [1.x] [FEATURE] Add API to control denormalized computations
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20338:
URL: https://github.com/apache/incubator-mxnet/pull/20338#issuecomment-874039189
Jenkins CI successfully triggered : [unix-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #20338: [1.x] [FEATURE] Add API to control denormalized computations
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #20338:
URL: https://github.com/apache/incubator-mxnet/pull/20338#discussion_r662406878
##########
File path: include/mxnet/c_api.h
##########
@@ -261,6 +261,14 @@ MXNET_DLL int MXRandomSeed(int seed);
*/
MXNET_DLL int MXRandomSeedContext(int seed, int dev_type, int dev_id);
+/*!
+ * \brief Change floating-point calculations when dealing with denormalized values.
Review comment:
we should also note here that only CPU is supported at the moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] akarbown merged pull request #20338: [1.x] [FEATURE] Add API to control denormalized computations
Posted by GitBox <gi...@apache.org>.
akarbown merged pull request #20338:
URL: https://github.com/apache/incubator-mxnet/pull/20338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on a change in pull request #20338: [1.x] [FEATURE] Add API to control denormalized computations
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on a change in pull request #20338:
URL: https://github.com/apache/incubator-mxnet/pull/20338#discussion_r649842161
##########
File path: src/c_api/c_api.cc
##########
@@ -1573,6 +1578,42 @@ int MXRandomSeedContext(int seed, int dev_type, int dev_id) {
API_END();
}
+int MXSetFlushDenorms(bool value) {
+ API_BEGIN();
+ // FTZ only applies to SSE and AVX instructions.
+ #if defined(__SSE__) || defined(_M_X64) || (defined(_M_IX86_FP) && _M_IX86_FP >= 1)
+ auto is_dmz_flag_available = []() {
Review comment:
To be very picky here, I'd rather prefer to see a bool type instead of auto type. Well. If the lambda's body is a single return statement, then the return type might be defined explicitly,
##########
File path: src/c_api/c_api.cc
##########
@@ -1573,6 +1578,42 @@ int MXRandomSeedContext(int seed, int dev_type, int dev_id) {
API_END();
}
+int MXSetFlushDenorms(bool value) {
+ API_BEGIN();
+ // FTZ only applies to SSE and AVX instructions.
+ #if defined(__SSE__) || defined(_M_X64) || (defined(_M_IX86_FP) && _M_IX86_FP >= 1)
+ auto is_dmz_flag_available = []() {
+ // Intel 64 and IA-32 Architectures Software Developer’s Manual: Vol. 1
+ // "Checking for the DAZ Flag in the MXCSR Register"
+ constexpr unsigned int mxcsr_mask_offset = 28;
+ constexpr unsigned int dmz_flag_offset = 5;
+ constexpr unsigned int fxsave_req_bytes = 512;
+
+ char* fxsave_area_ptr = reinterpret_cast<char*>(malloc(fxsave_req_bytes));
+ memset(fxsave_area_ptr, 0, fxsave_req_bytes); // fill memory with 0
+ _fxsave(fxsave_area_ptr);
+
+ char* mxcsr_mask_ptr = fxsave_area_ptr + mxcsr_mask_offset;
+ uint32_t mxcsr_mask = *(reinterpret_cast<uint32_t*>((mxcsr_mask_ptr)));
+ bool dmz_flag = (mxcsr_mask >> dmz_flag_offset) & 0x1;
+ free(fxsave_area_ptr);
+ return dmz_flag;
+ };
+
+ const unsigned int DMZ_STATE = value ? _MM_DENORMALS_ZERO_ON : _MM_DENORMALS_ZERO_OFF;
+ const unsigned int FTZ_STATE = value ? _MM_FLUSH_ZERO_ON : _MM_FLUSH_ZERO_OFF;
+
+ _MM_SET_FLUSH_ZERO_MODE(FTZ_STATE);
+ // If the DAZ flag is not supported, then it is a reserved bit and attempting to write a 1
Review comment:
It's worth saying that the DAZ flag is supported when the sixth bit is hot.
##########
File path: src/c_api/c_api.cc
##########
@@ -1573,6 +1578,42 @@ int MXRandomSeedContext(int seed, int dev_type, int dev_id) {
API_END();
}
+int MXSetFlushDenorms(bool value) {
+ API_BEGIN();
+ // FTZ only applies to SSE and AVX instructions.
+ #if defined(__SSE__) || defined(_M_X64) || (defined(_M_IX86_FP) && _M_IX86_FP >= 1)
+ auto is_dmz_flag_available = []() {
+ // Intel 64 and IA-32 Architectures Software Developer’s Manual: Vol. 1
+ // "Checking for the DAZ Flag in the MXCSR Register"
+ constexpr unsigned int mxcsr_mask_offset = 28;
+ constexpr unsigned int dmz_flag_offset = 5;
+ constexpr unsigned int fxsave_req_bytes = 512;
+
+ char* fxsave_area_ptr = reinterpret_cast<char*>(malloc(fxsave_req_bytes));
+ memset(fxsave_area_ptr, 0, fxsave_req_bytes); // fill memory with 0
+ _fxsave(fxsave_area_ptr);
+
+ char* mxcsr_mask_ptr = fxsave_area_ptr + mxcsr_mask_offset;
+ uint32_t mxcsr_mask = *(reinterpret_cast<uint32_t*>((mxcsr_mask_ptr)));
+ bool dmz_flag = (mxcsr_mask >> dmz_flag_offset) & 0x1;
+ free(fxsave_area_ptr);
+ return dmz_flag;
+ };
+
+ const unsigned int DMZ_STATE = value ? _MM_DENORMALS_ZERO_ON : _MM_DENORMALS_ZERO_OFF;
+ const unsigned int FTZ_STATE = value ? _MM_FLUSH_ZERO_ON : _MM_FLUSH_ZERO_OFF;
+
+ _MM_SET_FLUSH_ZERO_MODE(FTZ_STATE);
+ // If the DAZ flag is not supported, then it is a reserved bit and attempting to write a 1
Review comment:
It's worth saying that the DAZ flag is supported when the sixth bit of MXCSR_MASK is hot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20338: [1.x] [FEATURE] Add API to control denormalized computations
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20338:
URL: https://github.com/apache/incubator-mxnet/pull/20338#issuecomment-868262848
Jenkins CI successfully triggered : [windows-cpu, windows-gpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #20338: [1.x] [FEATURE] Add API to control denormalized computations
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #20338:
URL: https://github.com/apache/incubator-mxnet/pull/20338#issuecomment-861287871
Hey @szha,
enabling FTZ and DAZ introduces CI fail in test_numpy_interoperability.py::test_np_array_ufunc_protocol
Problematic function is `remainder` and I'm not sure how this should be handled - should it be disabling FTZ for this test, edited workload or maybe something different?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych edited a comment on pull request #20338: [1.x] [FEATURE] Add API to control denormalized computations
Posted by GitBox <gi...@apache.org>.
bgawrych edited a comment on pull request #20338:
URL: https://github.com/apache/incubator-mxnet/pull/20338#issuecomment-861287871
Hey @szha,
enabling FTZ and DAZ introduces CI fail in test_numpy_interoperability.py::test_np_array_ufunc_protocol
Problematic function is `remainder` and I'm not sure how this should be handled - should it be disabling FTZ for this test, editing workload or maybe something different?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20338: [1.x] [FEATURE] Add API to control denormalized computations
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20338:
URL: https://github.com/apache/incubator-mxnet/pull/20338#issuecomment-874039189
Jenkins CI successfully triggered : [unix-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #20338: [1.x] [FEATURE] Add API to control denormalized computations
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #20338:
URL: https://github.com/apache/incubator-mxnet/pull/20338#discussion_r657103406
##########
File path: python/mxnet/util.py
##########
@@ -848,3 +848,20 @@ def setenv(name, value):
"""
passed_value = None if value is None else c_str(value)
check_call(_LIB.MXSetEnv(c_str(name), passed_value))
+
+def set_flush_denorms(value):
+ """Change floating-point calculations when dealing with denormalized values.
+ This is only applicable to architectures which supports flush-to-zero.
+ Denormalized values are positive and negative values that are very close to 0
+ (exponent is the smallest possible value).
+ Flushing denormalized values to 0 can speedup calculations if such values occurs,
+ but if fulfilling whole IEEE 754 standard is required this option should be disabled.
+ Parameters
+ ----------
+ value : bool
+ State of flush-to-zero and denormals-are-zero in MXCSR register
Review comment:
@ptrendx is there an equivalent setting for CUDA? What behavior should we expect for denormal values in GPU calculation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #20338: [1.x] [FEATURE] Add API to control denormalized computations
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #20338:
URL: https://github.com/apache/incubator-mxnet/pull/20338#discussion_r657238466
##########
File path: python/mxnet/util.py
##########
@@ -848,3 +848,20 @@ def setenv(name, value):
"""
passed_value = None if value is None else c_str(value)
check_call(_LIB.MXSetEnv(c_str(name), passed_value))
+
+def set_flush_denorms(value):
+ """Change floating-point calculations when dealing with denormalized values.
+ This is only applicable to architectures which supports flush-to-zero.
+ Denormalized values are positive and negative values that are very close to 0
+ (exponent is the smallest possible value).
+ Flushing denormalized values to 0 can speedup calculations if such values occurs,
+ but if fulfilling whole IEEE 754 standard is required this option should be disabled.
+ Parameters
+ ----------
+ value : bool
+ State of flush-to-zero and denormals-are-zero in MXCSR register
Review comment:
So in order to implement this as runtime behavior, mxnet needs to call different functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20338: [1.x] [FEATURE] Add API to control denormalized computations
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20338:
URL: https://github.com/apache/incubator-mxnet/pull/20338#issuecomment-871946740
Jenkins CI successfully triggered : [windows-gpu, sanity, website, clang, centos-cpu, unix-cpu, centos-gpu, unix-gpu, edge, windows-cpu, miscellaneous]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #20338: [1.x] [FEATURE] Add API to control denormalized computations
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #20338:
URL: https://github.com/apache/incubator-mxnet/pull/20338#issuecomment-874039133
@mxnet-bot run ci [unix-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20338: [1.x] [FEATURE] Add API to control denormalized computations
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20338:
URL: https://github.com/apache/incubator-mxnet/pull/20338#issuecomment-866799089
Jenkins CI successfully triggered : [unix-gpu, windows-gpu, windows-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #20338: [1.x] [FEATURE] Add API to control denormalized computations
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #20338:
URL: https://github.com/apache/incubator-mxnet/pull/20338#issuecomment-867398533
There is issue in windows CI not connected to this change (visible also in https://github.com/apache/incubator-mxnet/pull/20379)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #20338: [1.x] [FEATURE] Add API to control denormalized computations
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #20338:
URL: https://github.com/apache/incubator-mxnet/pull/20338#discussion_r657102332
##########
File path: python/mxnet/util.py
##########
@@ -848,3 +848,20 @@ def setenv(name, value):
"""
passed_value = None if value is None else c_str(value)
check_call(_LIB.MXSetEnv(c_str(name), passed_value))
+
+def set_flush_denorms(value):
+ """Change floating-point calculations when dealing with denormalized values.
+ This is only applicable to architectures which supports flush-to-zero.
+ Denormalized values are positive and negative values that are very close to 0
+ (exponent is the smallest possible value).
+ Flushing denormalized values to 0 can speedup calculations if such values occurs,
+ but if fulfilling whole IEEE 754 standard is required this option should be disabled.
+ Parameters
+ ----------
+ value : bool
+ State of flush-to-zero and denormals-are-zero in MXCSR register
Review comment:
```suggestion
def set_flush_denorms(value):
"""Change floating-point calculations on CPU when dealing with denormalized values.
This is only applicable to architectures which supports flush-to-zero.
Denormalized values are positive and negative values that are very close to 0
(exponent is the smallest possible value).
Flushing denormalized values to 0 can speedup calculations if such values occurs,
but if fulfilling whole IEEE 754 standard is required this option should be disabled.
Parameters
----------
value : bool
State of flush-to-zero and denormals-are-zero in MXCSR register
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #20338: [1.x] [FEATURE] Add API to control denormalized computations
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #20338:
URL: https://github.com/apache/incubator-mxnet/pull/20338#issuecomment-866799017
@mxnet-bot run ci [unix-gpu, windows-cpu, windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #20338: [1.x] [FEATURE] Add API to control denormalized computations
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #20338:
URL: https://github.com/apache/incubator-mxnet/pull/20338#issuecomment-871946649
@mxnet-bot run ci [all]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #20338: [1.x] [FEATURE] Add API to control denormalized computations
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #20338:
URL: https://github.com/apache/incubator-mxnet/pull/20338#discussion_r662408669
##########
File path: include/mxnet/c_api.h
##########
@@ -261,6 +261,14 @@ MXNET_DLL int MXRandomSeed(int seed);
*/
MXNET_DLL int MXRandomSeedContext(int seed, int dev_type, int dev_id);
+/*!
+ * \brief Change floating-point calculations when dealing with denormalized values.
Review comment:
We may also note down the default value when mxnet backend is initialized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #20338: [1.x] [FEATURE] Add API to control denormalized computations
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #20338:
URL: https://github.com/apache/incubator-mxnet/pull/20338#issuecomment-868262804
@mxnet-bot run ci [unix-gpu, windows-cpu, windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #20338: [1.x] [FEATURE] Add API to control denormalized computations
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #20338:
URL: https://github.com/apache/incubator-mxnet/pull/20338#issuecomment-874039133
@mxnet-bot run ci [unix-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20338: [1.x] [FEATURE] Add API to control denormalized computations
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20338:
URL: https://github.com/apache/incubator-mxnet/pull/20338#issuecomment-858419531
Hey @bgawrych , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [unix-gpu, centos-gpu, clang, windows-gpu, edge, sanity, miscellaneous, unix-cpu, website, windows-cpu, centos-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20338: [1.x] [FEATURE] Add API to control denormalized computations
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20338:
URL: https://github.com/apache/incubator-mxnet/pull/20338#issuecomment-860747328
Jenkins CI successfully triggered : [unix-gpu, windows-gpu, centos-gpu, windows-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] anko-intel commented on a change in pull request #20338: [1.x] [FEATURE] Add API to control denormalized computations
Posted by GitBox <gi...@apache.org>.
anko-intel commented on a change in pull request #20338:
URL: https://github.com/apache/incubator-mxnet/pull/20338#discussion_r665130850
##########
File path: tests/python/unittest/test_numpy_interoperability.py
##########
@@ -3008,6 +3009,7 @@ def _check_interoperability_helper(op_name, rel_tol, abs_tol, *args, **kwargs):
assert False
if not is_op_runnable():
return
+
Review comment:
Empy line added by mistake?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org