You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/01 21:07:26 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
ustcweizhou opened a new pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627
### Description
This PR fixes an issue that expunging vm will remove dhcp entries of another vm in VR
Steps to reproduce the issue
(1) create two vm wei-001 wei-002, and wei-003 start them.
Assume that wei-001 has the biggest ip (order by char, not number. for example 192.168.0.99 > 192.168.0.100)
(2) check /etc/cloudstack/dhcpentry.json and /etc/dhcphosts.txt in VR
They have entries for all vms
(3) stop wei-002 and wei-003, then restart VR (or restart network with cleanup).
check /etc/cloudstack/dhcpentry.json and /etc/dhcphosts.txt in VR
They have entries for wei-001 only (as wei-002 and wei-003 are stopped)
(4) expunge wei-002. when it is done,
check /etc/cloudstack/dhcpentry.json and /etc/dhcphosts.txt in VR
The last entry ("id": "dhcpentry") is removed.
(5) expunge wei-003, when it is done.
check /etc/cloudstack/dhcpentry.json and /etc/dhcphosts.txt in VR
the entry for wei-001 is removed, and the ip is removed from /etc/dhcphosts.txt
VR health check fails at dhcp_check.py and dns_check.py
This does not always happen, as the last items in /etc/cloudstack/dhcpentry.json are order by ip addresses.
if the last item is dhcp entry for a running vm , its dhcp info will be removed from dnsmasq.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [X] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-771575348
not sure why but I'm still not able to reproduce this.
My VMs were like,
VM-001 - IP: 10.1.1.206
VM-002 - IP: 10.1.1.157
VM-003 - IP: 10.1.1.117
After I stopped VM-002 & VM-003, restarted network with cleanup and then expunged VM-002, the last entry in /etc/cloudstack/dhcpentry.json was not removed.
Later, on expunging VM-003, /etc/dhcphosts.txt still had an entry for VM-001
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-773223902
> @shwstppr can you test with Ubuntu 18.04 and see if that helps? @weizhouapache is the env adv zone or adv zone with SG, or some other permutation?
@rhtyd @shwstppr I use advanced zone with isolated networks.
I will test with shared networks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache edited a comment on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
weizhouapache edited a comment on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-772496128
> @weizhouapache I was testing 4.14, #4150 to be specific
@shwstppr I have tested with 4.14, 4.15 and 4.16. this issue can be reproduced.
I use ubuntu for testing.
could you please try again ? it is better to create 4 vms (2 are running, 2 are stopped) for testing.
correction: it looks the ips are randomly removed from /etc/cloudstack/dhcpentry.json, not always the last ip.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-772310675
> not sure why but I'm still not able to reproduce this.
> My VMs were like,
> VM-001 - IP: 10.1.1.206
> VM-002 - IP: 10.1.1.157
> VM-003 - IP: 10.1.1.117
>
> After I stopped VM-002 & VM-003, restarted network with cleanup and then expunged VM-002, the last entry in /etc/cloudstack/dhcpentry.json was not removed.
> Later, on expunging VM-003, /etc/dhcphosts.txt still had an entry for VM-001
@shwstppr strange.
I will test with cloudstack 4.16
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-772185784
<b>Trillian test result (tid-3478)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42266 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4627-t3478-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-768876320
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-772496128
> @weizhouapache I was testing 4.14, #4150 to be specific
@shwstppr I have tested with 4.14, 4.15 and 4.16. this issue can be reproduced.
I use ubuntu for testing.
could you please try again ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-771677865
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2639
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-771691707
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-771541154
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-773150101
@shwstppr can you test with Ubuntu 18.04 and see if that helps? @weizhouapache is the env adv zone or adv zone with SG, or some other permutation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-768378990
@rhtyd @DaanHoogland @shwstppr
this looks like a major issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-771409315
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-771541925
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-773150101
@shwstppr can you test with Ubuntu 18.04 and see if that helps? @weizhouapache is the env adv zone or adv zone with SG, or some other permutation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-769813924
> @weizhouapache in final step. After expunging second VM, VR still had an entry for the first VM.
> Also just for info, I was testing with an isolated network.
@shwstppr it is strange. which cloudstack version did you test ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-773223902
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-773260094
@weizhouapache @rhtyd I'm to reproduce the issue with 4.14 with Ubuntu18 mgmt and hosts. Testing the fix now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-769764378
> I'm not able to reproduce the issue on a KVM and a VMware environment. Can someone else verify @vladimirpetrov @nvazquez @rhtyd
@shwstppr did you follow the steps in description ? in which step you have different result ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-771541925
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache edited a comment on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
weizhouapache edited a comment on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-772496128
> @weizhouapache I was testing 4.14, #4150 to be specific
@shwstppr I have tested with 4.14, 4.15 and 4.16. this issue can be reproduced.
I use ubuntu for testing.
could you please try again ?
correction: it looks the ips are randomly removed from /etc/cloudstack/dhcpentry.json, not always the last ip.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-771691238
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-769795449
@weizhouapache in final step. After expunging second VM, VR still had an entry for the first VM.
Also just for info, I was testing with an isolated network.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-773260094
@weizhouapache @rhtyd I'm to reproduce the issue with 4.14 with Ubuntu18 mgmt and hosts. Testing the fix now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-768904579
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2611
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-768877115
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-773239570
> > @shwstppr can you test with Ubuntu 18.04 and see if that helps? @weizhouapache is the env adv zone or adv zone with SG, or some other permutation?
>
> @rhtyd @shwstppr I use advanced zone with isolated networks.
> I will test with shared networks.
tested with shared network in advanced zone.
it has the same issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-770684612
@shwstppr can you test against Wei's steps to reproduce the issue against latest 4.14 branch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-769729261
I'm not able to reproduce the issue on a KVM and a VMware environment. Can someone else verify @vladimirpetrov @nvazquez @rhtyd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-771572791
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2631
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-771541154
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-771409315
@weizhouapache will test and update
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-771158325
@shwstppr I updated the steps in description.
the issue can be reproduced.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-772322537
@weizhouapache I was testing 4.14, #4150 to be specific
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-771691238
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-770699166
> @shwstppr can you test against Wei's steps to reproduce the issue against latest 4.14 branch
@rhtyd @shwstppr
I tested with 4.15. it cannot be reproduced. strange
closed this pr. I will double check with 4.14
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org