You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "maedhroz (via GitHub)" <gi...@apache.org> on 2024/05/08 17:37:37 UTC
[PR] cep-15-accord 5/7/2024 trunk rebase [cassandra]
maedhroz opened a new pull request, #3297:
URL: https://github.com/apache/cassandra/pull/3297
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] cep-15-accord 5/7/2024 trunk rebase [cassandra]
Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz commented on PR #3297:
URL: https://github.com/apache/cassandra/pull/3297#issuecomment-2105009478
`cep-15-accord` is now rebased to `trunk` at 534da538d229a5b4fc1d9ef7cc8b37ead455191c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] cep-15-accord 5/7/2024 trunk rebase [cassandra]
Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz commented on PR #3297:
URL: https://github.com/apache/cassandra/pull/3297#issuecomment-2104618884
@beobal I think the only reason StreamSummarySerializer doesn’t always get the partitioner from the TableId/CFS is SerializationsTest et al. Perhaps there’s a less janky way to do that…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] cep-15-accord 5/7/2024 trunk rebase [cassandra]
Posted by "beobal (via GitHub)" <gi...@apache.org>.
beobal commented on code in PR #3297:
URL: https://github.com/apache/cassandra/pull/3297#discussion_r1596330187
##########
src/java/org/apache/cassandra/dht/IPartitionerDependentSerializer.java:
##########
@@ -51,11 +41,8 @@ public interface IPartitionerDependentSerializer<T>
*/
public T deserialize(DataInputPlus in, IPartitioner p, int version) throws IOException;
- /**
- * Calculate serialized size of object without actually serializing.
- * @param t object to calculate serialized size
- * @param version protocol version
- * @return serialized size of object t
- */
- public long serializedSize(T t, int version);
+ default T deserialize(DataInputPlus in, int version) throws IOException
+ {
+ return deserialize(in, null, version);
Review Comment:
Would it make more sense to default to `IPartitioner.global`, rather than `null`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] cep-15-accord 5/7/2024 trunk rebase [cassandra]
Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz closed pull request #3297: cep-15-accord 5/7/2024 trunk rebase
URL: https://github.com/apache/cassandra/pull/3297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] cep-15-accord 5/7/2024 trunk rebase [cassandra]
Posted by "beobal (via GitHub)" <gi...@apache.org>.
beobal commented on code in PR #3297:
URL: https://github.com/apache/cassandra/pull/3297#discussion_r1596330187
##########
src/java/org/apache/cassandra/dht/IPartitionerDependentSerializer.java:
##########
@@ -51,11 +41,8 @@ public interface IPartitionerDependentSerializer<T>
*/
public T deserialize(DataInputPlus in, IPartitioner p, int version) throws IOException;
- /**
- * Calculate serialized size of object without actually serializing.
- * @param t object to calculate serialized size
- * @param version protocol version
- * @return serialized size of object t
- */
- public long serializedSize(T t, int version);
+ default T deserialize(DataInputPlus in, int version) throws IOException
+ {
+ return deserialize(in, null, version);
Review Comment:
Would it make more sense to default to `IPartitioner.global`, rather than `null`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] cep-15-accord 5/7/2024 trunk rebase [cassandra]
Posted by "beobal (via GitHub)" <gi...@apache.org>.
beobal commented on PR #3297:
URL: https://github.com/apache/cassandra/pull/3297#issuecomment-2104696268
Disclaimer: I didn't do a full CI run on that yet, so I don't know which other tests are affected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] cep-15-accord 5/7/2024 trunk rebase [cassandra]
Posted by "beobal (via GitHub)" <gi...@apache.org>.
beobal commented on PR #3297:
URL: https://github.com/apache/cassandra/pull/3297#issuecomment-2104694902
How about https://github.com/beobal/cassandra/commit/e8a6c58662cb51bbd42b1c848292a122acb2eec7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org