You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2019/12/06 07:32:35 UTC

[GitHub] [helix] narendly commented on a change in pull request #644: Customize IZkStateListener to add handleNewSession(sessionId)

narendly commented on a change in pull request #644: Customize IZkStateListener to add handleNewSession(sessionId)
URL: https://github.com/apache/helix/pull/644#discussion_r354692319
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/manager/zk/client/HelixZkClient.java
 ##########
 @@ -35,8 +36,48 @@
 
   void unsubscribeDataChanges(String path, IZkDataListener listener);
 
+  /*
+   * This is for backwards compatibility.
 
 Review comment:
   Nit: backward-compatibility

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org