You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2020/06/29 15:28:45 UTC
[commons-numbers] 07/08: Use assertTrue/False when testing the
equals method
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit 7b57fc870aa7b08f0460d2198f57c0f379630c8e
Author: aherbert <ah...@apache.org>
AuthorDate: Mon Jun 29 16:09:37 2020 +0100
Use assertTrue/False when testing the equals method
---
.../java/org/apache/commons/numbers/fraction/BigFractionTest.java | 2 +-
.../test/java/org/apache/commons/numbers/fraction/FractionTest.java | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java
index a457767..81e8774 100644
--- a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java
+++ b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java
@@ -625,7 +625,7 @@ public class BigFractionTest {
@Test
void testEqualsAndHashCode() {
final BigFraction zero = BigFraction.of(0, 1);
- Assertions.assertEquals(zero, zero);
+ Assertions.assertTrue(zero.equals(zero));
Assertions.assertFalse(zero.equals(null));
Assertions.assertFalse(zero.equals(new Object()));
Assertions.assertFalse(zero.equals(Double.valueOf(0)));
diff --git a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java
index 0c5bc3e..f50eee0 100644
--- a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java
+++ b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java
@@ -463,8 +463,8 @@ public class FractionTest {
@Test
void testEqualsAndHashCode() {
final Fraction zero = Fraction.of(0, 1);
- Assertions.assertEquals(zero, zero);
- Assertions.assertNotEquals(zero, null);
+ Assertions.assertTrue(zero.equals(zero));
+ Assertions.assertFalse(zero.equals(null));
Assertions.assertFalse(zero.equals(new Object()));
Assertions.assertFalse(zero.equals(Double.valueOf(0)));