You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "aho135 (via GitHub)" <gi...@apache.org> on 2023/07/21 18:45:40 UTC
[PR] Fix time unit for handoff in CoordinatorBasedSegmentHandoffNotifier (druid)
aho135 opened a new pull request, #14640:
URL: https://github.com/apache/druid/pull/14640
<!-- Thanks for trying to help us make Apache Druid be the best it can be! Please fill out as much of the following information as is possible (where relevant, and remove it when irrelevant) to help make the intention and scope of this PR clear in order to ease review. -->
<!-- Please read the doc for contribution (https://github.com/apache/druid/blob/master/CONTRIBUTING.md) before making this PR. Also, once you open a PR, please _avoid using force pushes and rebasing_ since these make it difficult for reviewers to see what you've changed in response to their reviews. See [the 'If your pull request shows conflicts with master' section](https://github.com/apache/druid/blob/master/CONTRIBUTING.md#if-your-pull-request-shows-conflicts-with-master) for more details. -->
### Description
Fixes time unit for Segment Handoff log from seconds to milliseconds
<!-- Describe the goal of this PR, what problem are you fixing. If there is a corresponding issue (referenced above), it's not necessary to repeat the description here, however, you may choose to keep one summary sentence. -->
<!-- Describe your patch: what did you change in code? How did you fix the problem? -->
Changed secs to ms for time unit in CoordinatorBasedSegmentHandoffNotifier
<!-- If there are several relatively logically separate changes in this PR, create a mini-section for each of them. For example: -->
#### Fixed the bug ...
#### Renamed the class ...
#### Added a forbidden-apis entry ...
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition, design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design (or naming) decision point and compare the alternatives with the designs that you've implemented (or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere (e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list), link to that discussion from this PR description and explain what have changed in your final design compared to your original proposal or the consensus version in the end of the discussion. If something hasn't changed since the original discussion, you can omit a detailed discussion of those aspects of the design here, perhaps apart from brief mentioning for the sake of readability of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
#### Release note
<!-- Give your best effort to summarize your changes in a couple of sentences aimed toward Druid users.
Improved logging in CoordinatorBasedSegmentHandoffNotifier during segment handoff
If your change doesn't have end user impact, you can skip this section.
For tips about how to write a good release note, see [Release notes](https://github.com/apache/druid/blob/master/CONTRIBUTING.md#release-notes).
-->
<hr>
##### Key changed/added classes in this PR
CoordinatorBasedSegmentHandoffNotifier
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [X] been self-reviewed.
- [X] added documentation for new or modified features or behaviors.
- [X] a release note entry in the PR description.
- [X] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [X] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [X] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [X] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [X] added integration tests.
- [X] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix time unit for handoff in CoordinatorBasedSegmentHandoffNotifier (druid)
Posted by "aho135 (via GitHub)" <gi...@apache.org>.
aho135 commented on code in PR #14640:
URL: https://github.com/apache/druid/pull/14640#discussion_r1271162053
##########
server/src/main/java/org/apache/druid/segment/handoff/CoordinatorBasedSegmentHandoffNotifier.java:
##########
@@ -128,7 +128,7 @@ void checkForSegmentHandoffs()
catch (Throwable t) {
log.error(
t,
- "Exception while checking handoff for dataSource[%s], Will try again after [%d]secs",
+ "Exception while checking handoff for dataSource[%s], Will try again after [%d]ms",
Review Comment:
Thanks for the review @abhishekrb19 Just pushed an update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix time unit for handoff in CoordinatorBasedSegmentHandoffNotifier (druid)
Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz commented on code in PR #14640:
URL: https://github.com/apache/druid/pull/14640#discussion_r1271375977
##########
server/src/main/java/org/apache/druid/segment/handoff/CoordinatorBasedSegmentHandoffNotifier.java:
##########
@@ -114,10 +115,10 @@ void checkForSegmentHandoffs()
catch (Exception e) {
log.error(
e,
- "Exception while checking handoff for dataSource[%s] Segment[%s], Will try again after [%d]secs",
+ "Exception while checking handoff for dataSource[%s] Segment[%s]; will try again after [%s]",
dataSource,
descriptor,
- pollDurationMillis
+ pollDuration.toString()
Review Comment:
You can just use `pollDuration` instead of `pollDuration.toString()` here as the `.toString()` is implicit.
##########
server/src/main/java/org/apache/druid/segment/handoff/CoordinatorBasedSegmentHandoffNotifier.java:
##########
@@ -128,9 +129,9 @@ void checkForSegmentHandoffs()
catch (Throwable t) {
log.error(
t,
- "Exception while checking handoff for dataSource[%s], Will try again after [%d]secs",
+ "Exception while checking handoff for dataSource[%s]; will try again after [%s]",
dataSource,
- pollDurationMillis
+ pollDuration.toString()
Review Comment:
Same comment here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix time unit for handoff in CoordinatorBasedSegmentHandoffNotifier (druid)
Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz merged PR #14640:
URL: https://github.com/apache/druid/pull/14640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix time unit for handoff in CoordinatorBasedSegmentHandoffNotifier (druid)
Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz commented on code in PR #14640:
URL: https://github.com/apache/druid/pull/14640#discussion_r1271428045
##########
server/src/main/java/org/apache/druid/segment/handoff/CoordinatorBasedSegmentHandoffNotifier.java:
##########
@@ -27,6 +27,7 @@
import org.apache.druid.query.SegmentDescriptor;
import org.apache.druid.server.coordination.DruidServerMetadata;
+import org.joda.time.Duration;
Review Comment:
```suggestion
import org.joda.time.Duration;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix time unit for handoff in CoordinatorBasedSegmentHandoffNotifier (druid)
Posted by "abhishekrb19 (via GitHub)" <gi...@apache.org>.
abhishekrb19 commented on code in PR #14640:
URL: https://github.com/apache/druid/pull/14640#discussion_r1271141724
##########
server/src/main/java/org/apache/druid/segment/handoff/CoordinatorBasedSegmentHandoffNotifier.java:
##########
@@ -114,7 +114,7 @@ void checkForSegmentHandoffs()
catch (Exception e) {
log.error(
e,
- "Exception while checking handoff for dataSource[%s] Segment[%s], Will try again after [%d]secs",
+ "Exception while checking handoff for dataSource[%s] Segment[%s], Will try again after [%d]ms",
Review Comment:
```suggestion
"Exception while checking handoff for datasource[%s] segment[%s]; will try again after in [%s]",
```
```
##########
server/src/main/java/org/apache/druid/segment/handoff/CoordinatorBasedSegmentHandoffNotifier.java:
##########
@@ -128,7 +128,7 @@ void checkForSegmentHandoffs()
catch (Throwable t) {
log.error(
t,
- "Exception while checking handoff for dataSource[%s], Will try again after [%d]secs",
+ "Exception while checking handoff for dataSource[%s], Will try again after [%d]ms",
Review Comment:
```suggestion
"Exception while checking handoff for datasource[%s]; will try again after [%s]",
```
##########
server/src/main/java/org/apache/druid/segment/handoff/CoordinatorBasedSegmentHandoffNotifier.java:
##########
@@ -114,7 +114,7 @@ void checkForSegmentHandoffs()
catch (Exception e) {
log.error(
e,
- "Exception while checking handoff for dataSource[%s] Segment[%s], Will try again after [%d]secs",
+ "Exception while checking handoff for dataSource[%s] Segment[%s], Will try again after [%d]ms",
dataSource,
descriptor,
pollDurationMillis
Review Comment:
```suggestion
new Duration(pollDurationMillis).toString()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix time unit for handoff in CoordinatorBasedSegmentHandoffNotifier (druid)
Posted by "aho135 (via GitHub)" <gi...@apache.org>.
aho135 commented on code in PR #14640:
URL: https://github.com/apache/druid/pull/14640#discussion_r1271481856
##########
server/src/main/java/org/apache/druid/segment/handoff/CoordinatorBasedSegmentHandoffNotifier.java:
##########
@@ -27,6 +27,7 @@
import org.apache.druid.query.SegmentDescriptor;
import org.apache.druid.server.coordination.DruidServerMetadata;
+import org.joda.time.Duration;
Review Comment:
Thanks for the review @kfaraz! Just pushed this fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix time unit for handoff in CoordinatorBasedSegmentHandoffNotifier (druid)
Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz commented on code in PR #14640:
URL: https://github.com/apache/druid/pull/14640#discussion_r1271236120
##########
server/src/main/java/org/apache/druid/segment/handoff/CoordinatorBasedSegmentHandoffNotifier.java:
##########
@@ -114,10 +115,10 @@ void checkForSegmentHandoffs()
catch (Exception e) {
log.error(
e,
- "Exception while checking handoff for dataSource[%s] Segment[%s], Will try again after [%d]secs",
+ "Exception while checking handoff for dataSource[%s] Segment[%s]; will try again after [%s]",
dataSource,
descriptor,
- pollDurationMillis
+ Duration.ofMillis(pollDurationMillis).toString()
Review Comment:
We might as well just change the field `long pollDurationMillis` to be `Duration pollDuration` instead. The constructor already takes a `Duration`. We could also use `ScheduledExecutors.scheduleAtFixedRate` in line 75 for a `Duration` friendly invocation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix time unit for handoff in CoordinatorBasedSegmentHandoffNotifier (druid)
Posted by "abhishekrb19 (via GitHub)" <gi...@apache.org>.
abhishekrb19 commented on code in PR #14640:
URL: https://github.com/apache/druid/pull/14640#discussion_r1271141724
##########
server/src/main/java/org/apache/druid/segment/handoff/CoordinatorBasedSegmentHandoffNotifier.java:
##########
@@ -114,7 +114,7 @@ void checkForSegmentHandoffs()
catch (Exception e) {
log.error(
e,
- "Exception while checking handoff for dataSource[%s] Segment[%s], Will try again after [%d]secs",
+ "Exception while checking handoff for dataSource[%s] Segment[%s], Will try again after [%d]ms",
Review Comment:
```suggestion
"Exception while checking handoff for datasource[%s] segment[%s]; will try again after [%s]",
```
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix time unit for handoff in CoordinatorBasedSegmentHandoffNotifier (druid)
Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz commented on code in PR #14640:
URL: https://github.com/apache/druid/pull/14640#discussion_r1271428083
##########
server/src/main/java/org/apache/druid/segment/handoff/CoordinatorBasedSegmentHandoffNotifier.java:
##########
@@ -27,6 +27,7 @@
import org.apache.druid.query.SegmentDescriptor;
import org.apache.druid.server.coordination.DruidServerMetadata;
+import org.joda.time.Duration;
Review Comment:
this is causing checkstyle to fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org