Review Request: FLUME-1587: FileChannel Encryption cannot be disabled on a running channel

[Brock Noland <br...@cloudera.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7210/
-----------------------------------------------------------

Review request for Flume.


Description
-------

Disabling encryption on a running channel cannot be supported because files maybe encrypted which are needed during replay. This change improves the error message to indicate as such. Additionally, any exceptions thrown during configuration are logged but not thrown up. This is done because of FLUME-1598. The modification of the close() method incorporates FLUME-1588 into this patch.


This addresses bug FLUME-1587.
    https://issues.apache.org/jira/browse/FLUME-1587


Diffs
-----

  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java c2e904b 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileV3.java 5de6e82 
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelBase.java 3da09ab 
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java 68285cc 
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/encryption/TestFileChannelEncryption.java d2f5208 
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/encryption/TestFileChannelEncryptionBase.java PRE-CREATION 
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/encryption/TestFileChannelEncryptionRestart.java PRE-CREATION 

Diff: https://reviews.apache.org/r/7210/diff/


Testing
-------

Unit test added and unit tests pass.


Thanks,

Brock Noland