You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by "Sanjays2402 (via GitHub)" <gi...@apache.org> on 2026/07/23 06:38:08 UTC
[PR] [Azure Blobs] Forward chunk_size in download_object_as_stream [libcloud]
Sanjays2402 opened a new pull request, #2169:
URL: https://github.com/apache/libcloud/pull/2169
## [Azure Blobs] Forward chunk_size in download_object_as_stream
### Description
Closes #1698. `download_object_as_stream` and `download_object_range_as_stream` in the Azure Blobs driver passed the hardcoded `AZURE_DOWNLOAD_CHUNK_SIZE` to `iter_content` instead of the caller's `chunk_size`, so a requested size was silently ignored. Both now forward `chunk_size` (falling back to the default when `None`), matching the S3 driver's behavior.
### Status
- done, ready for review
### Checklist (tick everything that applies)
- [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
- [ ] Documentation
- [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Azure Blobs] Forward chunk_size in download_object_as_stream [libcloud]
Posted by "micafer (via GitHub)" <gi...@apache.org>.
micafer merged PR #2169:
URL: https://github.com/apache/libcloud/pull/2169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Azure Blobs] Forward chunk_size in download_object_as_stream [libcloud]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2169:
URL: https://github.com/apache/libcloud/pull/2169#issuecomment-5069364835
## [Codecov](https://app.codecov.io/gh/apache/libcloud/pull/2169?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 83.39%. Comparing base ([`fe948d0`](https://app.codecov.io/gh/apache/libcloud/commit/fe948d052e7e9c45c3c68d13658e351cf993a8a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5385be3`](https://app.codecov.io/gh/apache/libcloud/commit/5385be341b440356231d5ecd0132973bc4b3539e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## trunk #2169 +/- ##
=======================================
Coverage 83.39% 83.39%
=======================================
Files 351 351
Lines 81504 81519 +15
Branches 8747 8747
=======================================
+ Hits 67967 67982 +15
Misses 10744 10744
Partials 2793 2793
```
| [Files with missing lines](https://app.codecov.io/gh/apache/libcloud/pull/2169?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [libcloud/storage/drivers/azure\_blobs.py](https://app.codecov.io/gh/apache/libcloud/pull/2169?src=pr&el=tree&filepath=libcloud%2Fstorage%2Fdrivers%2Fazure_blobs.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGliY2xvdWQvc3RvcmFnZS9kcml2ZXJzL2F6dXJlX2Jsb2JzLnB5) | `86.78% <100.00%> (ø)` | |
| [libcloud/test/storage/test\_azure\_blobs.py](https://app.codecov.io/gh/apache/libcloud/pull/2169?src=pr&el=tree&filepath=libcloud%2Ftest%2Fstorage%2Ftest_azure_blobs.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGliY2xvdWQvdGVzdC9zdG9yYWdlL3Rlc3RfYXp1cmVfYmxvYnMucHk=) | `94.69% <100.00%> (+0.14%)` | :arrow_up: |
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org