You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/06 00:37:58 UTC
[PR] test: cover notification test endpoint channels [rocketmq-dashboard]
yyqdbngt opened a new pull request, #3895:
URL: https://github.com/apache/rocketmq-dashboard/pull/3895
### Motivation
The general settings API tests covered loading and saving settings but the notification test endpoint (`testNotification`) had no coverage at all. This PR adds the three channels plus a failure path.
### Changes
- `testNotification('dingtalk' | 'email' | 'sms')` posts with the matching channel param to `/settings/general/test-notification`.
- A provider failure (502) surfaces as a rejected promise.
### Verification
- `vitest run src/api/generalSettings.test.ts`: 8/8 passed
- `tsc --noEmit`: clean
- `eslint src/api/generalSettings.test.ts`: clean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: cover notification test endpoint channels [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3895: test: cover notification test endpoint channels
URL: https://github.com/apache/rocketmq-dashboard/pull/3895
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org