You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Remy Maucherat <re...@apache.org> on 2002/04/25 19:24:28 UTC

2 problems with Coyote and j-t-c/util

1) First one is: with the latest TC 4 code, JK 2 is throwing a NPE on
shutdown (line 185 of ChannelUn); I don't see why it's broken, it was
working fine very little ago.

2) Setting soTimeout doesn't do anything, apparently. I added some code in
the PoolTcpEndpoint, and setSoTimeout is called on the socket with the right
argument (20000 ms in the default configuration). However, when trying with
a telnet, I was able to keep the connection open for a lot more than 20s.
The socket handling in the old connector appears to be very silimar, and yet
it worked fine. What's going on ?

Remy


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: 1 problem with Coyote

Posted by Remy Maucherat <re...@apache.org>.
> Hi Remy,
>
> I would like to add one more method in Coyote - it won't touch
> existing functionality, just add a way for jk to fingure out what webapps
> are configured in the server ( I'm trying to update the auto-conf
> stuff )
>
> Do you mind if I add a new ACTION_WEBAPP hook, with code in the 2
> connectors to call this hook for each webapplication ( all existing
> and every one deployed at runtime ) ?
>
> The code changes are not big, and it won't affect the rest of the code.
>
> I'm not sure what the 'param' should be - for starters I'll just use
> a Hashtable with various attributes for the app ( vhost, context path,
> docbase ).

This seems useful to implement some kind of auto-discovery mechanisms, so
ok.

The NPEs with JK 2 got worse BTW ;-)

Remy


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


1 problem with Coyote

Posted by co...@covalent.net.
Hi Remy,

I would like to add one more method in Coyote - it won't touch
existing functionality, just add a way for jk to fingure out what webapps
are configured in the server ( I'm trying to update the auto-conf
stuff )

Do you mind if I add a new ACTION_WEBAPP hook, with code in the 2
connectors to call this hook for each webapplication ( all existing 
and every one deployed at runtime ) ?

The code changes are not big, and it won't affect the rest of the code.

I'm not sure what the 'param' should be - for starters I'll just use 
a Hashtable with various attributes for the app ( vhost, context path,
docbase ).
 

Costin
   


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: 2 problems with Coyote and j-t-c/util

Posted by Remy Maucherat <re...@apache.org>.
> On Thu, 25 Apr 2002, Remy Maucherat wrote:
>
> > 1) First one is: with the latest TC 4 code, JK 2 is throwing a NPE on
> > shutdown (line 185 of ChannelUn); I don't see why it's broken, it was
> > working fine very little ago.
>
> I'll commit a fix - if APR is not available ChannelUn should be inactive.
> The shutdown was missing the check of if(apr==null).
>
> We can disable ChannelUn and ChannelJni ( i.e. not even try to load them
> unless explicitely configured ), but I hope it won't be necesary.

Thanks. I missed the change which triggered that, somehow.

> > 2) Setting soTimeout doesn't do anything, apparently. I added some code
in
> > the PoolTcpEndpoint, and setSoTimeout is called on the socket with the
right
> > argument (20000 ms in the default configuration). However, when trying
with
> > a telnet, I was able to keep the connection open for a lot more than
20s.
> > The socket handling in the old connector appears to be very silimar, and
yet
> > it worked fine. What's going on ?
>
> I'll check that. I suppose you are talking about the HTTP connector or
> both ? In jk it seems to be a problem, as jk is setting SoTimeout
> directly. From what I know, after the socket is accepted
> setSocketOptions() is called and that should set everything.

And setSocketOptions() does call the setSoTimeout with the right value (I
added a sys.out there), and yet it doesn't appear to be doing anything.

> Strange.

Indeed ;-)
I ran out of ideas, so I called for help :)
Thanks !

Remy


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: 2 problems with Coyote and j-t-c/util

Posted by co...@covalent.net.
On Thu, 25 Apr 2002, Remy Maucherat wrote:

> 1) First one is: with the latest TC 4 code, JK 2 is throwing a NPE on
> shutdown (line 185 of ChannelUn); I don't see why it's broken, it was
> working fine very little ago.

I'll commit a fix - if APR is not available ChannelUn should be inactive.
The shutdown was missing the check of if(apr==null).

We can disable ChannelUn and ChannelJni ( i.e. not even try to load them 
unless explicitely configured ), but I hope it won't be necesary.

 
> 2) Setting soTimeout doesn't do anything, apparently. I added some code in
> the PoolTcpEndpoint, and setSoTimeout is called on the socket with the right
> argument (20000 ms in the default configuration). However, when trying with
> a telnet, I was able to keep the connection open for a lot more than 20s.
> The socket handling in the old connector appears to be very silimar, and yet
> it worked fine. What's going on ?

I'll check that. I suppose you are talking about the HTTP connector or 
both ? In jk it seems to be a problem, as jk is setting SoTimeout 
directly. From what I know, after the socket is accepted 
setSocketOptions() is called and that should set everything. 

Strange. 

Costin


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>