You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by kelvindart <gi...@git.apache.org> on 2017/10/18 22:51:53 UTC
[GitHub] cordova-plugin-file-transfer pull request #192: CB-13294 Remove cordova-plug...
GitHub user kelvindart opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/192
CB-13294 Remove cordova-plugin-compat
### Platforms affected
cordova-android@6.3.0
### What does this PR do?
Removes the dependency on cordova-plugin-compat, and includes checks for min platform version.
### What testing has been done on this change?
Testing 1:
- Add local plugin to project containing cordova-android@6.3.0
- Verify plugin installs, and app runs.
Testing 2:
- Add local plugin to project containing cordova-android@6.2.3
- Verify plugin does not install.
- Console log as follows:
```
Plugin doesn't support this project's cordova-android version. cordova-android: 6.2.3, failed version requirement: >=6.3.0
Skipping 'cordova-plugin-file-transfer' for android
```
This is desirable - this change stops the plugin being installed on `<cordova-android@6.3.0`
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kelvindart/cordova-plugin-file-transfer master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file-transfer/pull/192.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #192
----
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer issue #192: CB-13294 Remove cordova-plugin-comp...
Posted by kelvindart <gi...@git.apache.org>.
Github user kelvindart commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/192
Shoot - so it does. I'll update it later tonight @stevengill. Not sure what I was thinking at the time...
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer issue #192: CB-13294 Remove cordova-plugin-comp...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/192
Actually, this one removes file for some reason. Not compat. Compat doesn't exist here. I'm going to revert this commit
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request #192: CB-13294 Remove cordova-plug...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/192
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org