You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2018/12/13 08:25:46 UTC
Re: Review Request 68018: Added `SeccompFilter` class.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68018/#review211265
-----------------------------------------------------------
We probably need to refactor these helpers a little bit, based on the potential change from the protobuf definition. Let's sync on that first.
src/linux/seccomp/seccomp.hpp
Lines 27 (patched)
<https://reviews.apache.org/r/68018/#comment296204>
Having the linux/seccomp common library to include containerizer.hpp seems a little strange to me. Could we move the seccomp proto to include/mesos/seccomp and create a .hpp file there?
- Gilbert Song
On Nov. 8, 2018, 7:24 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68018/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2018, 7:24 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9034
> https://issues.apache.org/jira/browse/MESOS-9034
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `SeccompFilter` class is a wrapper for `libseccomp` API. Its main
> purpose is to provide a translation of the `ContainerSeccompProfile`
> message into calls of `libseccomp` API.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt bde070445b644e15d46c390d1c983caabaa1fec8
> src/Makefile.am 5da75d3ef263b86af8d914d82cae889830097042
> src/linux/seccomp/seccomp.hpp PRE-CREATION
> src/linux/seccomp/seccomp.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68018/diff/7/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 68018: Added `SeccompFilter` class.
Posted by Andrei Budnik <ab...@mesosphere.com>.
> On Dec. 13, 2018, 8:25 a.m., Gilbert Song wrote:
> > src/linux/seccomp/seccomp.hpp
> > Lines 27 (patched)
> > <https://reviews.apache.org/r/68018/diff/7/?file=2110425#file2110425line27>
> >
> > Having the linux/seccomp common library to include containerizer.hpp seems a little strange to me. Could we move the seccomp proto to include/mesos/seccomp and create a .hpp file there?
I strongly do not recommend to move this header to *public* headers since we don't want to make this class a part of the public API.
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68018/#review211265
-----------------------------------------------------------
On Nov. 8, 2018, 3:24 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68018/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2018, 3:24 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9034
> https://issues.apache.org/jira/browse/MESOS-9034
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `SeccompFilter` class is a wrapper for `libseccomp` API. Its main
> purpose is to provide a translation of the `ContainerSeccompProfile`
> message into calls of `libseccomp` API.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt bde070445b644e15d46c390d1c983caabaa1fec8
> src/Makefile.am 5da75d3ef263b86af8d914d82cae889830097042
> src/linux/seccomp/seccomp.hpp PRE-CREATION
> src/linux/seccomp/seccomp.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68018/diff/7/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 68018: Added `SeccompFilter` class.
Posted by Andrei Budnik <ab...@mesosphere.com>.
> On Dec. 13, 2018, 8:25 a.m., Gilbert Song wrote:
> > src/linux/seccomp/seccomp.hpp
> > Lines 27 (patched)
> > <https://reviews.apache.org/r/68018/diff/7/?file=2110425#file2110425line27>
> >
> > Having the linux/seccomp common library to include containerizer.hpp seems a little strange to me. Could we move the seccomp proto to include/mesos/seccomp and create a .hpp file there?
>
> Andrei Budnik wrote:
> I strongly do not recommend to move this header to *public* headers since we don't want to make this class a part of the public API.
Fixed.
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68018/#review211265
-----------------------------------------------------------
On Nov. 8, 2018, 3:24 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68018/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2018, 3:24 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9034
> https://issues.apache.org/jira/browse/MESOS-9034
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `SeccompFilter` class is a wrapper for `libseccomp` API. Its main
> purpose is to provide a translation of the `ContainerSeccompProfile`
> message into calls of `libseccomp` API.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt bde070445b644e15d46c390d1c983caabaa1fec8
> src/Makefile.am 7a4904a3d67479267087fd2313a263d8218843fa
> src/linux/seccomp/seccomp.hpp PRE-CREATION
> src/linux/seccomp/seccomp.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68018/diff/14/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Budnik
>
>