You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2021/06/04 09:59:26 UTC

[GitHub] [thrift] emmenlau commented on pull request #2401: THRIFT-3840: C++ TJSONProtocol still using locale dependent formatting

emmenlau commented on pull request #2401:
URL: https://github.com/apache/thrift/pull/2401#issuecomment-854547134


   Other than the additional test for `to_string()`, this looks good and valuable to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org