You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Yong Qiao Wang <yq...@cn.ibm.com> on 2015/10/29 13:24:04 UTC
Review Request 39754: Set the UUID of the expected ACK.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39754/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-2864
https://issues.apache.org/jira/browse/MESOS-2864
Repository: mesos
Description
-------
Set the UUID of the expected ACK.
Diffs
-----
src/master/master.cpp 9f4586e668a2141f4937497d42853fbdea7751a5
Diff: https://reviews.apache.org/r/39754/diff/
Testing
-------
Thanks,
Yong Qiao Wang
Re: Review Request 39754: Set the UUID of the expected ACK.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39754/#review104423
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39754]
All tests passed.
- Mesos ReviewBot
On Oct. 29, 2015, 12:25 p.m., Yong Qiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39754/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2015, 12:25 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2864
> https://issues.apache.org/jira/browse/MESOS-2864
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Set the UUID of the expected ACK.
>
>
> Diffs
> -----
>
> src/master/master.cpp 9f4586e668a2141f4937497d42853fbdea7751a5
>
> Diff: https://reviews.apache.org/r/39754/diff/
>
>
> Testing
> -------
>
> Make & Make check succesfully!
>
>
> Thanks,
>
> Yong Qiao Wang
>
>
Re: Review Request 39754: Set the UUID of the expected ACK.
Posted by Yong Qiao Wang <yq...@cn.ibm.com>.
> On 十月 29, 2015, 5:22 p.m., Vinod Kone wrote:
> > Hey Yong. Would you mind if I take over the fix for this? the fix is a bit involved and i would like to cleanup some tech debt in the process. If you are ok with that, please discard this review.
OK, thanks!
- Yong Qiao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39754/#review104449
-----------------------------------------------------------
On 十月 29, 2015, 12:25 p.m., Yong Qiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39754/
> -----------------------------------------------------------
>
> (Updated 十月 29, 2015, 12:25 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2864
> https://issues.apache.org/jira/browse/MESOS-2864
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Set the UUID of the expected ACK.
>
>
> Diffs
> -----
>
> src/master/master.cpp 9f4586e668a2141f4937497d42853fbdea7751a5
>
> Diff: https://reviews.apache.org/r/39754/diff/
>
>
> Testing
> -------
>
> Make & Make check succesfully!
>
>
> Thanks,
>
> Yong Qiao Wang
>
>
Re: Review Request 39754: Set the UUID of the expected ACK.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39754/#review104449
-----------------------------------------------------------
Hey Yong. Would you mind if I take over the fix for this? the fix is a bit involved and i would like to cleanup some tech debt in the process. If you are ok with that, please discard this review.
- Vinod Kone
On Oct. 29, 2015, 12:25 p.m., Yong Qiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39754/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2015, 12:25 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2864
> https://issues.apache.org/jira/browse/MESOS-2864
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Set the UUID of the expected ACK.
>
>
> Diffs
> -----
>
> src/master/master.cpp 9f4586e668a2141f4937497d42853fbdea7751a5
>
> Diff: https://reviews.apache.org/r/39754/diff/
>
>
> Testing
> -------
>
> Make & Make check succesfully!
>
>
> Thanks,
>
> Yong Qiao Wang
>
>
Re: Review Request 39754: Set the UUID of the expected ACK.
Posted by Yong Qiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39754/
-----------------------------------------------------------
(Updated 十月 29, 2015, 12:25 p.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-2864
https://issues.apache.org/jira/browse/MESOS-2864
Repository: mesos
Description
-------
Set the UUID of the expected ACK.
Diffs
-----
src/master/master.cpp 9f4586e668a2141f4937497d42853fbdea7751a5
Diff: https://reviews.apache.org/r/39754/diff/
Testing (updated)
-------
Make & Make check succesfully!
Thanks,
Yong Qiao Wang