You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/13 09:28:29 UTC
[GitHub] [superset] ypankovych opened a new issue, #19687: Can't set verbose name for time grain columns in a slice dropdown
ypankovych opened a new issue, #19687:
URL: https://github.com/apache/superset/issues/19687
A clear and concise description of what the bug is.
#### How to reproduce the bug
1. Go to any dashboard with a slice that has time grains
2. Click on it and see actual column names and not the verbose ones
### Expected results
I'd like to set a verbose name for each column there
### Actual results
Superset backend sends a list of tuples with 2 elements in each, those 2 elements suppose to be column name and verbose name, but there's column name * 2 (doubled): `[(column_name, column_name)]`. When I manually set the second element to its verbose version, superset UI just ignores it and by default gets the element in index 0.
#### Screenshots
here's that dropdown
### Environment
(please complete the following information):
- superset version: `1.4`
- python version: `3.6`
### Additional context
Here's why it happens. Superset sends the wrong data here: https://github.com/apache/superset/blob/6e8e29ce53faffbedfd8e9657d894d87d70eff54/superset/connectors/sqla/models.py#L745 as you can see it simply does `choicify` on it. And here https://github.com/apache/superset/blob/6e8e29ce53faffbedfd8e9657d894d87d70eff54/superset/connectors/sqla/models.py#L683 it just returns column names without verbose version of it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on issue #19687: Can't set verbose name for time grain columns in a slice dropdown
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #19687:
URL: https://github.com/apache/superset/issues/19687#issuecomment-1404627740
There have been quite a few changes in this area since this was reported. @ypankovych can you confirm whether or not you're still facing this on `master` or in Superset 2.0.x?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Can't set verbose name for time grain columns in a slice dropdown [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #19687: Can't set verbose name for time grain columns in a slice dropdown
URL: https://github.com/apache/superset/issues/19687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Can't set verbose name for time grain columns in a slice dropdown [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #19687:
URL: https://github.com/apache/superset/issues/19687#issuecomment-1946859457
Closing this as stale since it's been silent for so long, and we're trying to steer toward a more actionable Issues backlog. If people are still encountering this in current versions (currently 3.x) please re-open this issue, open a new Issue with updated context, or raise a PR to address the problem. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org