You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/12 04:33:03 UTC

[GitHub] [spark] sadikovi commented on pull request #37485: [SPARK-40052] Handle direct byte buffers in VectorizedDeltaBinaryPackedReader

sadikovi commented on PR #37485:
URL: https://github.com/apache/spark/pull/37485#issuecomment-1212720022

   These are all good points. I am running the benchmarks and have updated the PR description with preliminary results. Interestingly, the results with `if` statement are slightly better which means there is a variability with the benchmark. 
   
   @LuciferYang Do you have a specific test case that I can run to compare performance?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org