You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by jeking3 <gi...@git.apache.org> on 2016/07/15 13:36:54 UTC

[GitHub] thrift issue #1049: Fix erlang compact protocol boolean representation

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1049
  
    In order to get this into the project we need an Apache Jira ticket to be opened against the THRIFT project and the pull request to ideally identify this ticket.  I agree with your assessment and your fix.  I would also recommend that as part of this fix we also attempt to re-enable the erlang compact protocol "make cross" tests which appear to be disabled:
    
    jking@dvm-4:~/thrift/test$ grep 'erl' known_failures_Linux.json | grep compact
      "csharp-erl_compact_buffered-ip-ssl",
      "csharp-erl_compact_framed-ip-ssl",
      "erl-cpp_compact_buffered-ip",
      "erl-cpp_compact_buffered-ip-ssl",
      "erl-cpp_compact_framed-ip",
      "erl-cpp_compact_framed-ip-ssl",
      "erl-nodejs_compact_buffered-ip",
      "erl-rb_compact_buffered-ip",
      "erl-rb_compact_framed-ip",



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---