[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #5506: Moved StreamPartitionMsgOffset to be an interface

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #5506:
URL: https://github.com/apache/incubator-pinot/pull/5506#discussion_r437526456



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
##########
@@ -515,7 +519,8 @@ private void createNewSegmentZKMetadata(TableConfig tableConfig, PartitionLevelS
     newSegmentZKMetadata.setTableName(realtimeTableName);
     newSegmentZKMetadata.setSegmentName(segmentName);
     newSegmentZKMetadata.setCreationTime(creationTimeMs);
-    newSegmentZKMetadata.setStartOffset(startOffset);
+    // TODO Issue 5953 Use string offset in the metadata
+    newSegmentZKMetadata.setStartOffset(Long.parseLong(startOffset.toString()));

Review comment:
       I was looking at metadata yesterday, and they are stored as strings. Luckily, the metadata classes don't construct objects directly from json. So, there may be no changes needed for metadata, only change the access method.
   
   Coming soon to a PR near you.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org