[GitHub] [arrow-datafusion] liukun4515 commented on a diff in pull request #3222: Add optimizer rule for type coercion (binary operations only)

[GitBox <gi...@apache.org>]

liukun4515 commented on code in PR #3222:
URL: https://github.com/apache/arrow-datafusion/pull/3222#discussion_r954765102


##########
benchmarks/src/bin/tpch.rs:
##########
@@ -285,11 +285,12 @@ async fn execute_query(
     if debug {
         println!("=== Logical plan ===\n{:?}\n", plan);
     }
-    let plan = ctx.optimize(plan)?;
     if debug {
-        println!("=== Optimized logical plan ===\n{:?}\n", plan);
+        let optimized_plan = ctx.optimize(plan)?;
+        println!("=== Optimized logical plan ===\n{:?}\n", optimized_plan);
     }
-    let physical_plan = ctx.create_physical_plan(&plan).await?;
+    // note that `create_physical_plan` will optimize the plan so we pass the unoptimized plan

Review Comment:
   Is there error or different result for your plan, If it is optimized by some rules more times?
   I also this in my preview pr.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org