You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Pieter Vandepitte (JIRA)" <ji...@apache.org> on 2012/08/28 13:44:07 UTC
[jira] [Created] (WICKET-4734) Button value is double escaped
Pieter Vandepitte created WICKET-4734:
-----------------------------------------
Summary: Button value is double escaped
Key: WICKET-4734
URL: https://issues.apache.org/jira/browse/WICKET-4734
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.5.7
Reporter: Pieter Vandepitte
When the model property of a Button contains html entities (e.g. single quotes), these characters are double escaped: in Button.onComponentTag (getDefaultModelObjectAsString) and in ComponentTag.writeOutput
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4734) Button value is double escaped
Posted by "Sven Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sven Meier resolved WICKET-4734.
--------------------------------
Resolution: Fixed
Fix Version/s: 1.5.9
6.0.1
Aligned with TextField: since model value is written into attribute, call #setEscapeModelValue(false) and let ComponentTag do the escaping.
> Button value is double escaped
> ------------------------------
>
> Key: WICKET-4734
> URL: https://issues.apache.org/jira/browse/WICKET-4734
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.7
> Reporter: Pieter Vandepitte
> Assignee: Sven Meier
> Fix For: 6.0.1, 1.5.9
>
> Attachments: double-escaping.tar.gz, WICKET-4734.patch
>
>
> When the model property of a Button contains html entities (e.g. single quotes), these characters are double escaped: in Button.onComponentTag (getDefaultModelObjectAsString) and in ComponentTag.writeOutput
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4734) Button value is double escaped
Posted by "Pieter Vandepitte (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pieter Vandepitte updated WICKET-4734:
--------------------------------------
Attachment: (was: double-escaping.tar.gz)
> Button value is double escaped
> ------------------------------
>
> Key: WICKET-4734
> URL: https://issues.apache.org/jira/browse/WICKET-4734
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.7
> Reporter: Pieter Vandepitte
> Attachments: double-escaping.tar.gz, double-escaping.tar.gz
>
>
> When the model property of a Button contains html entities (e.g. single quotes), these characters are double escaped: in Button.onComponentTag (getDefaultModelObjectAsString) and in ComponentTag.writeOutput
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4734) Button value is double escaped
Posted by "Andrea Del Bene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443302#comment-13443302 ]
Andrea Del Bene commented on WICKET-4734:
-----------------------------------------
Button should not escape its model in onComponentTag. I think we can safely substitute getDefaultModelObjectAsString with getModel().getObject() and let ComponentTag do its job.
See patch (no test case broken).
> Button value is double escaped
> ------------------------------
>
> Key: WICKET-4734
> URL: https://issues.apache.org/jira/browse/WICKET-4734
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.7
> Reporter: Pieter Vandepitte
> Attachments: double-escaping.tar.gz, WICKET-4734.patch
>
>
> When the model property of a Button contains html entities (e.g. single quotes), these characters are double escaped: in Button.onComponentTag (getDefaultModelObjectAsString) and in ComponentTag.writeOutput
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4734) Button value is double escaped
Posted by "Pieter Vandepitte (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pieter Vandepitte updated WICKET-4734:
--------------------------------------
Comment: was deleted
(was: run mvn jetty:run or mvn test)
> Button value is double escaped
> ------------------------------
>
> Key: WICKET-4734
> URL: https://issues.apache.org/jira/browse/WICKET-4734
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.7
> Reporter: Pieter Vandepitte
> Attachments: double-escaping.tar.gz, double-escaping.tar.gz
>
>
> When the model property of a Button contains html entities (e.g. single quotes), these characters are double escaped: in Button.onComponentTag (getDefaultModelObjectAsString) and in ComponentTag.writeOutput
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4734) Button value is double escaped
Posted by "Andrea Del Bene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrea Del Bene updated WICKET-4734:
------------------------------------
Attachment: WICKET-4734.patch
> Button value is double escaped
> ------------------------------
>
> Key: WICKET-4734
> URL: https://issues.apache.org/jira/browse/WICKET-4734
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.7
> Reporter: Pieter Vandepitte
> Attachments: double-escaping.tar.gz, WICKET-4734.patch
>
>
> When the model property of a Button contains html entities (e.g. single quotes), these characters are double escaped: in Button.onComponentTag (getDefaultModelObjectAsString) and in ComponentTag.writeOutput
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4734) Button value is double escaped
Posted by "Pieter Vandepitte (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pieter Vandepitte updated WICKET-4734:
--------------------------------------
Attachment: (was: double-escaping.tar.gz)
> Button value is double escaped
> ------------------------------
>
> Key: WICKET-4734
> URL: https://issues.apache.org/jira/browse/WICKET-4734
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.7
> Reporter: Pieter Vandepitte
> Attachments: double-escaping.tar.gz
>
>
> When the model property of a Button contains html entities (e.g. single quotes), these characters are double escaped: in Button.onComponentTag (getDefaultModelObjectAsString) and in ComponentTag.writeOutput
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4734) Button value is double escaped
Posted by "Sven Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443468#comment-13443468 ]
Sven Meier commented on WICKET-4734:
------------------------------------
Andrea, of course using getModel().getObject() would work fine too, it's just that TextField does it this way (i.e. setEscapeModelValue(false)).
> Button value is double escaped
> ------------------------------
>
> Key: WICKET-4734
> URL: https://issues.apache.org/jira/browse/WICKET-4734
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.7
> Reporter: Pieter Vandepitte
> Assignee: Sven Meier
> Fix For: 6.0.1, 1.5.9
>
> Attachments: double-escaping.tar.gz, WICKET-4734.patch
>
>
> When the model property of a Button contains html entities (e.g. single quotes), these characters are double escaped: in Button.onComponentTag (getDefaultModelObjectAsString) and in ComponentTag.writeOutput
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (WICKET-4734) Button value is double escaped
Posted by "Sven Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sven Meier reassigned WICKET-4734:
----------------------------------
Assignee: Sven Meier
> Button value is double escaped
> ------------------------------
>
> Key: WICKET-4734
> URL: https://issues.apache.org/jira/browse/WICKET-4734
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.7
> Reporter: Pieter Vandepitte
> Assignee: Sven Meier
> Attachments: double-escaping.tar.gz, WICKET-4734.patch
>
>
> When the model property of a Button contains html entities (e.g. single quotes), these characters are double escaped: in Button.onComponentTag (getDefaultModelObjectAsString) and in ComponentTag.writeOutput
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4734) Button value is double escaped
Posted by "Pieter Vandepitte (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pieter Vandepitte updated WICKET-4734:
--------------------------------------
Attachment: double-escaping.tar.gz
run mvn jetty:run or mvn test
> Button value is double escaped
> ------------------------------
>
> Key: WICKET-4734
> URL: https://issues.apache.org/jira/browse/WICKET-4734
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.7
> Reporter: Pieter Vandepitte
> Attachments: double-escaping.tar.gz, double-escaping.tar.gz
>
>
> When the model property of a Button contains html entities (e.g. single quotes), these characters are double escaped: in Button.onComponentTag (getDefaultModelObjectAsString) and in ComponentTag.writeOutput
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4734) Button value is double escaped
Posted by "Pieter Vandepitte (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pieter Vandepitte updated WICKET-4734:
--------------------------------------
Attachment: double-escaping.tar.gz
> Button value is double escaped
> ------------------------------
>
> Key: WICKET-4734
> URL: https://issues.apache.org/jira/browse/WICKET-4734
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.7
> Reporter: Pieter Vandepitte
> Attachments: double-escaping.tar.gz, double-escaping.tar.gz
>
>
> When the model property of a Button contains html entities (e.g. single quotes), these characters are double escaped: in Button.onComponentTag (getDefaultModelObjectAsString) and in ComponentTag.writeOutput
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4734) Button value is double escaped
Posted by "Emond Papegaaij (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emond Papegaaij updated WICKET-4734:
------------------------------------
Fix Version/s: (was: 6.0.1)
6.1.0
> Button value is double escaped
> ------------------------------
>
> Key: WICKET-4734
> URL: https://issues.apache.org/jira/browse/WICKET-4734
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.7
> Reporter: Pieter Vandepitte
> Assignee: Sven Meier
> Fix For: 6.1.0, 1.5.9
>
> Attachments: double-escaping.tar.gz, WICKET-4734.patch
>
>
> When the model property of a Button contains html entities (e.g. single quotes), these characters are double escaped: in Button.onComponentTag (getDefaultModelObjectAsString) and in ComponentTag.writeOutput
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4734) Button value is double escaped
Posted by "Pieter Vandepitte (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pieter Vandepitte updated WICKET-4734:
--------------------------------------
Attachment: double-escaping.tar.gz
run mvn jetty:run or mvn test
> Button value is double escaped
> ------------------------------
>
> Key: WICKET-4734
> URL: https://issues.apache.org/jira/browse/WICKET-4734
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.7
> Reporter: Pieter Vandepitte
> Attachments: double-escaping.tar.gz
>
>
> When the model property of a Button contains html entities (e.g. single quotes), these characters are double escaped: in Button.onComponentTag (getDefaultModelObjectAsString) and in ComponentTag.writeOutput
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4734) Button value is double escaped
Posted by "Pieter Vandepitte (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pieter Vandepitte updated WICKET-4734:
--------------------------------------
Comment: was deleted
(was: run mvn jetty:run or mvn test)
> Button value is double escaped
> ------------------------------
>
> Key: WICKET-4734
> URL: https://issues.apache.org/jira/browse/WICKET-4734
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.7
> Reporter: Pieter Vandepitte
> Attachments: double-escaping.tar.gz, double-escaping.tar.gz
>
>
> When the model property of a Button contains html entities (e.g. single quotes), these characters are double escaped: in Button.onComponentTag (getDefaultModelObjectAsString) and in ComponentTag.writeOutput
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4734) Button value is double escaped
Posted by "Pieter Vandepitte (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443102#comment-13443102 ]
Pieter Vandepitte commented on WICKET-4734:
-------------------------------------------
Current workaround: button.setEscapeModelStrings(false)
> Button value is double escaped
> ------------------------------
>
> Key: WICKET-4734
> URL: https://issues.apache.org/jira/browse/WICKET-4734
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.7
> Reporter: Pieter Vandepitte
> Attachments: double-escaping.tar.gz
>
>
> When the model property of a Button contains html entities (e.g. single quotes), these characters are double escaped: in Button.onComponentTag (getDefaultModelObjectAsString) and in ComponentTag.writeOutput
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira