You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@royale.apache.org by Maria Jose Esteve <mj...@iest.com> on 2020/07/01 00:06:28 UTC
RE: Image, does not flush when link value is null or blank
Hi,
I am going to "propose another option" to see how you see it ... I have it working in the project with Basic Image, Jewel Image and Jewel ImageButton (with Basic ImageButton the image is added as an element and we cannot access it through the same way)
, I will investigate when this is clear)
Why not use the same bead ErrorImage to detect the "" / null and be able to assign the alternate image if desired?
In my test:
- In the ErrorImageXX bead, I have created a boolean property emptyIsError to indicate if you want to include the null and the empty string.
- If emptyIsError = true, we configure a listener to "urlChanged" of ImageModel (This model is common to all 4 components), so when the "" / null is received, the alternative image is assigned.
... We do not cause any error events, nor do we need to modify any of the existing classes, etc, etc ...
In this way, there is no solution to option 3.1, from my previous email, but an extension could be easily created, locally, if needed.
as you see?
Hiedra.
-----Mensaje original-----
De: Carlos Rovira <ca...@apache.org>
Enviado el: lunes, 29 de junio de 2020 22:01
Para: Apache Royale Development <de...@royale.apache.org>
Asunto: Re: Image, does not flush when link value is null or blank
Hi,
thanks for the dissection :)
could be possible to handle errors with a throw-catch block to avoid browser errors and have control over it?
I think you have almost all right?
thanks
El dom., 28 jun. 2020 a las 19:18, Maria Jose Esteve (<mj...@iest.com>)
escribió:
> These are the test results:
>
> - Inject HTML
> The error event is dispatched in all three cases: "", null or "not found".
> The images displayed are as expected.
>
> - Jewel Image / Basic Image control, with the ErrorImage bead The
> error event is received only with "not found".
> The expected image is displayed if it does not exist but if it is ""
> or null, it does not update it and shows the last source displayed.
> (This is the case we are reviewing)
>
> In summary, we did not receive the error event, in the bead, because
> the source is not really being changed (in HTML the source is always
> assigned and therefore the error event always occurs), therefore the
> ErrorImage bead does not work for us .
>
> Viewing the test result confirms that if we don't want to change
> ImageViewBase.as, I think Carlos's second option (create a
> RemoveImageFromDisplay bead) would be the way to go.
>
> When an image is still, the scenarios are only two: The image exists
> and there are no problems, or the image is not found, the error occurs
> and the alternative image is loaded. This need is covered.
>
> When an image is dynamic and the developer does not control the value
> to be assigned, the scenarios are duplicated:
> 1.- Specific image, source is found (ok)
> 2.- Specific image, source is not found (with the bead ErrorImage, ok)
> 3.- No image, source "" / null:
> 3.1.- It may be necessary to "show an alternative image" (for
> example, an image indicating that a source must be added)
> In this case, we shouldn't remove the DOM element.
> 3.2.- or not show any.
> In this case, the DOM element could be removed.
>
> I will read your comments.
>
> Hiedra.
>
> -----Mensaje original-----
> De: Maria Jose Esteve <mj...@iest.com> Enviado el: domingo, 28 de
> junio de 2020 18:00
> Para: dev@royale.apache.org
> Asunto: RE: Image, does not flush when link value is null or blank
>
> Hello,
> When I tried it I also noticed the error but I did not understand it
> because the Image control had the ErrorImage bead.
>
> I am checking the operation with the old html injected because the
> onerror did jump with white or null.
> I tell you what I see.
>
> hiedra
>
> -----Mensaje original-----
> De: Carlos Rovira <ca...@apache.org> Enviado el: domingo, 28 de
> junio de 2020 10:41
> Para: Apache Royale Development <de...@royale.apache.org>
> Asunto: Re: Image, does not flush when link value is null or blank
>
> Hi,
>
> I'm checking it, and I found that setting src to null makes the
> browser throw an error: Failed to load resource:
> net::ERR_FILE_NOT_FOUND (also tried to set to '' but it didn't change
> anything)
>
> so that doesn't seem the solution Royale should do by default, since
> apps will be getting lots of errors in browsers console.
>
> Searching on the internet people use to remove the image from the DOM
> or remove from display, I think we can do that. What do others think about it?
>
> Also since we are adding ErrorImage.as bead, we can manage it there.
> So a normal image control only can load an image.
> If people want to set it to null or empty string and remove it add
> ErrorImage bead and display the alternative image.
> Also we could have another "RemoveImageFromDisplay" and
> "RemoveImageFromDOM" bead that instead of add alternative image will
> remove from DOM or display or DOM respectively.
>
> thoughts?
>
>
>
>
> El sáb., 27 jun. 2020 a las 18:10, Maria Jose Esteve
> (<mj...@iest.com>)
> escribió:
>
> > Do you get the attached screens? I don't see them ...
> > I'm sorry, I put it in text:
> >
> > De: Maria Jose Esteve <mj...@iest.com>>
> > Enviado el: sábado, 27 de junio de 2020 15:00
> > Para: dev@royale.apache.org<ma...@royale.apache.org>
> > Asunto: Image, does not flush when link value is null or blank
> >
> > Hi,
> > Setting up a detail form, where I have a jewel image component, I
> > have noticed that when a "" (empty string) or null is assigned to
> > the src property, the image is not emptied..
> > I have detected the origin of the problem and I present a possible
> > solution, to see how you see it.
> >
> > When the url / src is "" or null it does not enter through the if
> > (_model.url) and consequently it does not call applyImageDate and
> > the img is not updated:
> >
> > [ImageViewBase.as]
> >
> > protected function handleUrlChange(event:Event):void
> > {
> > COMPILE::SWF
> > {
> > if (_model.url) {
> > setupLoader();
> > loader.load(new URLRequest(_model.url));
> > }
> > }
> > COMPILE::JS
> > {
> > if (_model.url) {
> > setupLoader();
> > (host as IImage).applyImageData(_model.url);
> > }
> > }
> > }
> >
> >
> > [jewel.Image.as]
> >
> > /**
> > * @royaleignorecoercion HTMLImageElement
> > */
> > COMPILE::JS
> > override public function
> > applyImageData(binaryDataAsString:String):void
> > {
> > (element as HTMLImageElement).src = binaryDataAsString;
> > }
> > }
> >
> > If when the url is "" or null we directly call the applyImageData
> > function everything works perfectly (commented lines //)
> >
> > }else if(sw == 1){
> > //avatarTmp.applyImageData("");
> > lblStep.text = "Blanco";
> > avatarTmp.src = "";
> > }else if(sw == 2){
> > //avatarTmp.applyImageData(null);
> > lblStep.text = "Null";
> > avatarTmp.src = null;
> >
> >
> > If in ImageViewBase.as we changed the code:
> >
> > protected function handleUrlChange(event:Event):void
> > {
> > COMPILE::SWF
> > {
> > if (_model.url) {
> > setupLoader();
> > loader.load(new URLRequest(_model.url));
> > }
> > }
> > COMPILE::JS
> > {
> > if (_model.url) {
> > setupLoader();
> > (host as IImage).applyImageData(_model.url);
> > }
> > }
> > }
> >
> > For this other, It would be correct?
> >
> > COMPILE::JS
> > {
> > if (_model.url)
> > setupLoader();
> > (host as IImage).applyImageData(_model.url);
> >
> > }
> >
> > I haven't tested it for SWC but I think it might be feasible too.
> > (In my Flex application it works when I assign a null if it empties
> > the
> > image) As you see?
> >
> > Hiedra.
> >
>
>
> --
> Carlos Rovira
> http://about.me/carlosrovira
>
--
Carlos Rovira
http://about.me/carlosrovira
Re: Image, does not flush when link value is null or blank
Posted by Carlos Rovira <ca...@apache.org>.
Hi Maria Jose,
ok, perfect
Thanks! :)
El jue., 2 jul. 2020 a las 18:10, Maria Jose Esteve (<mj...@iest.com>)
escribió:
> They are practically the same, they differ only in the type of
> imageElement, and the set strand function to which an "if" is added.
>
> If it's okay with you, so as not to make you dizzy anymore, that "some"
> emails are already going, I leave it separated into two and, if over time,
> you see that everything is better together, I do a PR with only one.
> You think?
>
> Thx.
> Hiedra
>
> -----Mensaje original-----
> De: Carlos Rovira <ca...@apache.org>
> Enviado el: jueves, 2 de julio de 2020 16:26
> Para: Apache Royale Development <de...@royale.apache.org>
> Asunto: Re: Image, does not flush when link value is null or blank
>
> Hi Maria Jose,
> 1 bead is better than 2, if we don't have significant code in that bead
> that is unnecessary for 1 of the cases.
> If that is the case, perfect. If not I prefer 2 separate beads, so people
> using just Image don't have to pay for code that will never use (and
> viceversa for people using ImageButton but not Image) thanks
>
> El jue., 2 jul. 2020 a las 14:27, Maria Jose Esteve (<mj...@iest.com>)
> escribió:
>
> > Hi Carlos,
> > I am making the corrections that Yishay makes for me in both PRs (880
> > and
> > 881)
> >
> > For now, they are different beads: the 880 is for Image and the 881
> > for ImageButton.
> > I'm going to create the interface that you tell me about and commit to
> 881.
> >
> > In any case, we could have a single bead applicable to Image and
> > ImageButton at the same time, as I mentioned in previous emails.
> >
> > If you like the idea I can upload the PR of this generic bead and we
> > will remove the PR 880 and 881.
> > Tell me how you see it best.
> >
> > Thank you.
> > A greeting.
> >
> > Hiedra.
> >
> > -----Mensaje original-----
> > De: Carlos Rovira <ca...@apache.org> Enviado el: jueves, 2 de
> > julio de 2020 11:11
> > Para: Apache Royale Development <de...@royale.apache.org>
> > Asunto: Re: Image, does not flush when link value is null or blank
> >
> > Hi Maria Jose,
> >
> > so we can remove PR #880? we stick with #881? did you take into
> > account comments from Yishay in #881? if not please do it so we can
> > review over the final state.
> > About interfaces, if ther's none, you can add one to Core that covers
> > that need and add to that controls (if I understand right) thanks!
> >
> >
> > El jue., 2 jul. 2020 a las 10:35, Maria Jose Esteve
> > (<mj...@iest.com>)
> > escribió:
> >
> > > Hi,
> > > yesterday I made a PR of the ErrorImage bead for controls that
> > > implement IImage.
> > > I just made another PR for the controls that contain an image but
> > > it's not its main element, like the ImageButton.
> > > The Basic / Jewel ImageButton controls do not share any standard
> > > interface for the image, but the Basic ImageButton contains the
> > > _imageElement property to save it.
> > > What I propose is to make this public prority and add it to Jewel
> > > ImageButton.
> > > Maybe there is some common interface or some way to refer to the img
> > > wrapper ...
> > >
> > > I will read your comments in the PR.
> > >
> > > On the other hand, I have a PR prepared with a common ErrorImage
> > > bead for IImage controls and ImageButtons ... how do you see it? (It
> > > is a mixture of the two previous PR)
> > >
> > > Thank you.
> > > Hiedra
> > >
> > > -----Mensaje original-----
> > > De: Maria Jose Esteve
> > > Enviado el: miércoles, 1 de julio de 2020 20:06
> > > Para: dev@royale.apache.org
> > > Asunto: RE: Image, does not flush when link value is null or blank
> > >
> > > Hi Carlos,
> > > I did not fully understand you.
> > > I'm going to mount the PR along this line, but first I want to see
> > > if I can spend a little more time on the ErrorImage bead and make it
> > > compatible with controls that have an 'img' element.
> > >
> > > Thanks.
> > > Hiedra.
> > >
> > > -----Mensaje original-----
> > > De: Carlos Rovira <ca...@apache.org> Enviado el: miércoles, 1
> > > de julio de 2020 10:32
> > > Para: Apache Royale Development <de...@royale.apache.org>
> > > Asunto: Re: Image, does not flush when link value is null or blank
> > >
> > > Hi Maria Jose,
> > >
> > > El mié., 1 jul. 2020 a las 2:06, Maria Jose Esteve
> > > (<mj...@iest.com>)
> > > escribió:
> > >
> > > > Why not use the same bead ErrorImage to detect the "" / null and
> > > > be able to assign the alternate image if desired?
> > > >
> > > >
> > > yeah! That was what I wanted to say in previous emails. So +1 After
> > > your PR is merged I can check it and see if I can add some default
> > > image in the jewel case, but that's something for later :)
> > >
> > >
> > >
> > > > --
> > > > Carlos Rovira
> > > > http://about.me/carlosrovira
> > > >
> > > >
> > > >
> > > >
> > >
> >
> >
> > --
> > Carlos Rovira
> > http://about.me/carlosrovira
> >
>
>
> --
> Carlos Rovira
> http://about.me/carlosrovira
>
--
Carlos Rovira
http://about.me/carlosrovira
RE: Image, does not flush when link value is null or blank
Posted by Maria Jose Esteve <mj...@iest.com>.
They are practically the same, they differ only in the type of imageElement, and the set strand function to which an "if" is added.
If it's okay with you, so as not to make you dizzy anymore, that "some" emails are already going, I leave it separated into two and, if over time, you see that everything is better together, I do a PR with only one.
You think?
Thx.
Hiedra
-----Mensaje original-----
De: Carlos Rovira <ca...@apache.org>
Enviado el: jueves, 2 de julio de 2020 16:26
Para: Apache Royale Development <de...@royale.apache.org>
Asunto: Re: Image, does not flush when link value is null or blank
Hi Maria Jose,
1 bead is better than 2, if we don't have significant code in that bead that is unnecessary for 1 of the cases.
If that is the case, perfect. If not I prefer 2 separate beads, so people using just Image don't have to pay for code that will never use (and viceversa for people using ImageButton but not Image) thanks
El jue., 2 jul. 2020 a las 14:27, Maria Jose Esteve (<mj...@iest.com>)
escribió:
> Hi Carlos,
> I am making the corrections that Yishay makes for me in both PRs (880
> and
> 881)
>
> For now, they are different beads: the 880 is for Image and the 881
> for ImageButton.
> I'm going to create the interface that you tell me about and commit to 881.
>
> In any case, we could have a single bead applicable to Image and
> ImageButton at the same time, as I mentioned in previous emails.
>
> If you like the idea I can upload the PR of this generic bead and we
> will remove the PR 880 and 881.
> Tell me how you see it best.
>
> Thank you.
> A greeting.
>
> Hiedra.
>
> -----Mensaje original-----
> De: Carlos Rovira <ca...@apache.org> Enviado el: jueves, 2 de
> julio de 2020 11:11
> Para: Apache Royale Development <de...@royale.apache.org>
> Asunto: Re: Image, does not flush when link value is null or blank
>
> Hi Maria Jose,
>
> so we can remove PR #880? we stick with #881? did you take into
> account comments from Yishay in #881? if not please do it so we can
> review over the final state.
> About interfaces, if ther's none, you can add one to Core that covers
> that need and add to that controls (if I understand right) thanks!
>
>
> El jue., 2 jul. 2020 a las 10:35, Maria Jose Esteve
> (<mj...@iest.com>)
> escribió:
>
> > Hi,
> > yesterday I made a PR of the ErrorImage bead for controls that
> > implement IImage.
> > I just made another PR for the controls that contain an image but
> > it's not its main element, like the ImageButton.
> > The Basic / Jewel ImageButton controls do not share any standard
> > interface for the image, but the Basic ImageButton contains the
> > _imageElement property to save it.
> > What I propose is to make this public prority and add it to Jewel
> > ImageButton.
> > Maybe there is some common interface or some way to refer to the img
> > wrapper ...
> >
> > I will read your comments in the PR.
> >
> > On the other hand, I have a PR prepared with a common ErrorImage
> > bead for IImage controls and ImageButtons ... how do you see it? (It
> > is a mixture of the two previous PR)
> >
> > Thank you.
> > Hiedra
> >
> > -----Mensaje original-----
> > De: Maria Jose Esteve
> > Enviado el: miércoles, 1 de julio de 2020 20:06
> > Para: dev@royale.apache.org
> > Asunto: RE: Image, does not flush when link value is null or blank
> >
> > Hi Carlos,
> > I did not fully understand you.
> > I'm going to mount the PR along this line, but first I want to see
> > if I can spend a little more time on the ErrorImage bead and make it
> > compatible with controls that have an 'img' element.
> >
> > Thanks.
> > Hiedra.
> >
> > -----Mensaje original-----
> > De: Carlos Rovira <ca...@apache.org> Enviado el: miércoles, 1
> > de julio de 2020 10:32
> > Para: Apache Royale Development <de...@royale.apache.org>
> > Asunto: Re: Image, does not flush when link value is null or blank
> >
> > Hi Maria Jose,
> >
> > El mié., 1 jul. 2020 a las 2:06, Maria Jose Esteve
> > (<mj...@iest.com>)
> > escribió:
> >
> > > Why not use the same bead ErrorImage to detect the "" / null and
> > > be able to assign the alternate image if desired?
> > >
> > >
> > yeah! That was what I wanted to say in previous emails. So +1 After
> > your PR is merged I can check it and see if I can add some default
> > image in the jewel case, but that's something for later :)
> >
> >
> >
> > > --
> > > Carlos Rovira
> > > http://about.me/carlosrovira
> > >
> > >
> > >
> > >
> >
>
>
> --
> Carlos Rovira
> http://about.me/carlosrovira
>
--
Carlos Rovira
http://about.me/carlosrovira
Re: Image, does not flush when link value is null or blank
Posted by Carlos Rovira <ca...@apache.org>.
Hi Maria Jose,
1 bead is better than 2, if we don't have significant code in that bead
that is unnecessary for 1 of the cases.
If that is the case, perfect. If not I prefer 2 separate beads, so people
using just Image don't have to pay for code that will never use (and
viceversa for people using ImageButton but not Image)
thanks
El jue., 2 jul. 2020 a las 14:27, Maria Jose Esteve (<mj...@iest.com>)
escribió:
> Hi Carlos,
> I am making the corrections that Yishay makes for me in both PRs (880 and
> 881)
>
> For now, they are different beads: the 880 is for Image and the 881 for
> ImageButton.
> I'm going to create the interface that you tell me about and commit to 881.
>
> In any case, we could have a single bead applicable to Image and
> ImageButton at the same time, as I mentioned in previous emails.
>
> If you like the idea I can upload the PR of this generic bead and we will
> remove the PR 880 and 881.
> Tell me how you see it best.
>
> Thank you.
> A greeting.
>
> Hiedra.
>
> -----Mensaje original-----
> De: Carlos Rovira <ca...@apache.org>
> Enviado el: jueves, 2 de julio de 2020 11:11
> Para: Apache Royale Development <de...@royale.apache.org>
> Asunto: Re: Image, does not flush when link value is null or blank
>
> Hi Maria Jose,
>
> so we can remove PR #880? we stick with #881? did you take into account
> comments from Yishay in #881? if not please do it so we can review over the
> final state.
> About interfaces, if ther's none, you can add one to Core that covers that
> need and add to that controls (if I understand right) thanks!
>
>
> El jue., 2 jul. 2020 a las 10:35, Maria Jose Esteve (<mj...@iest.com>)
> escribió:
>
> > Hi,
> > yesterday I made a PR of the ErrorImage bead for controls that
> > implement IImage.
> > I just made another PR for the controls that contain an image but it's
> > not its main element, like the ImageButton.
> > The Basic / Jewel ImageButton controls do not share any standard
> > interface for the image, but the Basic ImageButton contains the
> > _imageElement property to save it.
> > What I propose is to make this public prority and add it to Jewel
> > ImageButton.
> > Maybe there is some common interface or some way to refer to the img
> > wrapper ...
> >
> > I will read your comments in the PR.
> >
> > On the other hand, I have a PR prepared with a common ErrorImage bead
> > for IImage controls and ImageButtons ... how do you see it? (It is a
> > mixture of the two previous PR)
> >
> > Thank you.
> > Hiedra
> >
> > -----Mensaje original-----
> > De: Maria Jose Esteve
> > Enviado el: miércoles, 1 de julio de 2020 20:06
> > Para: dev@royale.apache.org
> > Asunto: RE: Image, does not flush when link value is null or blank
> >
> > Hi Carlos,
> > I did not fully understand you.
> > I'm going to mount the PR along this line, but first I want to see if
> > I can spend a little more time on the ErrorImage bead and make it
> > compatible with controls that have an 'img' element.
> >
> > Thanks.
> > Hiedra.
> >
> > -----Mensaje original-----
> > De: Carlos Rovira <ca...@apache.org> Enviado el: miércoles, 1
> > de julio de 2020 10:32
> > Para: Apache Royale Development <de...@royale.apache.org>
> > Asunto: Re: Image, does not flush when link value is null or blank
> >
> > Hi Maria Jose,
> >
> > El mié., 1 jul. 2020 a las 2:06, Maria Jose Esteve
> > (<mj...@iest.com>)
> > escribió:
> >
> > > Why not use the same bead ErrorImage to detect the "" / null and be
> > > able to assign the alternate image if desired?
> > >
> > >
> > yeah! That was what I wanted to say in previous emails. So +1 After
> > your PR is merged I can check it and see if I can add some default
> > image in the jewel case, but that's something for later :)
> >
> >
> >
> > > --
> > > Carlos Rovira
> > > http://about.me/carlosrovira
> > >
> > >
> > >
> > >
> >
>
>
> --
> Carlos Rovira
> http://about.me/carlosrovira
>
--
Carlos Rovira
http://about.me/carlosrovira
RE: Image, does not flush when link value is null or blank
Posted by Maria Jose Esteve <mj...@iest.com>.
Hi Carlos,
I am making the corrections that Yishay makes for me in both PRs (880 and 881)
For now, they are different beads: the 880 is for Image and the 881 for ImageButton.
I'm going to create the interface that you tell me about and commit to 881.
In any case, we could have a single bead applicable to Image and ImageButton at the same time, as I mentioned in previous emails.
If you like the idea I can upload the PR of this generic bead and we will remove the PR 880 and 881.
Tell me how you see it best.
Thank you.
A greeting.
Hiedra.
-----Mensaje original-----
De: Carlos Rovira <ca...@apache.org>
Enviado el: jueves, 2 de julio de 2020 11:11
Para: Apache Royale Development <de...@royale.apache.org>
Asunto: Re: Image, does not flush when link value is null or blank
Hi Maria Jose,
so we can remove PR #880? we stick with #881? did you take into account comments from Yishay in #881? if not please do it so we can review over the final state.
About interfaces, if ther's none, you can add one to Core that covers that need and add to that controls (if I understand right) thanks!
El jue., 2 jul. 2020 a las 10:35, Maria Jose Esteve (<mj...@iest.com>)
escribió:
> Hi,
> yesterday I made a PR of the ErrorImage bead for controls that
> implement IImage.
> I just made another PR for the controls that contain an image but it's
> not its main element, like the ImageButton.
> The Basic / Jewel ImageButton controls do not share any standard
> interface for the image, but the Basic ImageButton contains the
> _imageElement property to save it.
> What I propose is to make this public prority and add it to Jewel
> ImageButton.
> Maybe there is some common interface or some way to refer to the img
> wrapper ...
>
> I will read your comments in the PR.
>
> On the other hand, I have a PR prepared with a common ErrorImage bead
> for IImage controls and ImageButtons ... how do you see it? (It is a
> mixture of the two previous PR)
>
> Thank you.
> Hiedra
>
> -----Mensaje original-----
> De: Maria Jose Esteve
> Enviado el: miércoles, 1 de julio de 2020 20:06
> Para: dev@royale.apache.org
> Asunto: RE: Image, does not flush when link value is null or blank
>
> Hi Carlos,
> I did not fully understand you.
> I'm going to mount the PR along this line, but first I want to see if
> I can spend a little more time on the ErrorImage bead and make it
> compatible with controls that have an 'img' element.
>
> Thanks.
> Hiedra.
>
> -----Mensaje original-----
> De: Carlos Rovira <ca...@apache.org> Enviado el: miércoles, 1
> de julio de 2020 10:32
> Para: Apache Royale Development <de...@royale.apache.org>
> Asunto: Re: Image, does not flush when link value is null or blank
>
> Hi Maria Jose,
>
> El mié., 1 jul. 2020 a las 2:06, Maria Jose Esteve
> (<mj...@iest.com>)
> escribió:
>
> > Why not use the same bead ErrorImage to detect the "" / null and be
> > able to assign the alternate image if desired?
> >
> >
> yeah! That was what I wanted to say in previous emails. So +1 After
> your PR is merged I can check it and see if I can add some default
> image in the jewel case, but that's something for later :)
>
>
>
> > --
> > Carlos Rovira
> > http://about.me/carlosrovira
> >
> >
> >
> >
>
--
Carlos Rovira
http://about.me/carlosrovira
Re: Image, does not flush when link value is null or blank
Posted by Carlos Rovira <ca...@apache.org>.
Hi Maria Jose,
so we can remove PR #880? we stick with #881? did you take into account
comments from Yishay in #881? if not please do it so we can review over the
final state.
About interfaces, if ther's none, you can add one to Core that covers that
need and add to that controls (if I understand right)
thanks!
El jue., 2 jul. 2020 a las 10:35, Maria Jose Esteve (<mj...@iest.com>)
escribió:
> Hi,
> yesterday I made a PR of the ErrorImage bead for controls that implement
> IImage.
> I just made another PR for the controls that contain an image but it's not
> its main element, like the ImageButton.
> The Basic / Jewel ImageButton controls do not share any standard interface
> for the image, but the Basic ImageButton contains the _imageElement
> property to save it.
> What I propose is to make this public prority and add it to Jewel
> ImageButton.
> Maybe there is some common interface or some way to refer to the img
> wrapper ...
>
> I will read your comments in the PR.
>
> On the other hand, I have a PR prepared with a common ErrorImage bead for
> IImage controls and ImageButtons ... how do you see it? (It is a mixture of
> the two previous PR)
>
> Thank you.
> Hiedra
>
> -----Mensaje original-----
> De: Maria Jose Esteve
> Enviado el: miércoles, 1 de julio de 2020 20:06
> Para: dev@royale.apache.org
> Asunto: RE: Image, does not flush when link value is null or blank
>
> Hi Carlos,
> I did not fully understand you.
> I'm going to mount the PR along this line, but first I want to see if I
> can spend a little more time on the ErrorImage bead and make it compatible
> with controls that have an 'img' element.
>
> Thanks.
> Hiedra.
>
> -----Mensaje original-----
> De: Carlos Rovira <ca...@apache.org> Enviado el: miércoles, 1 de
> julio de 2020 10:32
> Para: Apache Royale Development <de...@royale.apache.org>
> Asunto: Re: Image, does not flush when link value is null or blank
>
> Hi Maria Jose,
>
> El mié., 1 jul. 2020 a las 2:06, Maria Jose Esteve (<mj...@iest.com>)
> escribió:
>
> > Why not use the same bead ErrorImage to detect the "" / null and be
> > able to assign the alternate image if desired?
> >
> >
> yeah! That was what I wanted to say in previous emails. So +1 After your
> PR is merged I can check it and see if I can add some default image in the
> jewel case, but that's something for later :)
>
>
>
> > --
> > Carlos Rovira
> > http://about.me/carlosrovira
> >
> >
> >
> >
>
--
Carlos Rovira
http://about.me/carlosrovira
RE: Image, does not flush when link value is null or blank
Posted by Maria Jose Esteve <mj...@iest.com>.
Hi,
yesterday I made a PR of the ErrorImage bead for controls that implement IImage.
I just made another PR for the controls that contain an image but it's not its main element, like the ImageButton.
The Basic / Jewel ImageButton controls do not share any standard interface for the image, but the Basic ImageButton contains the _imageElement property to save it.
What I propose is to make this public prority and add it to Jewel ImageButton.
Maybe there is some common interface or some way to refer to the img wrapper ...
I will read your comments in the PR.
On the other hand, I have a PR prepared with a common ErrorImage bead for IImage controls and ImageButtons ... how do you see it? (It is a mixture of the two previous PR)
Thank you.
Hiedra
-----Mensaje original-----
De: Maria Jose Esteve
Enviado el: miércoles, 1 de julio de 2020 20:06
Para: dev@royale.apache.org
Asunto: RE: Image, does not flush when link value is null or blank
Hi Carlos,
I did not fully understand you.
I'm going to mount the PR along this line, but first I want to see if I can spend a little more time on the ErrorImage bead and make it compatible with controls that have an 'img' element.
Thanks.
Hiedra.
-----Mensaje original-----
De: Carlos Rovira <ca...@apache.org> Enviado el: miércoles, 1 de julio de 2020 10:32
Para: Apache Royale Development <de...@royale.apache.org>
Asunto: Re: Image, does not flush when link value is null or blank
Hi Maria Jose,
El mié., 1 jul. 2020 a las 2:06, Maria Jose Esteve (<mj...@iest.com>)
escribió:
> Why not use the same bead ErrorImage to detect the "" / null and be
> able to assign the alternate image if desired?
>
>
yeah! That was what I wanted to say in previous emails. So +1 After your PR is merged I can check it and see if I can add some default image in the jewel case, but that's something for later :)
> --
> Carlos Rovira
> http://about.me/carlosrovira
>
>
>
>
RE: Image, does not flush when link value is null or blank
Posted by Maria Jose Esteve <mj...@iest.com>.
Hi Carlos,
I did not fully understand you.
I'm going to mount the PR along this line, but first I want to see if I can spend a little more time on the ErrorImage bead and make it compatible with controls that have an 'img' element.
Thanks.
Hiedra.
-----Mensaje original-----
De: Carlos Rovira <ca...@apache.org>
Enviado el: miércoles, 1 de julio de 2020 10:32
Para: Apache Royale Development <de...@royale.apache.org>
Asunto: Re: Image, does not flush when link value is null or blank
Hi Maria Jose,
El mié., 1 jul. 2020 a las 2:06, Maria Jose Esteve (<mj...@iest.com>)
escribió:
> Why not use the same bead ErrorImage to detect the "" / null and be
> able to assign the alternate image if desired?
>
>
yeah! That was what I wanted to say in previous emails. So +1 After your PR is merged I can check it and see if I can add some default image in the jewel case, but that's something for later :)
> --
> Carlos Rovira
> http://about.me/carlosrovira
>
>
>
>
Re: Image, does not flush when link value is null or blank
Posted by Carlos Rovira <ca...@apache.org>.
Hi Maria Jose,
El mié., 1 jul. 2020 a las 2:06, Maria Jose Esteve (<mj...@iest.com>)
escribió:
> Why not use the same bead ErrorImage to detect the "" / null and be able
> to assign the alternate image if desired?
>
>
yeah! That was what I wanted to say in previous emails. So +1
After your PR is merged I can check it and see if I can add some default
image in the jewel case, but that's something for later :)
> --
> Carlos Rovira
> http://about.me/carlosrovira
>
>
>
>