You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/22 08:48:04 UTC

[GitHub] [flink] abhijitShandilya opened a new pull request #12735: [FLINK-18283][API/Core,API/DataStream] Update outdated Javadoc for clear method of ProcessWindowFunction

abhijitShandilya opened a new pull request #12735:
URL: https://github.com/apache/flink/pull/12735


   [FLINK-18283] [JavDocs] [API/Core,API/DataStream]
   Update outdated Javadoc for *clear* method of ProcessWindowFunction
   
   ## What is the purpose of the change
   
   - We want to edit the javadocs for ProcessWindowFunction's *clear* method so that it reflects the actual behavior.
   - Please see [FLINK-18283](https://issues.apache.org/jira/browse/FLINK-18283) for detailed description of the issue.
   
   ## Brief change log
     - Change the javadoc for ProcessWindowFunction's *clear* method from
          > Deletes any state in the Context when the Window is purged
   
          to
          > Deletes any state in the Context when the Window expires (the watermark passes its maxTimestamp + allowedLateness).
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   - Manually verified in my IDE that the correct javadocs show up for [Java](https://user-images.githubusercontent.com/6713854/85186132-1b176c80-b24c-11ea-87d3-185fad39351d.png) and [Scala](https://user-images.githubusercontent.com/6713854/85186131-181c7c00-b24c-11ea-8861-d6d636722aaf.png).
   - Ran the pipeline on Azure and all the builds passed (including e2e_ci_build)
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12735: [FLINK-18283][API/Core,API/DataStream] Update outdated Javadoc for clear method of ProcessWindowFunction

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12735:
URL: https://github.com/apache/flink/pull/12735#issuecomment-647385780


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6fbdd18d0c5731ed8e1f1a1fb3ffbd99a435388d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3897",
       "triggerID" : "6fbdd18d0c5731ed8e1f1a1fb3ffbd99a435388d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6fbdd18d0c5731ed8e1f1a1fb3ffbd99a435388d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3897) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12735: [FLINK-18283][API/Core,API/DataStream] Update outdated Javadoc for clear method of ProcessWindowFunction

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12735:
URL: https://github.com/apache/flink/pull/12735#issuecomment-647379476


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 6fbdd18d0c5731ed8e1f1a1fb3ffbd99a435388d (Mon Jun 22 08:50:45 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-18283).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] aljoscha commented on pull request #12735: [FLINK-18283][API/Core,API/DataStream] Update outdated Javadoc for clear method of ProcessWindowFunction

Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12735:
URL: https://github.com/apache/flink/pull/12735#issuecomment-648159991


   Thanks a lot! I merged this. 👍 It's important to also take time and fix the little things. Some future user would have stumbled on this again.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12735: [FLINK-18283][API/Core,API/DataStream] Update outdated Javadoc for clear method of ProcessWindowFunction

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12735:
URL: https://github.com/apache/flink/pull/12735#issuecomment-647385780


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6fbdd18d0c5731ed8e1f1a1fb3ffbd99a435388d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3897",
       "triggerID" : "6fbdd18d0c5731ed8e1f1a1fb3ffbd99a435388d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6fbdd18d0c5731ed8e1f1a1fb3ffbd99a435388d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3897) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] abhijitShandilya closed pull request #12735: [FLINK-18283][API/Core,API/DataStream] Update outdated Javadoc for clear method of ProcessWindowFunction

Posted by GitBox <gi...@apache.org>.
abhijitShandilya closed pull request #12735:
URL: https://github.com/apache/flink/pull/12735


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12735: [FLINK-18283][API/Core,API/DataStream] Update outdated Javadoc for clear method of ProcessWindowFunction

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12735:
URL: https://github.com/apache/flink/pull/12735#issuecomment-647385780


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6fbdd18d0c5731ed8e1f1a1fb3ffbd99a435388d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6fbdd18d0c5731ed8e1f1a1fb3ffbd99a435388d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6fbdd18d0c5731ed8e1f1a1fb3ffbd99a435388d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org