You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/23 18:49:38 UTC

[GitHub] [beam] kennknowles commented on a change in pull request #14028: [BEAM-11227] Preparing vendored gRPC upgrade from 1.26 to 1.35

kennknowles commented on a change in pull request #14028:
URL: https://github.com/apache/beam/pull/14028#discussion_r581300742



##########
File path: vendor/README.md
##########
@@ -33,6 +33,17 @@ is useful for the vendored dependency upgrades. It reports the linkage errors ac
 
 For example, when we upgrade the version of gRPC to 1.26.0 and the version of the vendored gRPC is 0.1-SNAPSHOT,
 we could run the linkage tool as following:
+
 ```
-./gradlew -PvendoredDependenciesOnly -Ppublishing -PjavaLinkageArtifactIds=beam-vendor-grpc-1_26_0:0.1-SNAPSHOT :checkJavaLinkage
+$ cd vendor/grpc-1_26_0
+$ ../../gradlew shadowJar
+$ find . -name '*.jar'
+./build/libs/beam-vendor-grpc-1_26_0-0.1.jar
+$ mvn install:install-file \

Review comment:
       Isn't the idea of the command to test the vendored artifact built from the unsubmitted and unpublished code?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org