You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/12/03 12:23:18 UTC
Review Request 40906: Replaced `BadRequest` with `MethodNotAllowed`
for all HTTP requests with unsupported methods.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40906/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar, Isabel Jimenez, and Joris Van Remoortere.
Bugs: MESOS-4056
https://issues.apache.org/jira/browse/MESOS-4056
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/master/http.cpp 9097eda47558fb5306af5a61b464937d7ab34e83
Diff: https://reviews.apache.org/r/40906/diff/
Testing
-------
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
Re: Review Request 40906: Replaced `BadRequest` with
`MethodNotAllowed` for all HTTP requests with unsupported methods.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Dec. 3, 2015, 12:22 p.m., Guangya Liu wrote:
> > src/master/http.cpp, line 555
> > <https://reviews.apache.org/r/40906/diff/1/?file=1152918#file1152918line555>
> >
> > I see that others using "Expecting a 'POST' request", this may be more clear
> >
> > Also, is it a MUST to set {"POST"} as first parameter?
> >
> > Ditto as following.
>
> Guangya Liu wrote:
> I should check 40905 first. I saw that you have updated the "MethodNotAllowed" there. Still want to know if we can update the message to "Expectint a 'POST' request, received a 'DELETE' reuqest"?
Replied in r/40905/.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40906/#review108811
-----------------------------------------------------------
On Dec. 3, 2015, 11:23 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40906/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2015, 11:23 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Isabel Jimenez, and Joris Van Remoortere.
>
>
> Bugs: MESOS-4056
> https://issues.apache.org/jira/browse/MESOS-4056
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp 9097eda47558fb5306af5a61b464937d7ab34e83
>
> Diff: https://reviews.apache.org/r/40906/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40906: Replaced `BadRequest` with
`MethodNotAllowed` for all HTTP requests with unsupported methods.
Posted by Guangya Liu <gy...@gmail.com>.
> On 十二月 3, 2015, 12:22 p.m., Guangya Liu wrote:
> > src/master/http.cpp, line 555
> > <https://reviews.apache.org/r/40906/diff/1/?file=1152918#file1152918line555>
> >
> > I see that others using "Expecting a 'POST' request", this may be more clear
> >
> > Also, is it a MUST to set {"POST"} as first parameter?
> >
> > Ditto as following.
I should check 40905 first. I saw that you have updated the "MethodNotAllowed" there. Still want to know if we can update the message to "Expectint a 'POST' request, received a 'DELETE' reuqest"?
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40906/#review108811
-----------------------------------------------------------
On 十二月 3, 2015, 11:23 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40906/
> -----------------------------------------------------------
>
> (Updated 十二月 3, 2015, 11:23 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Isabel Jimenez, and Joris Van Remoortere.
>
>
> Bugs: MESOS-4056
> https://issues.apache.org/jira/browse/MESOS-4056
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp 9097eda47558fb5306af5a61b464937d7ab34e83
>
> Diff: https://reviews.apache.org/r/40906/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40906: Replaced `BadRequest` with
`MethodNotAllowed` for all HTTP requests with unsupported methods.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40906/#review108811
-----------------------------------------------------------
src/master/http.cpp (line 555)
<https://reviews.apache.org/r/40906/#comment168286>
I see that others using "Expecting a 'POST' request", this may be more clear
Also, is it a MUST to set {"POST"} as first parameter?
Ditto as following.
- Guangya Liu
On 十二月 3, 2015, 11:23 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40906/
> -----------------------------------------------------------
>
> (Updated 十二月 3, 2015, 11:23 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Isabel Jimenez, and Joris Van Remoortere.
>
>
> Bugs: MESOS-4056
> https://issues.apache.org/jira/browse/MESOS-4056
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp 9097eda47558fb5306af5a61b464937d7ab34e83
>
> Diff: https://reviews.apache.org/r/40906/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40906: Replaced `BadRequest` with
`MethodNotAllowed` for all HTTP requests with unsupported methods.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40906/#review109693
-----------------------------------------------------------
Ship it!
Ship It!
- Anand Mazumdar
On Dec. 10, 2015, 12:13 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40906/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 12:13 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Isabel Jimenez, and Joris Van Remoortere.
>
>
> Bugs: MESOS-4056
> https://issues.apache.org/jira/browse/MESOS-4056
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp 9097eda47558fb5306af5a61b464937d7ab34e83
>
> Diff: https://reviews.apache.org/r/40906/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40906: Replaced `BadRequest` with
`MethodNotAllowed` for all HTTP requests with unsupported methods.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40906/#review109777
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Dec. 10, 2015, 12:13 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40906/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 12:13 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Isabel Jimenez, and Joris Van Remoortere.
>
>
> Bugs: MESOS-4056
> https://issues.apache.org/jira/browse/MESOS-4056
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp 9097eda47558fb5306af5a61b464937d7ab34e83
>
> Diff: https://reviews.apache.org/r/40906/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40906: Replaced `BadRequest` with
`MethodNotAllowed` for all HTTP requests with unsupported methods.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40906/#review109757
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40905, 40913, 40906]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 10, 2015, 12:13 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40906/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 12:13 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Isabel Jimenez, and Joris Van Remoortere.
>
>
> Bugs: MESOS-4056
> https://issues.apache.org/jira/browse/MESOS-4056
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp 9097eda47558fb5306af5a61b464937d7ab34e83
>
> Diff: https://reviews.apache.org/r/40906/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40906: Replaced `BadRequest` with
`MethodNotAllowed` for all HTTP requests with unsupported methods.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40906/
-----------------------------------------------------------
(Updated Dec. 10, 2015, 12:13 a.m.)
Review request for mesos, Anand Mazumdar, Isabel Jimenez, and Joris Van Remoortere.
Changes
-------
Rebased.
Bugs: MESOS-4056
https://issues.apache.org/jira/browse/MESOS-4056
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/master/http.cpp 9097eda47558fb5306af5a61b464937d7ab34e83
Diff: https://reviews.apache.org/r/40906/diff/
Testing
-------
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
Re: Review Request 40906: Replaced `BadRequest` with
`MethodNotAllowed` for all HTTP requests with unsupported methods.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40906/
-----------------------------------------------------------
(Updated Dec. 3, 2015, 2:35 p.m.)
Review request for mesos, Anand Mazumdar, Isabel Jimenez, and Joris Van Remoortere.
Changes
-------
Rebased.
Bugs: MESOS-4056
https://issues.apache.org/jira/browse/MESOS-4056
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/master/http.cpp 9097eda47558fb5306af5a61b464937d7ab34e83
Diff: https://reviews.apache.org/r/40906/diff/
Testing
-------
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
Re: Review Request 40906: Replaced `BadRequest` with
`MethodNotAllowed` for all HTTP requests with unsupported methods.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40906/#review108826
-----------------------------------------------------------
Bad patch!
Reviews applied: [40905]
Failed command: ./support/apply-review.sh -n -r 40905
Error:
2015-12-03 13:57:45 URL:https://reviews.apache.org/r/40905/diff/raw/ [3346/3346] -> "40905.patch" [1]
Successfully applied: Made `MethodNotAllowed` response compliant to RFC 2616.
According to RFC 2616 (http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.7), `MethodNotAllowed` response must include an 'Allow' header containing a list of valid methods.
Review: https://reviews.apache.org/r/40905
Checking 5 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
Total errors found: 0
ERROR: Commit spanning multiple projects.
Please use separate commits for mesos, libprocess and stout.
Paths grouped by project:
mesos:
src/master/http.cpp
src/slave/http.cpp
src/tests/executor_http_api_tests.cpp
src/tests/scheduler_http_api_tests.cpp
libprocess:
3rdparty/libprocess/include/process/http.hpp
Failed to commit patch
- Mesos ReviewBot
On Dec. 3, 2015, 11:23 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40906/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2015, 11:23 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Isabel Jimenez, and Joris Van Remoortere.
>
>
> Bugs: MESOS-4056
> https://issues.apache.org/jira/browse/MESOS-4056
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp 9097eda47558fb5306af5a61b464937d7ab34e83
>
> Diff: https://reviews.apache.org/r/40906/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>