You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/05/18 04:15:31 UTC
[GitHub] [fineract] nnatarajan opened a new pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3…
nnatarajan opened a new pull request #907:
URL: https://github.com/apache/fineract/pull/907
….0.18
## Description
Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3.0.18
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-631081722
> Maybe try to exclude groovy-all in dependencies.gradle.
@xurror in this particular case, the problem was different - #911 should hopefully fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] nnatarajan commented on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3…
Posted by GitBox <gi...@apache.org>.
nnatarajan commented on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-630996605
Sounds good. Please let me know the best way to access the test.
On Tue, May 19, 2020 at 12:17 PM Michael Vorburger ⛑️ <
notifications@github.com> wrote:
> It's a unit test (that I wrote..), not an integration test. You can even
> easily run that test in your IDE, it should give you the same result?
>
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/907#issuecomment-630994086>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AE5G5XY2VU3LNF4CJGIGLQDRSLEL5ANCNFSM4NDW7TZA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] nnatarajan edited a comment on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3…
Posted by GitBox <gi...@apache.org>.
nnatarajan edited a comment on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-630976638
@xurror
I ran the integration test, but this specific error did not come up. How do I duplicate this specific error on my end: **classpath duplicate error**?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3…
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-630038203
@nnatarajan if stuck/unclear on this, it's totally OK (for me) if you first look at another issue, and come back to this later after someone else had a chance to look at this problem more closely? As @xurror said it probably needs some exclusion, but it's not always very obvious which.. BTW one of is could perhaps write up a short paragraph for the README with some guidance about how to do these upgrades - anyone interested?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] nnatarajan commented on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3.0.18
Posted by GitBox <gi...@apache.org>.
nnatarajan commented on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-632270161
@vorburger - This morning, I made additional changes to the file. It appears all checks have passed. In addition to yesterday's casting errors, similarly I found other type errors. I hope this is resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3.0.18
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-631397661
That new problem is just due to the meanwhile merged #908 and should, hopefully, be trivial to resolve... almost there with this one!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] nnatarajan commented on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3.0.18
Posted by GitBox <gi...@apache.org>.
nnatarajan commented on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-631697014
I removed the casting, but now an error is thrown:
Verification failed: SpotBugs execution thrown exception
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger merged pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3.0.18
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #907:
URL: https://github.com/apache/fineract/pull/907
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror commented on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3…
Posted by GitBox <gi...@apache.org>.
xurror commented on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-629966842
Maybe try to exclude groovy-all in dependencies.gradle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3.0.18
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-631709897
Hm #913 was supposed to fix that. Did you git rebase it from latest develop? It passed here because if you type slash rebase then then the remote branch of the PR gets rebased by a bot, but if you locally fix something and force push, without having rebased locally also, then that remote rebase is overwritten and lost. Does that make sense? Try to locally rebase, ./gradlew build, and if PK, then force push again, it will probably turn green.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] nnatarajan commented on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3.0.18
Posted by GitBox <gi...@apache.org>.
nnatarajan commented on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-631662226
@vorburger , is a more experienced dev taking this on? I will remove myself from the ticket if that is the case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror commented on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3…
Posted by GitBox <gi...@apache.org>.
xurror commented on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-629964817
@nnatarajan We have a classpath duplicate error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] nnatarajan edited a comment on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3.0.18
Posted by GitBox <gi...@apache.org>.
nnatarajan edited a comment on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-631719087
I had rebased before pushing up modifications and #913 in showing in the code. When I ran locally ./gradlew build -- showing same error.
Does it matter if I running on Java 11?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3…
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-630994086
It's a unit test (that I wrote..), not an integration test. You can even
easily run that test in your IDE, it should give you the same result?
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3.0.18
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-632143323
/rebase
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3.0.18
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-631385184
> /rebase
Ohhh..this actually works now? Where was it fixed? What was the problem? Just curious.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3.0.18
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-631663967
@nnatarajan no no no, you're almost there with this one, we'd love you to finish this off! I've fixed unrelated problems, and you now just need to rebase, fix the latest (new) problem re. the cast, and this should be good to merge very soon! Let's get it done today? Ask if unclear. Sorry for any confusion caused!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3.0.18
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-631086024
There are actually 2 totally separate problems here - the #911 business (solved), but also some weird incompatibility between this upgrade and the Spotbugs Gradle problem... :sob: @nnatarajan this isn't exactly the greatest "starter issue"... :smiling_imp: Would anyone else reading this want to help with figuring out the Spotbugs Gradle problem here? /Cc @thesmallstar if you are interested by this sort of thing...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3…
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-630999166
Find the exact name of that failing test on the Travis CI build log, open
it in your IDE, run it.
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3.0.18
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-632108963
> I had rebased before pushing up modifications and #913 in showing in the code.
Ok, great.
> Does it matter if I running on Java 11?
Fineract does not support Java 8 anymore, only Java 11.
> When I ran locally ./gradlew build -- showing same error.
yeah, I just locally pulled this PR, and likewise, I could locally reproduce it as well. Looking into `build/reports/spotbugs/main.html`, we can see that SpotBugs actually picked up on a real subtle but important bug breaking functionality that we would have introduced had we merged this PR as it is currently - thank God for SpotBugs! @nnatarajan will you look into and fix that particular problem here to get this PR to be green.
FINERACT-989 will look into the more general issue (not directly related to this PR) of SpotBug reporting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3.0.18
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-631387455
@nnatarajan ...This now looks more friendly and may be easier to fix? See Travis Log: https://travis-ci.org/github/apache/fineract/builds/689183927
Something about redundant Casting to "Class"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3.0.18
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-631383410
/rebase
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] nnatarajan commented on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3.0.18
Posted by GitBox <gi...@apache.org>.
nnatarajan commented on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-631719087
I had rebased before pushing up modifications and #913 in showing in the code. When I ran locally ./gradlew build -- showing same error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3.0.18
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-631139367
I wonder if that Spotbugs Gradle problem may just disappear with #913 ... worth a rebase, after that's in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3.0.18
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-631373350
#913 and #911 have now been merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] nnatarajan edited a comment on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3.0.18
Posted by GitBox <gi...@apache.org>.
nnatarajan edited a comment on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-632270161
@vorburger - This morning, I made additional changes to the file. It appears all checks have passed. In addition to yesterday's casting errors, similarly, I found other type errors. I hope this is resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] nnatarajan edited a comment on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3.0.18
Posted by GitBox <gi...@apache.org>.
nnatarajan edited a comment on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-631697014
I removed the casting, but now, within Travis an error is thrown. What is the best way to resolve?:
Verification failed: SpotBugs execution thrown exception
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] nnatarajan commented on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3…
Posted by GitBox <gi...@apache.org>.
nnatarajan commented on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-630976638
I ran the integration test, but this specific error did not come up. How do I duplicate this specific error on my end: **classpath duplicate error**?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger edited a comment on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3…
Posted by GitBox <gi...@apache.org>.
vorburger edited a comment on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-630038203
@nnatarajan if stuck/unclear on this, it's totally OK (for me) if you first look at another issue, and come back to this later after someone else had a chance to look at this problem more closely? As @xurror said it probably needs some exclusion, but it's not always very obvious which.. BTW someone could write up a short paragraph for the README with some guidance about how to do these upgrades - anyone interested?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3.0.18
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-632147993
While investigating FINERACT-989, I have learnt that @xurror just fixed this problem in FINERACT-986, and I expect the currently running rebased Travis will now show the error much more clearly.
@xurror I don't know if FINERACT-986 was a coincidence, but if it was related to you also investigating this, please do feel free to chime in and leave a comment on any PR next time you help like this - you're great!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3.0.18
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-631374774
Also see PR https://github.com/apache/fineract/pull/910 which has just been merged for some help.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] nnatarajan edited a comment on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3.0.18
Posted by GitBox <gi...@apache.org>.
nnatarajan edited a comment on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-631697014
I removed the casting, but now, within Travis an error is thrown:
Verification failed: SpotBugs execution thrown exception
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #907: Fineract-953 - Upgrade ical4j from ancient version 1.0.7 to current 3.0.18
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-631728882
Curious. You can either try to dig into it, or (totally fine me!) move on to another issue and let me or someone else have a closer look into this some other time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org