You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "liuxiaocs7 (via GitHub)" <gi...@apache.org> on 2023/06/18 17:56:32 UTC
[GitHub] [iceberg] liuxiaocs7 opened a new pull request, #7862: Core: Remove deprecated AssertHelpers in Avro
liuxiaocs7 opened a new pull request, #7862:
URL: https://github.com/apache/iceberg/pull/7862
- SubTask of https://github.com/apache/iceberg/issues/7094
Remove `AssertHelpers` in `iceberg-core-avro` module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra merged pull request #7862: Core: Remove deprecated AssertHelpers
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra merged PR #7862:
URL: https://github.com/apache/iceberg/pull/7862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on a diff in pull request #7862: Core: Remove deprecated AssertHelpers in Avro
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #7862:
URL: https://github.com/apache/iceberg/pull/7862#discussion_r1233595485
##########
core/src/test/java/org/apache/iceberg/avro/TestReadProjection.java:
##########
@@ -712,14 +713,21 @@ public void testEmptyNestedStructRequiredProjection() throws Exception {
Types.NestedField.required(2, "inner", Types.StructType.of()))));
Record projected = writeAndRead("nested_empty_req_proj", writeSchema, emptyStruct, record);
- AssertHelpers.assertEmptyAvroField(projected, "id");
+ assertEmptyAvroField(projected, "id");
+
Review Comment:
nit: unnecessary new line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] liuxiaocs7 commented on a diff in pull request #7862: Core: Remove deprecated AssertHelpers in Avro
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on code in PR #7862:
URL: https://github.com/apache/iceberg/pull/7862#discussion_r1233918273
##########
core/src/test/java/org/apache/iceberg/avro/TestReadProjection.java:
##########
@@ -712,14 +713,21 @@ public void testEmptyNestedStructRequiredProjection() throws Exception {
Types.NestedField.required(2, "inner", Types.StructType.of()))));
Record projected = writeAndRead("nested_empty_req_proj", writeSchema, emptyStruct, record);
- AssertHelpers.assertEmptyAvroField(projected, "id");
+ assertEmptyAvroField(projected, "id");
+
Review Comment:
done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org