You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "ctubbsii (via GitHub)" <gi...@apache.org> on 2023/12/20 22:42:14 UTC

[I] Test that WAL header length constants should be moved from DfsLogger to a unit test [accumulo]

ctubbsii opened a new issue, #4100:
URL: https://github.com/apache/accumulo/issues/4100

   DfsLogger [has an assertion in code](https://github.com/apache/accumulo/blob/f9897862dd4e6ff4892239ff5ebeb8ed6e34bc68/server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java#L333-L339) that the version 3 and version 4 WAL header constants are the same length. This should be moved to a unit test rather than left as a runtime assertion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Test that WAL header length constants should be moved from DfsLogger to a unit test [accumulo]

Posted by "EdColeman (via GitHub)" <gi...@apache.org>.
EdColeman closed issue #4100: Test that WAL header length constants should be moved from DfsLogger to a unit test
URL: https://github.com/apache/accumulo/issues/4100


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Test that WAL header length constants should be moved from DfsLogger to a unit test [accumulo]

Posted by "EdColeman (via GitHub)" <gi...@apache.org>.
EdColeman commented on issue #4100:
URL: https://github.com/apache/accumulo/issues/4100#issuecomment-1865242742

   I'm working the empty wal utility and its in the same area, I'll to this, it may help with the utility testing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org