You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@doris.apache.org by "foxtail463 (via GitHub)" <gi...@apache.org> on 2026/04/08 08:49:30 UTC

[PR] fix(load): fix invalid String.format pattern in NereidsStreamLoadTask [doris]

foxtail463 opened a new pull request, #62225:
URL: https://github.com/apache/doris/pull/62225

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

Re: [PR] fix(load): fix invalid String.format pattern in NereidsStreamLoadTask [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #62225:
URL: https://github.com/apache/doris/pull/62225#issuecomment-4205037488

No issues found in this change.

Critical checkpoint summary:
- Goal / correctness / test: The patch fixes an invalid `String.format` pattern in `NereidsStreamLoadTask`, so unsupported stream-load column expressions now raise the intended `UserException` instead of a formatting failure. No dedicated test was added for this error path.
- Change size / focus: Minimal and well-scoped two-line fix in the affected error messages only.
- Concurrency: Not involved.
- Lifecycle / static initialization: Not involved.
- Configuration: Not involved.
- Compatibility: No incompatible API, protocol, or storage-format change.
- Parallel code paths: I did not find the same broken format string elsewhere in FE Java sources.
- Special conditional checks: No new conditions added.
- Test coverage: Existing automated coverage for this exact failure path was not found, but the code change is straightforward and low risk.
- Observability: No additional observability needed for this fix.
- Transaction / persistence: Not involved.
- Data writes / atomicity: Not involved.
- FE/BE variable passing: Not involved.
- Performance: No impact.
- Other issues: None identified.

Applicable module checkpoints:
- FE exceptions: The method continues to surface a user-facing checked `UserException`; this patch only restores the intended message formatting.
- Nereids-specific review items: No rule, property-derivation, or optimizer-stage behavior is changed here.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

Re: [PR] fix(load): fix invalid String.format pattern in NereidsStreamLoadTask [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #62225:
URL: https://github.com/apache/doris/pull/62225#issuecomment-4205031240

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

Re: [PR] fix(load): fix invalid String.format pattern in NereidsStreamLoadTask [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #62225:
URL: https://github.com/apache/doris/pull/62225#issuecomment-4205031450

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

Re: [PR] [fix](load): fix invalid String.format pattern in NereidsStreamLoadTask [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.

hello-stephen commented on PR #62225:
URL: https://github.com/apache/doris/pull/62225#issuecomment-4205470486

   # FE UT Coverage Report
   Increment line coverage `  0.00% (0/2)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/62225_09016a0516e585759271bfcae423a8fa35a7ae22/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/62225_09016a0516e585759271bfcae423a8fa35a7ae22/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

Re: [PR] fix(load): fix invalid String.format pattern in NereidsStreamLoadTask [doris]

Posted by "morrySnow (via GitHub)" <gi...@apache.org>.

morrySnow commented on PR #62225:
URL: https://github.com/apache/doris/pull/62225#issuecomment-4205029498

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

Re: [PR] fix(load): fix invalid String.format pattern in NereidsStreamLoadTask [doris]

Posted by "morrySnow (via GitHub)" <gi...@apache.org>.

morrySnow commented on PR #62225:
URL: https://github.com/apache/doris/pull/62225#issuecomment-4205029951

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

Re: [PR] fix(load): fix invalid String.format pattern in NereidsStreamLoadTask [doris]

Posted by "Thearas (via GitHub)" <gi...@apache.org>.

Thearas commented on PR #62225:
URL: https://github.com/apache/doris/pull/62225#issuecomment-4205004440

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

Re: [PR] [fix](load): fix invalid String.format pattern in NereidsStreamLoadTask [doris]

Posted by "morrySnow (via GitHub)" <gi...@apache.org>.

morrySnow merged PR #62225:
URL: https://github.com/apache/doris/pull/62225


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org