[GitHub] [incubator-mxnet] suyz526 commented on a change in pull request #15317: fix doc for the op sort() and argsort()

[GitBox <gi...@apache.org>]

suyz526 commented on a change in pull request #15317: fix doc for the op sort() and argsort()
URL: https://github.com/apache/incubator-mxnet/pull/15317#discussion_r297536183
 
 

 ##########
 File path: src/operator/tensor/ordering_op.cc
 ##########
 @@ -114,7 +114,7 @@ Examples::
              [ 1.,  3.]]
 
   // flattens and then sorts
-  sort(x) = [ 1.,  1.,  3.,  4.]
+  sort(x, axis=None) = [ 1.,  1.,  3.,  4.]
 
 Review comment:
   Hi, 
   Thanks for your reply! 
   
   Do you mean this example?
   // sorts along the last axis
   `sort(x) = [[ 1.,  4.],
              [ 1.,  3.]]`
   
   Since x = `[[ 1, 4],[ 3, 1]]`, the pairs in the last axis are `[1,4]` and `[3,1]`. Sorting only along the last axis in a descend way would be `[1,4]` and `[1,3]`. So, in my opinion, it is correct? or maybe I'm wrong?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services