[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24523: [SPARK-27631][SQL] Avoid repeating calculate table statistics when AUTO_SIZE_UPDATE_ENABLED is enabled

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #24523: [SPARK-27631][SQL] Avoid repeating calculate table statistics when AUTO_SIZE_UPDATE_ENABLED is enabled
URL: https://github.com/apache/spark/pull/24523#discussion_r283064809
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/CommandUtils.scala
 ##########
 @@ -45,9 +45,13 @@ object CommandUtils extends Logging {
     val catalog = sparkSession.sessionState.catalog
     if (sparkSession.sessionState.conf.autoSizeUpdateEnabled) {
       val newTable = catalog.getTableMetadata(table.identifier)
-      val newSize = CommandUtils.calculateTotalSize(sparkSession, newTable)
-      val newStats = CatalogStatistics(sizeInBytes = newSize)
-      catalog.alterTableStats(table.identifier, Some(newStats))
+      if (newTable.stats == table.stats) {
+        val newSize = CommandUtils.calculateTotalSize(sparkSession, newTable)
+        val newStats = CatalogStatistics(sizeInBytes = newSize)
+        catalog.alterTableStats(table.identifier, Some(newStats))
+      } else {
+        logInfo(s"Skip to update statistics for ${table.qualifiedName} as it updated by Hive.")
 
 Review comment:
   For this, I'm just curious if we can claim this is valid for all (including future) Hive versions (HMS servers and megastore jars `spark.sql.hive.metastore.version`).
   > as it updated by Hive.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org