You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/07 08:28:35 UTC
[GitHub] [flink] WeiZhong94 commented on a change in pull request #8355:
[FLINK-12330][python]Add integrated Tox for ensuring compatibility of
multi-version of python.
WeiZhong94 commented on a change in pull request #8355: [FLINK-12330][python]Add integrated Tox for ensuring compatibility of multi-version of python.
URL: https://github.com/apache/flink/pull/8355#discussion_r281523363
##########
File path: flink-python/dev/lint-python.sh
##########
@@ -0,0 +1,508 @@
+#!/usr/bin/env bash
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+# lint-python.sh
+# This script will prepare a virtual environment for many kinds of checks, such as pytest, flake8 codestyle.
+#
+# You can refer to the README.MD in ${flink-python} to learn how easy to run the script.
+#
+
+# Download some software, such as miniconda.sh
+function download() {
+ local DOWNLOAD_STATUS=
+ if hash "wget" 2>/dev/null; then
+ wget "$1" -O "$2" -q --show-progress
+ DOWNLOAD_STATUS="$?"
+ else
+ curl "$1" -o "$2" --progress-bar
+ DOWNLOAD_STATUS="$?"
+ fi
+ if [ $DOWNLOAD_STATUS -ne 0 ]; then
+ echo "Dowload failed.You can try again"
+ exit $DOWNLOAD_STATUS
+ fi
+}
+
+# for print infos both in log and console
+function print_function() {
+ local STAGE_LENGTH=48
+ local left_edge_len=
+ local right_edge_len=
+ local str
+ case "$1" in
+ "STAGE")
+ left_edge_len=$(((STAGE_LENGTH-${#2})/2))
+ right_edge_len=$((STAGE_LENGTH-${#2}-left_edge_len))
+ str="$(seq -s "=" $left_edge_len | tr -d "[:digit:]")""$2""$(seq -s "=" $right_edge_len | tr -d "[:digit:]")"
+ ;;
+ "STEP")
+ str="$2"
+ ;;
+ *)
+ str="seq -s "=" $STAGE_LENGTH | tr -d "[:digit:]""
+ ;;
+ esac
+ echo $str | tee -a $LOG_FILE
+}
+
+# Checkpoint the stage:step for convenient to re-exec the script with
+# skipping those success steps.
+# The format is "${Stage}:${Step}". e.g. Install:4
+function checkpoint_stage() {
+ if [ ! -d `dirname $STAGE_FILE` ]; then
+ mkdir -p `dirname $STAGE_FILE`
+ fi
+ echo "$1:$2">"$STAGE_FILE"
+}
+
+# Restore the stage:step
+function restore_stage() {
+ if [ -f "$STAGE_FILE" ]; then
+ local lines=$(awk '{print NR}' $STAGE_FILE)
+ if [ $lines -eq 1 ]; then
+ local first_field=$(cat $STAGE_FILE | cut -d ":" -f 1)
+ local second_field=$(cat $STAGE_FILE | cut -d ":" -f 2)
+ check_valid_stage $first_field $second_field
+ if [ $? -eq 0 ]; then
+ STAGE=$first_field
+ STEP=$second_field
+ return
+ fi
+ fi
+ fi
+ STAGE="install"
+ STEP=0
+}
+
+# Decide whether the stage:step is valid.
+function check_valid_stage() {
+ case $1 in
+ "install")
+ if [ $2 -le $STAGE_INSTALL_STEPS ] && [ $2 -ge 0 ]; then
+ return 0
+ fi
+ ;;
+ "tox")
+ if [ $2 -eq 0 ]; then
+ return 0
+ fi
+ ;;
+ "flake8")
+ if [ $2 -eq 0 ]; then
+ return 0
+ fi
+ ;;
+ *)
+ ;;
+ esac
+ return 1
+}
+
+# For convenient to index something binded to OS.
+# Now, the script only make a distinction between 'Mac' and 'Non-Mac'.
+function get_os_index() {
+ if [ $1 == "Darwin" ]; then
+ return 0
+ else
+ return 1
+ fi
+}
+
+# Considering the file size of miniconda.sh,
+# "wget" is better than curl in the weak network environment.
+function install_wget() {
+ if [ $1 == "Darwin" ]; then
+ hash "brew" 2>/dev/null
+ if [ $? -ne 0 ]; then
+ $((/usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)") 2>&1 >/dev/null)
+ if [ $? -ne 0 ]; then
+ echo "Failed to install brew"
+ exit 1
+ fi
+ fi
+
+ hash "wget" 2>/dev/null
+ if [ $? -ne 0 ]; then
+ brew install wget 2>&1 >/dev/null
+ if [ $? -ne 0 ]; then
+ echo "Failed to install wget"
+ exit 1
+ fi
+ fi
+ fi
+}
+
+# The script choose miniconda as our package management tool.
+# The script use miniconda to create all kinds of python versions and
+# some pakcages such as tox and flake8.
+
+function install_miniconda() {
+ OS_TO_CONDA_URL=("https://repo.continuum.io/miniconda/Miniconda3-latest-MacOSX-x86_64.sh" \
+ "https://repo.continuum.io/miniconda/Miniconda3-latest-Linux-x86_64.sh")
+ print_function "STEP" "download miniconda..."
+ if [ ! -f "$CONDA_INSTALL" ]; then
+ download ${OS_TO_CONDA_URL[$1]} $CONDA_INSTALL_SH
+ chmod +x $CONDA_INSTALL_SH
+ if [ $? -ne 0 ]; then
+ echo "Please mannually chmod +x $CONDA_INSTALL_SH"
+ exit 1
+ fi
+ if [ -d "$CURRENT_DIR/.conda" ]; then
+ rm -rf "$CURRENT_DIR/.conda"
+ if [ $? -ne 0 ]; then
+ echo "Please mannually rm -rf $CURRENT_DIR/.conda directory.\
+ Then retry to exec the script."
+ exit 1
+ fi
+ fi
+ fi
+ print_function "STEP" "download miniconda... [SUCCESS]"
+
+ print_function "STEP" "installing conda..."
+ if [ ! -d "$CURRENT_DIR/.conda" ]; then
+ $CONDA_INSTALL_SH -b -p $CURRENT_DIR/.conda 2>&1 >/dev/null
+ if [ $? -ne 0 ]; then
+ echo "install miniconda failed"
+ exit $CONDA_INSTALL_STATUS
+ fi
+ fi
+ print_function "STEP" "install conda ... [SUCCESS]"
+}
+
+# Install some kinds of py env.
+function install_py_env() {
+ py_env=("2.7" "3.3" "3.4" "3.5" "3.6" "3.7")
+ for ((i=0;i<${#py_env[@]};i++)) do
+ if [ -d "$CURRENT_DIR/.conda/envs/${py_env[i]}" ]; then
+ rm -rf "$CURRENT_DIR/.conda/envs/${py_env[i]}"
+ if [ $? -ne 0 ]; then
+ echo "rm -rf $CURRENT_DIR/.conda/envs/${py_env[i]} failed, please \
+ rm -rf $CURRENT_DIR/.conda/envs/${py_env[i]} mannually.\
+ Then retry to exec the script."
+ exit 1
+ fi
+ fi
+ print_function "STEP" "installing python${py_env[i]}..."
+ ${CONDA_PATH} create --name ${py_env[i]} -y -q python=${py_env[i]} 2>&1 >/dev/null
+ if [ $? -ne 0 ]; then
+ echo "conda install ${py_env[i]} failed.\
+ You can retry to exec the script."
+ exit 1
+ fi
+ print_function "STEP" "install python${py_env[i]}... [SUCCESS]"
+ done
+}
+
+# Install tox.
+# In some situations,you need to run the script with "sudo". e.g. sudo ./lint-python
Review comment:
execute "sudo ./lint-python" will print this message on my device: "sudo: ./lint-python: command not found".
Is it mean "sudo ./lint-python.sh" ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services