You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "shangeyao (via GitHub)" <gi...@apache.org> on 2026/06/10 07:52:44 UTC
[PR] Core: Expose commit retry exhaustion reason in failure messages [iceberg]
shangeyao opened a new pull request, #16757:
URL: https://github.com/apache/iceberg/pull/16757
### Summary
Fixes #16744.
When commit retry is exhausted, the failure message currently rethrows the underlying `CommitFailedException` without indicating why the retry loop stopped. This makes it hard for operators to know which table property to tune (`commit.retry.num-retries` vs `commit.retry.total-timeout-ms`).
This change:
- Adds `RetryExhaustedException` with a `Reason` enum (`RETRY_LIMIT_EXCEEDED` / `TIMEOUT_EXCEEDED`) in `Tasks.java`
- Throws `RetryExhaustedException` (preserving the original exception as cause) when retry is exhausted
- Catches `RetryExhaustedException` at all 14 commit call sites and translates the reason into actionable messages, e.g.:
- `"Commit failed and retry timeout (60000 ms) reached. Consider increasing 'commit.retry.total-timeout-ms'"`
- `"Commit failed and retry limit (4) reached. Consider increasing 'commit.retry.num-retries'"`
The design keeps the generic retry utility (`Tasks`) unaware of Iceberg property names — classification happens in `Tasks`, translation happens at commit call sites.
### Testing
```bash
./gradlew :iceberg-core:test --tests "org.apache.iceberg.util.TestTasks"
./gradlew :iceberg-core:compileJava
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Expose commit retry exhaustion reason in failure messages [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16757:
URL: https://github.com/apache/iceberg/pull/16757#issuecomment-5053041853
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Expose commit retry exhaustion reason in failure messages [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #16757: Core: Expose commit retry exhaustion reason in failure messages
URL: https://github.com/apache/iceberg/pull/16757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Expose commit retry exhaustion reason in failure messages [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16757:
URL: https://github.com/apache/iceberg/pull/16757#issuecomment-4986689179
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org