You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Ignasi Barrera <no...@github.com> on 2016/09/26 13:39:20 UTC

[jclouds/jclouds] GCE live test fixes (#1015)

This fixes all live tests except one. We're close to having all green!
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1015

-- Commit Summary --

  * GCE live test fixes

-- File Changes --

    M providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/config/GoogleComputeEngineServiceContextModule.java (3)
    M providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Instance.java (2)
    M providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineServiceLiveTest.java (9)
    M providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/functions/InstanceToNodeMetadataTest.java (2)
    M providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/InstanceApiLiveTest.java (1)
    M providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/InstanceApiWindowsLiveTest.java (2)
    M providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/TargetPoolApiLiveTest.java (7)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1015.patch
https://github.com/jclouds/jclouds/pull/1015.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1015

Re: [jclouds/jclouds] GCE live test fixes (#1015)

Posted by Ignasi Barrera <no...@github.com>.

I'll merge it and I'll move tot he Azure ARM compute service live tests. The test that is failing shouldn't block the release. WDYT?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1015#issuecomment-249585498

Re: [jclouds/jclouds] GCE live test fixes (#1015)

Posted by Andrea Turli <no...@github.com>.

great! you want to continue on this PR or prefer merging it and work on the last failing test on a different PR?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1015#issuecomment-249582307

Re: [jclouds/jclouds] GCE live test fixes (#1015)

Posted by Andrea Turli <no...@github.com>.

+1

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1015#issuecomment-249585667