You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/08 06:07:53 UTC

[GitHub] [pulsar] congbobo184 commented on a diff in pull request #15067: [ML] Follow up on race condition fixes in ManagedCursorImpl #15031

congbobo184 commented on code in PR #15067:
URL: https://github.com/apache/pulsar/pull/15067#discussion_r845764825


##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -1814,6 +1876,9 @@ public void operationComplete() {
                             mdEntry.newPosition);
                 }
 
+                INPROGRESS_MARKDELETE_PERSIST_POSITION_UPDATER.compareAndSet(ManagedCursorImpl.this,
+                        mdEntry.newPosition, null);
+

Review Comment:
   internalMarkDelete is not a sync method, so persistPositionToLedger may persist 2 then persist 1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org