You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by "chanani (via GitHub)" <gi...@apache.org> on 2026/03/01 03:07:48 UTC

Re: [PR] Catch `LinkageError` in `ThrowableExtendedStackTraceRenderer#loadClass` (#4028) [logging-log4j2]

chanani commented on PR #4049:
URL: https://github.com/apache/logging-log4j2/pull/4049#issuecomment-3978948569

   Hi @vy, thank you for the review! I've addressed all the feedback:
   
   1. **`catch (Throwable)`** — Applied the suggested change to catch all `Throwable`s instead of `Exception | LinkageError`
   2. **Changelog description** — Updated to "Ensure all `Throwable`s are handled while rendering stack traces"
   3. **Changelog issue link** — Changed from `#4028` to `#4049`
   4. **Tests moved** — Removed `ThrowableExtendedStackTraceRendererTest` and added the test cases into `ThrowablePatternConverterTest.StackTraceTest` as requested
   
   Please let me know if any further changes are needed!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org