You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/07/14 22:31:36 UTC
[GitHub] [skywalking] hanahmily opened a new pull request #5099: [WIP]Storage elasticsearch health
hanahmily opened a new pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099
These changes intend to add health checks to elasticsearch storage plugin.
* Update elasticsearch client 6.x and 7.x to the latest version, which tries to fix some underlying connection issues.
* Add HealthChecker to combinate between provider and storage service client. The HealthChecker opts to "sync" strategy which means it doesn't set up an async scheduler to check backend server periodically. That is because our persistence timer will touch the storage server every 3 seconds(the default value), so we can leverage it as a health checking trigger.
* Some users report issues like https://github.com/elastic/elasticsearch/issues/39946, in this PR, I fix this issue by recreating a new RestClient once catching the IllegalStateExecption indicate the collection pool is closed under the hood.
I only update the elasticsearch 6 in the current commit. After getting enough feedbacks to polish the implementation, I will update elasticsearch 7 accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f&el=desc) will **decrease** coverage by `22.17%`.
> The diff coverage is `7.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.25% 30.07% -22.18%
+ Complexity 2963 1730 -1233
=============================================
Files 778 758 -20
Lines 19523 19024 -499
Branches 1924 1890 -34
=============================================
- Hits 10201 5722 -4479
- Misses 8472 12855 +4383
+ Partials 850 447 -403
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [281 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [ce2469d...2d3e245](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `53.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 0.00% -53.09%
============================================
Files 778 156 -622
Lines 19518 3928 -15590
Branches 1924 471 -1453
============================================
- Hits 10362 0 -10362
+ Misses 8297 3928 -4369
+ Partials 859 0 -859
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [739 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `2.06%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.03% 50.97% -2.07%
+ Complexity 2987 2913 -74
============================================
Files 779 775 -4
Lines 19525 19428 -97
Branches 1924 1915 -9
============================================
- Hits 10355 9903 -452
- Misses 8309 8691 +382
+ Partials 861 834 -27
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...gin/influxdb/query/ProfileThreadSnapshotQuery.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeS5qYXZh) | `3.57% <0.00%> (-83.93%)` | `2.00% <0.00%> (-9.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| ... and [27 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `11.05%`.
> The diff coverage is `47.13%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.23% 41.17% -11.06%
+ Complexity 2962 2280 -682
=============================================
Files 779 773 -6
Lines 19525 19448 -77
Branches 1924 1900 -24
=============================================
- Hits 10198 8008 -2190
- Misses 8473 10845 +2372
+ Partials 854 595 -259
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `15.38% <0.00%> (-34.62%)` | `8.00 <0.00> (-5.00)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.34% <36.76%> (-8.50%)` | `25.00 <3.00> (ø)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `58.51% <44.00%> (-6.30%)` | `17.00 <1.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <1.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `68.18% <100.00%> (+1.51%)` | `8.00 <1.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [164 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...929f455](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `2.03%`.
> The diff coverage is `44.76%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.23% 50.19% -2.04%
+ Complexity 2962 2828 -134
============================================
Files 779 761 -18
Lines 19525 19131 -394
Branches 1924 1891 -33
============================================
- Hits 10198 9603 -595
- Misses 8473 8725 +252
+ Partials 854 803 -51
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `51.73% <32.35%> (-11.11%)` | `24.00 <3.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <2.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| ... and [60 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `23.40%`.
> The diff coverage is `8.79%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 53.03% 29.63% -23.41%
+ Complexity 2987 1708 -1279
=============================================
Files 779 758 -21
Lines 19525 19031 -494
Branches 1924 1884 -40
=============================================
- Hits 10355 5639 -4716
- Misses 8309 12955 +4646
+ Partials 861 437 -424
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [289 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...9f50fa8](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `4.08%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.03% 48.95% -4.09%
+ Complexity 2987 2815 -172
============================================
Files 779 770 -9
Lines 19525 19267 -258
Branches 1924 1878 -46
============================================
- Hits 10355 9432 -923
- Misses 8309 9031 +722
+ Partials 861 804 -57
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [60 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `3.63%`.
> The diff coverage is `47.79%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.23% 48.60% -3.64%
+ Complexity 2962 2820 -142
============================================
Files 779 774 -5
Lines 19525 19469 -56
Branches 1924 1920 -4
============================================
- Hits 10198 9462 -736
- Misses 8473 9206 +733
+ Partials 854 801 -53
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.34% <36.76%> (-8.50%)` | `25.00 <3.00> (ø)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `58.51% <44.00%> (-6.30%)` | `17.00 <1.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <2.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `68.18% <100.00%> (+1.51%)` | `8.00 <2.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [51 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **increase** coverage by `0.36%`.
> The diff coverage is `46.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 53.03% 53.39% +0.36%
- Complexity 2987 2990 +3
============================================
Files 779 777 -2
Lines 19525 19444 -81
Branches 1924 1916 -8
============================================
+ Hits 10355 10383 +28
+ Misses 8309 8199 -110
- Partials 861 862 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.59% <43.93%> (-4.26%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | | | |
| [.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh) | | | |
| [...ache/skywalking/apm/agent/core/util/FileUtils.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9GaWxlVXRpbHMuamF2YQ==) | | | |
| [...apache/skywalking/apm/agent/core/util/IOUtils.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9JT1V0aWxzLmphdmE=) | | | |
| ... and [4 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **increase** coverage by `0.14%`.
> The diff coverage is `52.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 52.23% 52.37% +0.14%
- Complexity 2962 2967 +5
============================================
Files 779 780 +1
Lines 19525 19582 +57
Branches 1924 1926 +2
============================================
+ Hits 10198 10257 +59
- Misses 8473 8480 +7
+ Partials 854 845 -9
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.69% <44.11%> (-4.15%)` | `26.00 <3.00> (+1.00)` | :arrow_down: |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `62.96% <50.00%> (-1.86%)` | `18.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <2.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `68.18% <100.00%> (+1.51%)` | `8.00 <2.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [18 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...929f455](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `21.86%`.
> The diff coverage is `20.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.23% 30.36% -21.87%
+ Complexity 2962 1743 -1219
=============================================
Files 779 757 -22
Lines 19525 19002 -523
Branches 1924 1884 -40
=============================================
- Hits 10198 5770 -4428
- Misses 8473 12787 +4314
+ Partials 854 445 -409
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `15.38% <0.00%> (-34.62%)` | `8.00 <0.00> (-5.00)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.63% <0.00%> (-60.59%)` | `2.00 <0.00> (-7.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [276 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `18.63%`.
> The diff coverage is `20.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.23% 33.59% -18.64%
+ Complexity 2962 1889 -1073
=============================================
Files 779 757 -22
Lines 19525 18950 -575
Branches 1924 1863 -61
=============================================
- Hits 10198 6367 -3831
- Misses 8473 12077 +3604
+ Partials 854 506 -348
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `15.38% <0.00%> (-34.62%)` | `8.00 <0.00> (-5.00)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.63% <0.00%> (-60.59%)` | `2.00 <0.00> (-7.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [254 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...929f455](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `14.41%`.
> The diff coverage is `47.61%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.23% 37.81% -14.42%
+ Complexity 2962 2089 -873
=============================================
Files 779 757 -22
Lines 19525 19034 -491
Branches 1924 1886 -38
=============================================
- Hits 10198 7198 -3000
- Misses 8473 11285 +2812
+ Partials 854 551 -303
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `15.38% <0.00%> (-34.62%)` | `8.00 <0.00> (-5.00)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.34% <36.76%> (-8.50%)` | `25.00 <3.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <2.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [206 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `19.94%`.
> The diff coverage is `8.79%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 53.03% 33.08% -19.95%
+ Complexity 2987 1875 -1112
=============================================
Files 779 758 -21
Lines 19525 19031 -494
Branches 1924 1885 -39
=============================================
- Hits 10355 6297 -4058
- Misses 8309 12226 +3917
+ Partials 861 508 -353
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [257 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...9f50fa8](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `52.22%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.22% 0.00% -52.23%
============================================
Files 779 159 -620
Lines 19525 4016 -15509
Branches 1924 483 -1441
============================================
- Hits 10196 0 -10196
+ Misses 8475 4016 -4459
+ Partials 854 0 -854
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [737 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `52.23%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.23% 0.00% -52.24%
============================================
Files 779 158 -621
Lines 19525 3937 -15588
Branches 1924 472 -1452
============================================
- Hits 10198 0 -10198
+ Misses 8473 3937 -4536
+ Partials 854 0 -854
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [739 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...929f455](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `20.59%`.
> The diff coverage is `20.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.23% 31.63% -20.60%
+ Complexity 2962 1786 -1176
=============================================
Files 779 751 -28
Lines 19525 18790 -735
Branches 1924 1835 -89
=============================================
- Hits 10198 5945 -4253
- Misses 8473 12398 +3925
+ Partials 854 447 -407
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `15.38% <0.00%> (-34.62%)` | `8.00 <0.00> (-5.00)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.63% <0.00%> (-60.59%)` | `2.00 <0.00> (-7.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [264 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `4.37%`.
> The diff coverage is `44.76%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.23% 47.85% -4.38%
+ Complexity 2962 2692 -270
============================================
Files 779 753 -26
Lines 19525 18888 -637
Branches 1924 1842 -82
============================================
- Hits 10198 9038 -1160
- Misses 8473 9097 +624
+ Partials 854 753 -101
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `51.73% <32.35%> (-11.11%)` | `24.00 <3.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <2.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [91 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `18.18%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 53.08% 34.90% -18.19%
+ Complexity 2988 1937 -1051
=============================================
Files 778 750 -28
Lines 19518 18869 -649
Branches 1924 1861 -63
=============================================
- Hits 10362 6586 -3776
- Misses 8297 11791 +3494
+ Partials 859 492 -367
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [236 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `3.90%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.03% 49.13% -3.91%
+ Complexity 2987 2815 -172
============================================
Files 779 766 -13
Lines 19525 19197 -328
Branches 1924 1872 -52
============================================
- Hits 10355 9432 -923
- Misses 8309 8961 +652
+ Partials 861 804 -57
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [64 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `1.14%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 51.94% -1.15%
+ Complexity 2988 2948 -40
============================================
Files 778 778
Lines 19518 19557 +39
Branches 1924 1927 +3
============================================
- Hits 10362 10159 -203
- Misses 8297 8556 +259
+ Partials 859 842 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
| [...ap/server/core/storage/ttl/DataTTLKeeperTimer.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS90dGwvRGF0YVRUTEtlZXBlclRpbWVyLmphdmE=) | `29.03% <0.00%> (-48.39%)` | `2.00% <0.00%> (-4.00%)` | |
| ... and [18 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `48.64%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 53.03% 53.05% +0.02%
- Complexity 2987 2990 +3
============================================
Files 779 779
Lines 19525 19598 +73
Branches 1924 1925 +1
============================================
+ Hits 10355 10398 +43
- Misses 8309 8338 +29
- Partials 861 862 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `57.82% <42.64%> (-5.02%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `62.96% <50.00%> (+1.85%)` | `18.00 <1.00> (+1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <71.42%> (-1.22%)` | `9.00 <2.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `65.21% <71.42%> (-1.45%)` | `8.00 <2.00> (ø)` | |
| [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | | | |
| ... and [1 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...9f50fa8](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `0.12%`.
> The diff coverage is `47.13%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.23% 52.10% -0.13%
Complexity 2962 2962
============================================
Files 779 782 +3
Lines 19525 19615 +90
Branches 1924 1926 +2
============================================
+ Hits 10198 10220 +22
- Misses 8473 8552 +79
+ Partials 854 843 -11
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.34% <36.76%> (-8.50%)` | `25.00 <3.00> (ø)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `58.51% <44.00%> (-6.30%)` | `17.00 <1.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <1.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `68.18% <100.00%> (+1.51%)` | `8.00 <1.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [22 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...929f455](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `0.93%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 52.15% -0.94%
+ Complexity 2988 2962 -26
============================================
Files 778 780 +2
Lines 19518 19578 +60
Branches 1924 1928 +4
============================================
- Hits 10362 10211 -151
- Misses 8297 8518 +221
+ Partials 859 849 -10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=) | `3.50% <0.00%> (-59.65%)` | `2.00% <0.00%> (-12.00%)` | |
| [...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==) | `23.33% <0.00%> (-28.34%)` | `6.00% <0.00%> (-5.00%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| ... and [8 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `53.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.03% 0.00% -53.04%
============================================
Files 779 149 -630
Lines 19525 3773 -15752
Branches 1924 447 -1477
============================================
- Hits 10355 0 -10355
+ Misses 8309 3773 -4536
+ Partials 861 0 -861
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [746 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `10.98%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 53.08% 42.10% -10.99%
+ Complexity 2988 2279 -709
=============================================
Files 778 768 -10
Lines 19518 19317 -201
Branches 1924 1895 -29
=============================================
- Hits 10362 8134 -2228
- Misses 8297 10579 +2282
+ Partials 859 604 -255
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [163 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f&el=desc) will **decrease** coverage by `22.17%`.
> The diff coverage is `7.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.25% 30.07% -22.18%
+ Complexity 2963 1732 -1231
=============================================
Files 778 759 -19
Lines 19523 19034 -489
Branches 1924 1890 -34
=============================================
- Hits 10201 5725 -4476
- Misses 8472 12864 +4392
+ Partials 850 445 -405
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [278 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [ce2469d...2d3e245](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `47.13%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=========================================
Coverage 52.23% 52.23%
+ Complexity 2962 2961 -1
=========================================
Files 779 780 +1
Lines 19525 19564 +39
Branches 1924 1911 -13
=========================================
+ Hits 10198 10219 +21
- Misses 8473 8502 +29
+ Partials 854 843 -11
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.34% <36.76%> (-8.50%)` | `25.00 <3.00> (ø)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `58.51% <44.00%> (-6.30%)` | `17.00 <1.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <1.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `68.18% <100.00%> (+1.51%)` | `8.00 <1.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [30 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...929f455](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `20.95%`.
> The diff coverage is `20.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.23% 31.27% -20.96%
+ Complexity 2962 1787 -1175
=============================================
Files 779 757 -22
Lines 19525 19014 -511
Branches 1924 1884 -40
=============================================
- Hits 10198 5947 -4251
- Misses 8473 12621 +4148
+ Partials 854 446 -408
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `15.38% <0.00%> (-34.62%)` | `8.00 <0.00> (-5.00)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.63% <0.00%> (-60.59%)` | `2.00 <0.00> (-7.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [256 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `52.23%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.23% 0.00% -52.24%
============================================
Files 779 161 -618
Lines 19525 4028 -15497
Branches 1924 483 -1441
============================================
- Hits 10198 0 -10198
+ Misses 8473 4028 -4445
+ Partials 854 0 -854
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [737 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `21.89%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.23% 30.33% -21.90%
+ Complexity 2962 1727 -1235
=============================================
Files 779 757 -22
Lines 19525 18941 -584
Branches 1924 1863 -61
=============================================
- Hits 10198 5746 -4452
- Misses 8473 12720 +4247
+ Partials 854 475 -379
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `15.38% <0.00%> (-34.62%)` | `8.00 <0.00> (-5.00)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `0.00% <0.00%> (-53.53%)` | `0.00 <0.00> (-13.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.63% <0.00%> (-60.59%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `11.62% <0.00%> (-80.04%)` | `3.00 <0.00> (-7.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-28.58%)` | `0.00 <0.00> (-1.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [280 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...929f455](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `53.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.03% 0.00% -53.04%
============================================
Files 779 150 -629
Lines 19525 3793 -15732
Branches 1924 448 -1476
============================================
- Hits 10355 0 -10355
+ Misses 8309 3793 -4516
+ Partials 861 0 -861
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [743 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...9f50fa8](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `0.20%`.
> The diff coverage is `46.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 52.88% -0.21%
+ Complexity 2988 2984 -4
============================================
Files 778 781 +3
Lines 19518 19582 +64
Branches 1924 1928 +4
============================================
- Hits 10362 10355 -7
- Misses 8297 8369 +72
+ Partials 859 858 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.59% <43.93%> (-4.26%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [2 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `3.63%`.
> The diff coverage is `47.79%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.23% 48.59% -3.64%
+ Complexity 2962 2819 -143
============================================
Files 779 773 -6
Lines 19525 19464 -61
Branches 1924 1920 -4
============================================
- Hits 10198 9458 -740
- Misses 8473 9205 +732
+ Partials 854 801 -53
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.34% <36.76%> (-8.50%)` | `25.00 <3.00> (ø)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `58.51% <44.00%> (-6.30%)` | `17.00 <1.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <2.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `68.18% <100.00%> (+1.51%)` | `8.00 <2.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [53 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `4.80%`.
> The diff coverage is `11.36%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.03% 48.23% -4.81%
+ Complexity 2987 2778 -209
============================================
Files 779 766 -13
Lines 19525 19197 -328
Branches 1924 1872 -52
============================================
- Hits 10355 9259 -1096
- Misses 8309 9150 +841
+ Partials 861 788 -73
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `13.75% <0.00%> (-52.47%)` | `3.00 <0.00> (-6.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `16.74% <3.03%> (-46.11%)` | `8.00 <1.00> (-17.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [73 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `22.93%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 53.08% 30.15% -22.94%
+ Complexity 2988 1738 -1250
=============================================
Files 778 759 -19
Lines 19518 19044 -474
Branches 1924 1890 -34
=============================================
- Hits 10362 5742 -4620
- Misses 8297 12855 +4558
+ Partials 859 447 -412
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [275 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `1.10%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 51.98% -1.11%
+ Complexity 2988 2910 -78
============================================
Files 778 768 -10
Lines 19518 19317 -201
Branches 1924 1895 -29
============================================
- Hits 10362 10041 -321
- Misses 8297 8434 +137
+ Partials 859 842 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh) | `0.00% <0.00%> (-94.34%)` | `0.00% <0.00%> (-14.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| ... and [40 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a change in pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#discussion_r456911607
##########
File path: oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/StorageModuleElasticsearchProvider.java
##########
@@ -197,7 +208,7 @@ public void notifyAfterCompleted() {
@Override
public String[] requiredModules() {
- return new String[]{CoreModule.NAME};
+ return new String[]{CoreModule.NAME, TelemetryModule.NAME};
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `23.39%`.
> The diff coverage is `8.79%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 53.03% 29.64% -23.40%
+ Complexity 2987 1709 -1278
=============================================
Files 779 758 -21
Lines 19525 19031 -494
Branches 1924 1884 -40
=============================================
- Hits 10355 5641 -4714
- Misses 8309 12954 +4645
+ Partials 861 436 -425
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [289 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...9f50fa8](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f&el=desc) will **decrease** coverage by `21.15%`.
> The diff coverage is `7.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.25% 31.09% -21.16%
+ Complexity 2963 1785 -1178
=============================================
Files 778 762 -16
Lines 19523 19091 -432
Branches 1924 1891 -33
=============================================
- Hits 10201 5936 -4265
- Misses 8472 12707 +4235
+ Partials 850 448 -402
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [253 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [ce2469d...2d3e245](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a change in pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#discussion_r456915149
##########
File path: oap-server/server-storage-plugin/storage-elasticsearch7-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch7/client/ElasticSearch7Client.java
##########
@@ -256,9 +292,9 @@ public void synchronousBulk(BulkRequest request) {
int size = request.requests().size();
BulkResponse responses = client.bulk(request, RequestOptions.DEFAULT);
log.info("Synchronous bulk took time: {} millis, size: {}", responses.getTook().getMillis(), size);
- } catch (IOException e) {
- log.error(e.getMessage(), e);
- }
+ healthChecker.health();
+ } catch (Throwable t) {
+ healthChecker.unHealth(t); }
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `46.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 53.03% 53.12% +0.08%
- Complexity 2987 2990 +3
============================================
Files 779 1417 +638
Lines 19525 30733 +11208
Branches 1924 3421 +1497
============================================
+ Hits 10355 16326 +5971
- Misses 8309 13604 +5295
+ Partials 861 803 -58
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `57.82% <43.93%> (-5.02%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| ... and [969 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `52.22%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.22% 0.00% -52.23%
============================================
Files 779 156 -623
Lines 19525 3925 -15600
Branches 1924 472 -1452
============================================
- Hits 10196 0 -10196
+ Misses 8475 3925 -4550
+ Partials 854 0 -854
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [739 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `0.64%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 52.44% -0.65%
+ Complexity 2988 2948 -40
============================================
Files 778 771 -7
Lines 19518 19371 -147
Branches 1924 1902 -22
============================================
- Hits 10362 10159 -203
- Misses 8297 8370 +73
+ Partials 859 842 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
| [...ap/server/core/storage/ttl/DataTTLKeeperTimer.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS90dGwvRGF0YVRUTEtlZXBlclRpbWVyLmphdmE=) | `29.03% <0.00%> (-48.39%)` | `2.00% <0.00%> (-4.00%)` | |
| ... and [26 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **increase** coverage by `0.36%`.
> The diff coverage is `46.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 53.03% 53.39% +0.36%
- Complexity 2987 2990 +3
============================================
Files 779 777 -2
Lines 19525 19444 -81
Branches 1924 1916 -8
============================================
+ Hits 10355 10383 +28
+ Misses 8309 8199 -110
- Partials 861 862 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.59% <43.93%> (-4.26%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...apache/skywalking/apm/agent/core/util/IOUtils.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9JT1V0aWxzLmphdmE=) | | | |
| [...ache/skywalking/apm/agent/core/util/FileUtils.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9GaWxlVXRpbHMuamF2YQ==) | | | |
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | | | |
| [.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh) | | | |
| ... and [4 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `4.71%`.
> The diff coverage is `44.76%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.23% 47.51% -4.72%
+ Complexity 2962 2692 -270
============================================
Files 779 758 -21
Lines 19525 19023 -502
Branches 1924 1869 -55
============================================
- Hits 10198 9039 -1159
- Misses 8473 9231 +758
+ Partials 854 753 -101
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `51.73% <32.35%> (-11.11%)` | `24.00 <3.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <2.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [79 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **increase** coverage by `0.30%`.
> The diff coverage is `46.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 53.03% 53.34% +0.30%
+ Complexity 2987 2986 -1
============================================
Files 779 777 -2
Lines 19525 19444 -81
Branches 1924 1916 -8
============================================
+ Hits 10355 10372 +17
+ Misses 8309 8210 -99
- Partials 861 862 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.59% <43.93%> (-4.26%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...storage/plugin/influxdb/base/HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0hpc3RvcnlEZWxldGVEQU8uamF2YQ==) | `33.33% <0.00%> (-33.34%)` | `2.00% <0.00%> (-1.00%)` | |
| [...p/server/storage/plugin/influxdb/InfluxClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9JbmZsdXhDbGllbnQuamF2YQ==) | `58.82% <0.00%> (-3.93%)` | `13.00% <0.00%> (-1.00%)` | |
| [...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==) | `50.83% <0.00%> (-0.84%)` | `10.00% <0.00%> (-1.00%)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `61.11% <0.00%> (ø)` | `17.00% <0.00%> (ø%)` | |
| ... and [7 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `53.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 0.00% -53.09%
============================================
Files 778 161 -617
Lines 19518 3981 -15537
Branches 1924 476 -1448
============================================
- Hits 10362 0 -10362
+ Misses 8297 3981 -4316
+ Partials 859 0 -859
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [736 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `2.04%`.
> The diff coverage is `44.76%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.23% 50.18% -2.05%
+ Complexity 2962 2828 -134
============================================
Files 779 762 -17
Lines 19525 19136 -389
Branches 1924 1891 -33
============================================
- Hits 10198 9603 -595
- Misses 8473 8730 +257
+ Partials 854 803 -51
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `51.73% <32.35%> (-11.11%)` | `24.00 <3.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <2.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| ... and [59 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `21.76%`.
> The diff coverage is `20.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.23% 30.46% -21.77%
+ Complexity 2962 1729 -1233
=============================================
Files 779 749 -30
Lines 19525 18767 -758
Branches 1924 1835 -89
=============================================
- Hits 10198 5717 -4481
- Misses 8473 12608 +4135
+ Partials 854 442 -412
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `15.38% <0.00%> (-34.62%)` | `8.00 <0.00> (-5.00)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.63% <0.00%> (-60.59%)` | `2.00 <0.00> (-7.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [298 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `46.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 53.03% 53.12% +0.08%
- Complexity 2987 2990 +3
============================================
Files 779 1417 +638
Lines 19525 30733 +11208
Branches 1924 3421 +1497
============================================
+ Hits 10355 16326 +5971
- Misses 8309 13604 +5295
+ Partials 861 803 -58
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `57.82% <43.93%> (-5.02%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| ... and [969 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...d5e840a](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a change in pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#discussion_r454834428
##########
File path: oap-server/pom.xml
##########
@@ -64,7 +64,7 @@
<h2.version>1.4.196</h2.version>
<commons-dbcp.version>1.4</commons-dbcp.version>
<commons-io.version>2.6</commons-io.version>
- <elasticsearch.version>6.3.2</elasticsearch.version>
+ <elasticsearch.version>6.8.10</elasticsearch.version>
Review comment:
I notice the same thing, so just revert that commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#discussion_r455472048
##########
File path: oap-server/server-library/library-client/src/main/java/org/apache/skywalking/oap/server/library/client/healthcheck/HealthChecker.java
##########
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.library.client.healthcheck;
+
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+
+/**
+ * HealthChecker could provide health status to the listener.
+ */
+@Slf4j
+@RequiredArgsConstructor
+public class HealthChecker {
Review comment:
Why need HealthChecker as a kind of util? And keep in static final(DEFAULT_CHECKER)?
According to #5046, Health check is a module/provider. So, the thing about the checker should be a service, which you could get a reference from ServiceManager in any module.
##########
File path: oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/StorageModuleElasticsearchProvider.java
##########
@@ -197,7 +208,7 @@ public void notifyAfterCompleted() {
@Override
public String[] requiredModules() {
- return new String[]{CoreModule.NAME};
+ return new String[]{CoreModule.NAME, TelemetryModule.NAME};
Review comment:
CoreModule has depended on TelemetryModule, I think.
##########
File path: oap-server/server-library/library-client/src/main/java/org/apache/skywalking/oap/server/library/client/healthcheck/HealthChecker.java
##########
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.library.client.healthcheck;
+
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+
+/**
+ * HealthChecker could provide health status to the listener.
+ */
+@Slf4j
+@RequiredArgsConstructor
+public class HealthChecker {
Review comment:
Also, based on the way you use this, it is likely, you should have this module up and running always.
I think we need a little more discussion about health checker model behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `22.13%`.
> The diff coverage is `20.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.23% 30.09% -22.14%
+ Complexity 2962 1725 -1237
=============================================
Files 779 757 -22
Lines 19525 18994 -531
Branches 1924 1870 -54
=============================================
- Hits 10198 5717 -4481
- Misses 8473 12837 +4364
+ Partials 854 440 -414
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `15.38% <0.00%> (-34.62%)` | `8.00 <0.00> (-5.00)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.63% <0.00%> (-60.59%)` | `2.00 <0.00> (-7.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [291 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `0.93%`.
> The diff coverage is `48.64%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.03% 52.09% -0.94%
+ Complexity 2987 2951 -36
============================================
Files 779 777 -2
Lines 19525 19587 +62
Branches 1924 1925 +1
============================================
- Hits 10355 10204 -151
- Misses 8309 8531 +222
+ Partials 861 852 -9
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `57.82% <42.64%> (-5.02%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `62.96% <50.00%> (+1.85%)` | `18.00 <1.00> (+1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <71.42%> (-1.22%)` | `9.00 <2.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `65.21% <71.42%> (-1.45%)` | `8.00 <2.00> (ø)` | |
| [...gin/influxdb/query/ProfileThreadSnapshotQuery.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeS5qYXZh) | `3.57% <0.00%> (-83.93%)` | `2.00% <0.00%> (-9.00%)` | |
| [...age/plugin/influxdb/query/ProfileTaskLogQuery.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGFza0xvZ1F1ZXJ5LmphdmE=) | `15.15% <0.00%> (-78.79%)` | `2.00% <0.00%> (-4.00%)` | |
| ... and [20 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...9f50fa8](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `10.97%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 53.08% 42.11% -10.98%
+ Complexity 2988 2282 -706
=============================================
Files 778 768 -10
Lines 19518 19317 -201
Branches 1924 1895 -29
=============================================
- Hits 10362 8136 -2226
- Misses 8297 10577 +2280
+ Partials 859 604 -255
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [162 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `1.88%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 51.20% -1.89%
+ Complexity 2988 2930 -58
============================================
Files 778 780 +2
Lines 19518 19568 +50
Branches 1924 1927 +3
============================================
- Hits 10362 10019 -343
- Misses 8297 8724 +427
+ Partials 859 825 -34
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
| [...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=) | `3.50% <0.00%> (-59.65%)` | `2.00% <0.00%> (-12.00%)` | |
| ... and [16 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **increase** coverage by `0.36%`.
> The diff coverage is `46.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 53.03% 53.39% +0.36%
- Complexity 2987 2990 +3
============================================
Files 779 777 -2
Lines 19525 19444 -81
Branches 1924 1916 -8
============================================
+ Hits 10355 10383 +28
+ Misses 8309 8199 -110
- Partials 861 862 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.59% <43.93%> (-4.26%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...ache/skywalking/apm/agent/core/util/FileUtils.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9GaWxlVXRpbHMuamF2YQ==) | | | |
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | | | |
| [.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh) | | | |
| [...apache/skywalking/apm/agent/core/util/IOUtils.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9JT1V0aWxzLmphdmE=) | | | |
| ... and [4 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `52.23%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.23% 0.00% -52.24%
============================================
Files 779 153 -626
Lines 19525 3801 -15724
Branches 1924 448 -1476
============================================
- Hits 10198 0 -10198
+ Misses 8473 3801 -4672
+ Partials 854 0 -854
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [744 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `4.56%`.
> The diff coverage is `44.76%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.23% 47.66% -4.57%
+ Complexity 2962 2692 -270
============================================
Files 779 756 -23
Lines 19525 18964 -561
Branches 1924 1862 -62
============================================
- Hits 10198 9039 -1159
- Misses 8473 9172 +699
+ Partials 854 753 -101
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `51.73% <32.35%> (-11.11%)` | `24.00 <3.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <2.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [82 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `14.49%`.
> The diff coverage is `48.64%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 53.03% 38.54% -14.50%
+ Complexity 2987 2167 -820
=============================================
Files 779 774 -5
Lines 19525 19503 -22
Branches 1924 1923 -1
=============================================
- Hits 10355 7517 -2838
- Misses 8309 11406 +3097
+ Partials 861 580 -281
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `57.82% <42.64%> (-5.02%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `62.96% <50.00%> (+1.85%)` | `18.00 <1.00> (+1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <71.42%> (-1.22%)` | `9.00 <2.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `65.21% <71.42%> (-1.45%)` | `8.00 <2.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [192 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...9f50fa8](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `19.27%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 53.03% 33.76% -19.28%
+ Complexity 2987 1876 -1111
=============================================
Files 779 746 -33
Lines 19525 18742 -783
Branches 1924 1837 -87
=============================================
- Hits 10355 6328 -4027
- Misses 8309 11905 +3596
+ Partials 861 509 -352
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [272 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `0.12%`.
> The diff coverage is `47.13%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.23% 52.10% -0.13%
Complexity 2962 2962
============================================
Files 779 782 +3
Lines 19525 19615 +90
Branches 1924 1926 +2
============================================
+ Hits 10198 10220 +22
- Misses 8473 8552 +79
+ Partials 854 843 -11
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.34% <36.76%> (-8.50%)` | `25.00 <3.00> (ø)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `58.51% <44.00%> (-6.30%)` | `17.00 <1.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <1.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `68.18% <100.00%> (+1.51%)` | `8.00 <1.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [22 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...929f455](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **increase** coverage by `0.91%`.
> The diff coverage is `47.79%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 52.23% 53.14% +0.91%
- Complexity 2962 2985 +23
============================================
Files 779 776 -3
Lines 19525 19526 +1
Branches 1924 1922 -2
============================================
+ Hits 10198 10377 +179
+ Misses 8473 8293 -180
- Partials 854 856 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.34% <36.76%> (-8.50%)` | `25.00 <3.00> (ø)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `58.51% <44.00%> (-6.30%)` | `17.00 <1.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <2.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `68.18% <100.00%> (+1.51%)` | `8.00 <2.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [17 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `15.57%`.
> The diff coverage is `40.65%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 53.03% 37.46% -15.58%
+ Complexity 2987 2064 -923
=============================================
Files 779 758 -21
Lines 19525 19070 -455
Branches 1924 1888 -36
=============================================
- Hits 10355 7144 -3211
- Misses 8309 11363 +3054
+ Partials 861 563 -298
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `53.47% <35.29%> (-9.37%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <71.42%> (-1.22%)` | `9.00 <2.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [219 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...9f50fa8](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `21.97%`.
> The diff coverage is `20.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.23% 30.25% -21.98%
+ Complexity 2962 1734 -1228
=============================================
Files 779 757 -22
Lines 19525 19002 -523
Branches 1924 1884 -40
=============================================
- Hits 10198 5749 -4449
- Misses 8473 12808 +4335
+ Partials 854 445 -409
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `15.38% <0.00%> (-34.62%)` | `8.00 <0.00> (-5.00)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.63% <0.00%> (-60.59%)` | `2.00 <0.00> (-7.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [280 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f&el=desc) will **decrease** coverage by `20.31%`.
> The diff coverage is `7.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.25% 31.93% -20.32%
+ Complexity 2963 1837 -1126
=============================================
Files 778 763 -15
Lines 19523 19108 -415
Branches 1924 1891 -33
=============================================
- Hits 10201 6102 -4099
- Misses 8472 12558 +4086
+ Partials 850 448 -402
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [233 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [ce2469d...2d3e245](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `16.93%`.
> The diff coverage is `20.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.23% 35.29% -16.94%
+ Complexity 2962 1979 -983
=============================================
Files 779 757 -22
Lines 19525 18962 -563
Branches 1924 1863 -61
=============================================
- Hits 10198 6692 -3506
- Misses 8473 11762 +3289
+ Partials 854 508 -346
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `15.38% <0.00%> (-34.62%)` | `8.00 <0.00> (-5.00)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.63% <0.00%> (-60.59%)` | `2.00 <0.00> (-7.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [221 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...929f455](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f&el=desc) will **decrease** coverage by `52.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.25% 0.00% -52.26%
============================================
Files 778 152 -626
Lines 19523 3826 -15697
Branches 1924 452 -1472
============================================
- Hits 10201 0 -10201
+ Misses 8472 3826 -4646
+ Partials 850 0 -850
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [744 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [ce2469d...2d3e245](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
hanahmily commented on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-660649698
@wu-sheng I enclose the gauge value into a new metric class, HealthCheckMetrics, so other developers don't have to set the value directly.
But when I try to move the initialization of the client to the start phase, some other module, for instance, CoreModule, complains they can't find the service provided by Storage modules. It seems we must keep the registration of storage service in the `prepare` phase. So I add a new DeletegatedHealthChecker as a final field of client classes, it can receive the HealthChecker created by Telemetry module, that's available in the start phase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `0.35%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 52.73% -0.36%
+ Complexity 2988 2977 -11
============================================
Files 778 780 +2
Lines 19518 19578 +60
Branches 1924 1928 +4
============================================
- Hits 10362 10324 -38
- Misses 8297 8399 +102
+ Partials 859 855 -4
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...age/plugin/elasticsearch/base/TimeSeriesUtils.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lU2VyaWVzVXRpbHMuamF2YQ==) | `57.69% <0.00%> (-3.85%)` | `8.00% <0.00%> (-1.00%)` | |
| ... and [7 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `52.22%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.22% 0.00% -52.23%
============================================
Files 779 161 -618
Lines 19525 4028 -15497
Branches 1924 483 -1441
============================================
- Hits 10196 0 -10196
+ Misses 8475 4028 -4447
+ Partials 854 0 -854
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [737 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **increase** coverage by `0.82%`.
> The diff coverage is `48.64%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 52.22% 53.04% +0.82%
- Complexity 2960 2990 +30
============================================
Files 779 780 +1
Lines 19525 19602 +77
Branches 1924 1925 +1
============================================
+ Hits 10196 10398 +202
+ Misses 8475 8342 -133
- Partials 854 862 +8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `57.82% <42.64%> (-5.02%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `62.96% <50.00%> (-1.86%)` | `18.00 <1.00> (ø)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <71.42%> (-1.22%)` | `9.00 <2.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `65.21% <71.42%> (-1.45%)` | `8.00 <2.00> (ø)` | |
| [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | | | |
| [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [10 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **increase** coverage by `0.17%`.
> The diff coverage is `47.13%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 52.23% 52.40% +0.17%
+ Complexity 2962 2961 -1
============================================
Files 779 776 -3
Lines 19525 19499 -26
Branches 1924 1904 -20
============================================
+ Hits 10198 10219 +21
+ Misses 8473 8437 -36
+ Partials 854 843 -11
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.34% <36.76%> (-8.50%)` | `25.00 <3.00> (ø)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `58.51% <44.00%> (-6.30%)` | `17.00 <1.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <1.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `68.18% <100.00%> (+1.51%)` | `8.00 <1.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [35 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...929f455](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f&el=desc) will **decrease** coverage by `52.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.25% 0.00% -52.26%
============================================
Files 778 151 -627
Lines 19523 3786 -15737
Branches 1924 448 -1476
============================================
- Hits 10201 0 -10201
+ Misses 8472 3786 -4686
+ Partials 850 0 -850
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [744 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [ce2469d...2d3e245](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **increase** coverage by `0.32%`.
> The diff coverage is `46.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 53.03% 53.36% +0.32%
Complexity 2987 2987
============================================
Files 779 777 -2
Lines 19525 19444 -81
Branches 1924 1916 -8
============================================
+ Hits 10355 10376 +21
+ Misses 8309 8206 -103
- Partials 861 862 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.59% <43.93%> (-4.26%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...storage/plugin/influxdb/base/HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0hpc3RvcnlEZWxldGVEQU8uamF2YQ==) | `33.33% <0.00%> (-33.34%)` | `2.00% <0.00%> (-1.00%)` | |
| [...p/server/storage/plugin/influxdb/InfluxClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9JbmZsdXhDbGllbnQuamF2YQ==) | `58.82% <0.00%> (-3.93%)` | `13.00% <0.00%> (-1.00%)` | |
| [...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==) | `50.83% <0.00%> (-0.84%)` | `10.00% <0.00%> (-1.00%)` | |
| [...ache/skywalking/apm/agent/core/util/FileUtils.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9GaWxlVXRpbHMuamF2YQ==) | | | |
| ... and [7 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f&el=desc) will **decrease** coverage by `21.15%`.
> The diff coverage is `7.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.25% 31.09% -21.16%
+ Complexity 2963 1785 -1178
=============================================
Files 778 762 -16
Lines 19523 19091 -432
Branches 1924 1891 -33
=============================================
- Hits 10201 5936 -4265
- Misses 8472 12707 +4235
+ Partials 850 448 -402
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [253 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [ce2469d...2d3e245](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `0.85%`.
> The diff coverage is `48.64%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.03% 52.18% -0.86%
+ Complexity 2987 2961 -26
============================================
Files 779 779
Lines 19525 19598 +73
Branches 1924 1925 +1
============================================
- Hits 10355 10227 -128
- Misses 8309 8517 +208
+ Partials 861 854 -7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `57.82% <42.64%> (-5.02%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `62.96% <50.00%> (+1.85%)` | `18.00 <1.00> (+1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <71.42%> (-1.22%)` | `9.00 <2.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `65.21% <71.42%> (-1.45%)` | `8.00 <2.00> (ø)` | |
| [...gin/influxdb/query/ProfileThreadSnapshotQuery.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeS5qYXZh) | `3.57% <0.00%> (-83.93%)` | `2.00% <0.00%> (-9.00%)` | |
| [...age/plugin/influxdb/query/ProfileTaskLogQuery.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGFza0xvZ1F1ZXJ5LmphdmE=) | `15.15% <0.00%> (-78.79%)` | `2.00% <0.00%> (-4.00%)` | |
| ... and [9 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...9f50fa8](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f&el=desc) will **decrease** coverage by `21.80%`.
> The diff coverage is `6.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.25% 30.44% -21.81%
+ Complexity 2963 1762 -1201
=============================================
Files 778 762 -16
Lines 19523 19084 -439
Branches 1924 1877 -47
=============================================
- Hits 10201 5810 -4391
- Misses 8472 12825 +4353
+ Partials 850 449 -401
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `11.36% <0.00%> (-80.31%)` | `3.00 <0.00> (-7.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `47.88% <37.50%> (-5.64%)` | `11.00 <1.00> (-2.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [276 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [ce2469d...2d3e245](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `53.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.03% 0.00% -53.04%
============================================
Files 779 162 -617
Lines 19525 4059 -15466
Branches 1924 483 -1441
============================================
- Hits 10355 0 -10355
+ Misses 8309 4059 -4250
+ Partials 861 0 -861
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [734 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...9f50fa8](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `1.74%`.
> The diff coverage is `44.76%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.23% 50.48% -1.75%
+ Complexity 2962 2828 -134
============================================
Files 779 758 -21
Lines 19525 19023 -502
Branches 1924 1869 -55
============================================
- Hits 10198 9603 -595
- Misses 8473 8617 +144
+ Partials 854 803 -51
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `51.73% <32.35%> (-11.11%)` | `24.00 <3.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <2.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| ... and [63 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **increase** coverage by `1.09%`.
> The diff coverage is `52.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 52.23% 53.32% +1.09%
- Complexity 2962 2992 +30
============================================
Files 779 776 -3
Lines 19525 19526 +1
Branches 1924 1922 -2
============================================
+ Hits 10198 10412 +214
+ Misses 8473 8255 -218
- Partials 854 859 +5
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.69% <44.11%> (-4.15%)` | `26.00 <3.00> (+1.00)` | :arrow_down: |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `62.96% <50.00%> (-1.86%)` | `18.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <2.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `68.18% <100.00%> (+1.51%)` | `8.00 <2.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [16 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `1.05%`.
> The diff coverage is `49.52%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.23% 51.17% -1.06%
+ Complexity 2962 2858 -104
============================================
Files 779 762 -17
Lines 19525 19146 -379
Branches 1924 1892 -32
============================================
- Hits 10198 9798 -400
- Misses 8473 8527 +54
+ Partials 854 821 -33
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `56.08% <39.70%> (-6.76%)` | `25.00 <3.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <2.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| ... and [52 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f&el=desc) will **decrease** coverage by `20.31%`.
> The diff coverage is `7.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.25% 31.94% -20.32%
+ Complexity 2963 1837 -1126
=============================================
Files 778 762 -16
Lines 19523 19104 -419
Branches 1924 1891 -33
=============================================
- Hits 10201 6102 -4099
- Misses 8472 12554 +4082
+ Partials 850 448 -402
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [234 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [ce2469d...2d3e245](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `23.39%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 53.08% 29.69% -23.40%
+ Complexity 2988 1710 -1278
=============================================
Files 778 759 -19
Lines 19518 19038 -480
Branches 1924 1876 -48
=============================================
- Hits 10362 5653 -4709
- Misses 8297 12947 +4650
+ Partials 859 438 -421
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [290 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `23.40%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 53.08% 29.68% -23.41%
+ Complexity 2988 1709 -1279
=============================================
Files 778 759 -19
Lines 19518 19038 -480
Branches 1924 1876 -48
=============================================
- Hits 10362 5651 -4711
- Misses 8297 12948 +4651
+ Partials 859 439 -420
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [290 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `18.83%`.
> The diff coverage is `20.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.23% 33.39% -18.84%
+ Complexity 2962 1879 -1083
=============================================
Files 779 757 -22
Lines 19525 18950 -575
Branches 1924 1863 -61
=============================================
- Hits 10198 6329 -3869
- Misses 8473 12115 +3642
+ Partials 854 506 -348
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `15.38% <0.00%> (-34.62%)` | `8.00 <0.00> (-5.00)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.63% <0.00%> (-60.59%)` | `2.00 <0.00> (-7.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [261 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...929f455](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `3.65%`.
> The diff coverage is `47.79%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.23% 48.57% -3.66%
+ Complexity 2962 2819 -143
============================================
Files 779 774 -5
Lines 19525 19469 -56
Branches 1924 1920 -4
============================================
- Hits 10198 9458 -740
- Misses 8473 9210 +737
+ Partials 854 801 -53
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.34% <36.76%> (-8.50%)` | `25.00 <3.00> (ø)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `58.51% <44.00%> (-6.30%)` | `17.00 <1.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <2.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `68.18% <100.00%> (+1.51%)` | `8.00 <2.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [52 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `0.65%`.
> The diff coverage is `49.52%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.23% 51.57% -0.66%
+ Complexity 2962 2880 -82
============================================
Files 779 762 -17
Lines 19525 19146 -379
Branches 1924 1892 -32
============================================
- Hits 10198 9874 -324
+ Misses 8473 8443 -30
+ Partials 854 829 -25
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `56.08% <39.70%> (-6.76%)` | `25.00 <3.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <2.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...elasticsearch/query/UITemplateManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVUlUZW1wbGF0ZU1hbmFnZW1lbnRFc0RBTy5qYXZh) | `6.12% <0.00%> (-65.31%)` | `2.00% <0.00%> (-5.00%)` | |
| ... and [48 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `0.83%`.
> The diff coverage is `49.52%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.23% 51.39% -0.84%
+ Complexity 2962 2871 -91
============================================
Files 779 762 -17
Lines 19525 19146 -379
Branches 1924 1892 -32
============================================
- Hits 10198 9841 -357
- Misses 8473 8482 +9
+ Partials 854 823 -31
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `56.08% <39.70%> (-6.76%)` | `25.00 <3.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <2.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...elasticsearch/query/UITemplateManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVUlUZW1wbGF0ZU1hbmFnZW1lbnRFc0RBTy5qYXZh) | `6.12% <0.00%> (-65.31%)` | `2.00% <0.00%> (-5.00%)` | |
| ... and [49 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `4.09%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.03% 48.94% -4.10%
+ Complexity 2987 2815 -172
============================================
Files 779 771 -8
Lines 19525 19272 -253
Branches 1924 1878 -46
============================================
- Hits 10355 9432 -923
- Misses 8309 9036 +727
+ Partials 861 804 -57
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [59 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `4.11%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.03% 48.92% -4.12%
+ Complexity 2987 2817 -170
============================================
Files 779 772 -7
Lines 19525 19284 -241
Branches 1924 1892 -32
============================================
- Hits 10355 9434 -921
- Misses 8309 9047 +738
+ Partials 861 803 -58
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [53 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f&el=desc) will **decrease** coverage by `21.15%`.
> The diff coverage is `7.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.25% 31.09% -21.16%
+ Complexity 2963 1785 -1178
=============================================
Files 778 762 -16
Lines 19523 19091 -432
Branches 1924 1891 -33
=============================================
- Hits 10201 5936 -4265
- Misses 8472 12707 +4235
+ Partials 850 448 -402
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [253 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [ce2469d...2d3e245](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `4.38%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.03% 48.64% -4.39%
+ Complexity 2987 2817 -170
============================================
Files 779 775 -4
Lines 19525 19392 -133
Branches 1924 1914 -10
============================================
- Hits 10355 9434 -921
- Misses 8309 9155 +846
+ Partials 861 803 -58
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [50 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `0.82%`.
> The diff coverage is `48.64%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.03% 52.21% -0.83%
+ Complexity 2987 2961 -26
============================================
Files 779 777 -2
Lines 19525 19587 +62
Branches 1924 1925 +1
============================================
- Hits 10355 10227 -128
- Misses 8309 8506 +197
+ Partials 861 854 -7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `57.82% <42.64%> (-5.02%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `62.96% <50.00%> (+1.85%)` | `18.00 <1.00> (+1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <71.42%> (-1.22%)` | `9.00 <2.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `65.21% <71.42%> (-1.45%)` | `8.00 <2.00> (ø)` | |
| [...gin/influxdb/query/ProfileThreadSnapshotQuery.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeS5qYXZh) | `3.57% <0.00%> (-83.93%)` | `2.00% <0.00%> (-9.00%)` | |
| [...age/plugin/influxdb/query/ProfileTaskLogQuery.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGFza0xvZ1F1ZXJ5LmphdmE=) | `15.15% <0.00%> (-78.79%)` | `2.00% <0.00%> (-4.00%)` | |
| ... and [11 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...9f50fa8](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **increase** coverage by `0.36%`.
> The diff coverage is `46.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 53.03% 53.39% +0.36%
- Complexity 2987 2990 +3
============================================
Files 779 777 -2
Lines 19525 19444 -81
Branches 1924 1916 -8
============================================
+ Hits 10355 10383 +28
+ Misses 8309 8199 -110
- Partials 861 862 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.59% <43.93%> (-4.26%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...apache/skywalking/apm/agent/core/util/IOUtils.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9JT1V0aWxzLmphdmE=) | | | |
| [.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh) | | | |
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | | | |
| [...ache/skywalking/apm/agent/core/util/FileUtils.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9GaWxlVXRpbHMuamF2YQ==) | | | |
| ... and [4 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `4.46%`.
> The diff coverage is `44.76%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.23% 47.76% -4.47%
+ Complexity 2962 2692 -270
============================================
Files 779 755 -24
Lines 19525 18924 -601
Branches 1924 1858 -66
============================================
- Hits 10198 9039 -1159
- Misses 8473 9132 +659
+ Partials 854 753 -101
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `51.73% <32.35%> (-11.11%)` | `24.00 <3.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <2.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [82 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `4.45%`.
> The diff coverage is `44.76%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.23% 47.77% -4.46%
+ Complexity 2962 2692 -270
============================================
Files 779 755 -24
Lines 19525 18918 -607
Branches 1924 1845 -79
============================================
- Hits 10198 9039 -1159
- Misses 8473 9126 +653
+ Partials 854 753 -101
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `51.73% <32.35%> (-11.11%)` | `24.00 <3.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <2.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [87 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `48.64%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 53.03% 53.04% +0.01%
- Complexity 2987 2990 +3
============================================
Files 779 780 +1
Lines 19525 19602 +77
Branches 1924 1925 +1
============================================
+ Hits 10355 10398 +43
- Misses 8309 8342 +33
- Partials 861 862 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `57.82% <42.64%> (-5.02%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `62.96% <50.00%> (+1.85%)` | `18.00 <1.00> (+1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <71.42%> (-1.22%)` | `9.00 <2.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `65.21% <71.42%> (-1.45%)` | `8.00 <2.00> (ø)` | |
| [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | | | |
| [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [2 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...9f50fa8](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `1.09%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 51.99% -1.10%
+ Complexity 2988 2954 -34
============================================
Files 778 780 +2
Lines 19518 19578 +60
Branches 1924 1928 +4
============================================
- Hits 10362 10180 -182
- Misses 8297 8556 +259
+ Partials 859 842 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=) | `3.50% <0.00%> (-59.65%)` | `2.00% <0.00%> (-12.00%)` | |
| [...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==) | `3.33% <0.00%> (-48.34%)` | `2.00% <0.00%> (-9.00%)` | |
| [...storage/plugin/influxdb/base/HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0hpc3RvcnlEZWxldGVEQU8uamF2YQ==) | `33.33% <0.00%> (-33.34%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [10 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `47.13%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.23% 52.22% -0.01%
+ Complexity 2962 2961 -1
============================================
Files 779 781 +2
Lines 19525 19568 +43
Branches 1924 1911 -13
============================================
+ Hits 10198 10219 +21
- Misses 8473 8506 +33
+ Partials 854 843 -11
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.34% <36.76%> (-8.50%)` | `25.00 <3.00> (ø)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `58.51% <44.00%> (-6.30%)` | `17.00 <1.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <1.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `68.18% <100.00%> (+1.51%)` | `8.00 <1.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [31 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...929f455](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `18.25%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 53.08% 34.83% -18.26%
+ Complexity 2988 1935 -1053
=============================================
Files 778 749 -29
Lines 19518 18860 -658
Branches 1924 1860 -64
=============================================
- Hits 10362 6569 -3793
- Misses 8297 11799 +3502
+ Partials 859 492 -367
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [239 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `21.87%`.
> The diff coverage is `20.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.23% 30.35% -21.88%
+ Complexity 2962 1742 -1220
=============================================
Files 779 757 -22
Lines 19525 19002 -523
Branches 1924 1884 -40
=============================================
- Hits 10198 5769 -4429
- Misses 8473 12787 +4314
+ Partials 854 446 -408
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `15.38% <0.00%> (-34.62%)` | `8.00 <0.00> (-5.00)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.63% <0.00%> (-60.59%)` | `2.00 <0.00> (-7.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [275 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **increase** coverage by `0.29%`.
> The diff coverage is `46.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 53.03% 53.33% +0.29%
+ Complexity 2987 2984 -3
============================================
Files 779 777 -2
Lines 19525 19444 -81
Branches 1924 1916 -8
============================================
+ Hits 10355 10370 +15
+ Misses 8309 8212 -97
- Partials 861 862 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.59% <43.93%> (-4.26%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...storage/plugin/influxdb/base/HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0hpc3RvcnlEZWxldGVEQU8uamF2YQ==) | `33.33% <0.00%> (-33.34%)` | `2.00% <0.00%> (-1.00%)` | |
| [...p/server/storage/plugin/influxdb/InfluxClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9JbmZsdXhDbGllbnQuamF2YQ==) | `58.82% <0.00%> (-3.93%)` | `13.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `91.86% <0.00%> (-2.33%)` | `9.00% <0.00%> (-2.00%)` | |
| [...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==) | `50.83% <0.00%> (-0.84%)` | `10.00% <0.00%> (-1.00%)` | |
| ... and [8 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `14.72%`.
> The diff coverage is `46.62%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 53.03% 38.30% -14.73%
+ Complexity 2987 2158 -829
=============================================
Files 779 774 -5
Lines 19525 19503 -22
Branches 1924 1923 -1
=============================================
- Hits 10355 7471 -2884
- Misses 8309 11460 +3151
+ Partials 861 572 -289
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `57.82% <42.64%> (-5.02%)` | `25.00 <2.00> (ø)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `51.11% <44.00%> (-10.00%)` | `14.00 <1.00> (-3.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <71.42%> (-1.22%)` | `9.00 <2.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `65.21% <71.42%> (-1.45%)` | `8.00 <2.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [196 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...9f50fa8](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `0.19%`.
> The diff coverage is `46.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 52.89% -0.20%
+ Complexity 2988 2984 -4
============================================
Files 778 780 +2
Lines 19518 19578 +60
Branches 1924 1928 +4
============================================
- Hits 10362 10355 -7
- Misses 8297 8365 +68
+ Partials 859 858 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.59% <43.93%> (-4.26%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | | | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [3 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f&el=desc) will **decrease** coverage by `21.14%`.
> The diff coverage is `7.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.25% 31.10% -21.15%
+ Complexity 2963 1785 -1178
=============================================
Files 778 760 -18
Lines 19523 19085 -438
Branches 1924 1891 -33
=============================================
- Hits 10201 5936 -4265
- Misses 8472 12701 +4229
+ Partials 850 448 -402
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [251 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [ce2469d...2d3e245](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `0.12%`.
> The diff coverage is `46.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 52.96% -0.13%
+ Complexity 2988 2984 -4
============================================
Files 778 1418 +640
Lines 19518 30774 +11256
Branches 1924 3419 +1495
============================================
+ Hits 10362 16299 +5937
- Misses 8297 13674 +5377
+ Partials 859 801 -58
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `57.82% <43.93%> (-5.02%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.38% <0.00%> (-65.92%)` | `1.00% <0.00%> (-7.00%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
| ... and [967 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `0.20%`.
> The diff coverage is `46.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 52.88% -0.21%
+ Complexity 2988 2984 -4
============================================
Files 778 781 +3
Lines 19518 19582 +64
Branches 1924 1928 +4
============================================
- Hits 10362 10355 -7
- Misses 8297 8369 +72
+ Partials 859 858 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.59% <43.93%> (-4.26%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [2 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `19.11%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 53.03% 33.92% -19.12%
+ Complexity 2987 1885 -1102
=============================================
Files 779 746 -33
Lines 19525 18742 -783
Branches 1924 1837 -87
=============================================
- Hits 10355 6358 -3997
- Misses 8309 11875 +3566
+ Partials 861 509 -352
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [266 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `52.23%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.23% 0.00% -52.24%
============================================
Files 779 151 -628
Lines 19525 3789 -15736
Branches 1924 448 -1476
============================================
- Hits 10198 0 -10198
+ Misses 8473 3789 -4684
+ Partials 854 0 -854
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [744 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `15.98%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 53.08% 37.10% -15.99%
+ Complexity 2988 2091 -897
=============================================
Files 778 775 -3
Lines 19518 19512 -6
Branches 1924 1926 +2
=============================================
- Hits 10362 7239 -3123
- Misses 8297 11741 +3444
+ Partials 859 532 -327
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [184 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f&el=desc) will **decrease** coverage by `52.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.25% 0.00% -52.26%
============================================
Files 778 154 -624
Lines 19523 3901 -15622
Branches 1924 467 -1457
============================================
- Hits 10201 0 -10201
+ Misses 8472 3901 -4571
+ Partials 850 0 -850
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [741 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [ce2469d...2d3e245](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `0.80%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 52.28% -0.81%
+ Complexity 2988 2948 -40
============================================
Files 778 773 -5
Lines 19518 19430 -88
Branches 1924 1909 -15
============================================
- Hits 10362 10159 -203
- Misses 8297 8429 +132
+ Partials 859 842 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
| [...ap/server/core/storage/ttl/DataTTLKeeperTimer.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS90dGwvRGF0YVRUTEtlZXBlclRpbWVyLmphdmE=) | `29.03% <0.00%> (-48.39%)` | `2.00% <0.00%> (-4.00%)` | |
| ... and [23 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `53.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 0.00% -53.09%
============================================
Files 778 151 -627
Lines 19518 3811 -15707
Branches 1924 451 -1473
============================================
- Hits 10362 0 -10362
+ Misses 8297 3811 -4486
+ Partials 859 0 -859
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [743 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `18.17%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 53.03% 34.86% -18.18%
+ Complexity 2987 1929 -1058
=============================================
Files 779 746 -33
Lines 19525 18754 -771
Branches 1924 1837 -87
=============================================
- Hits 10355 6538 -3817
- Misses 8309 11706 +3397
+ Partials 861 510 -351
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [246 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `0.53%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.03% 52.50% -0.54%
+ Complexity 2987 2960 -27
============================================
Files 779 777 -2
Lines 19525 19434 -91
Branches 1924 1915 -9
============================================
- Hits 10355 10203 -152
- Misses 8309 8387 +78
+ Partials 861 844 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
| [...ap/server/core/storage/ttl/DataTTLKeeperTimer.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS90dGwvRGF0YVRUTEtlZXBlclRpbWVyLmphdmE=) | `29.03% <0.00%> (-48.39%)` | `2.00% <0.00%> (-4.00%)` | |
| [...storage/plugin/influxdb/base/HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0hpc3RvcnlEZWxldGVEQU8uamF2YQ==) | `33.33% <0.00%> (-33.34%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [15 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **increase** coverage by `0.36%`.
> The diff coverage is `46.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 53.03% 53.39% +0.36%
- Complexity 2987 2990 +3
============================================
Files 779 777 -2
Lines 19525 19444 -81
Branches 1924 1916 -8
============================================
+ Hits 10355 10383 +28
+ Misses 8309 8199 -110
- Partials 861 862 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.59% <43.93%> (-4.26%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...ache/skywalking/apm/agent/core/util/FileUtils.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9GaWxlVXRpbHMuamF2YQ==) | | | |
| [...apache/skywalking/apm/agent/core/util/IOUtils.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9JT1V0aWxzLmphdmE=) | | | |
| [.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh) | | | |
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | | | |
| ... and [4 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f&el=desc) will **decrease** coverage by `21.33%`.
> The diff coverage is `7.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.25% 30.91% -21.34%
+ Complexity 2963 1785 -1178
=============================================
Files 778 762 -16
Lines 19523 19092 -431
Branches 1924 1891 -33
=============================================
- Hits 10201 5903 -4298
- Misses 8472 12743 +4271
+ Partials 850 446 -404
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [260 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [ce2469d...2d3e245](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f&el=desc) will **decrease** coverage by `21.53%`.
> The diff coverage is `7.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.25% 30.71% -21.54%
+ Complexity 2963 1779 -1184
=============================================
Files 778 762 -16
Lines 19523 19092 -431
Branches 1924 1891 -33
=============================================
- Hits 10201 5865 -4336
- Misses 8472 12778 +4306
+ Partials 850 449 -401
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [266 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [ce2469d...2d3e245](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `1.12%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 51.96% -1.13%
+ Complexity 2988 2948 -40
============================================
Files 778 776 -2
Lines 19518 19551 +33
Branches 1924 1927 +3
============================================
- Hits 10362 10159 -203
- Misses 8297 8550 +253
+ Partials 859 842 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
| [...ap/server/core/storage/ttl/DataTTLKeeperTimer.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS90dGwvRGF0YVRUTEtlZXBlclRpbWVyLmphdmE=) | `29.03% <0.00%> (-48.39%)` | `2.00% <0.00%> (-4.00%)` | |
| ... and [20 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **increase** coverage by `0.94%`.
> The diff coverage is `47.79%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 52.23% 53.17% +0.94%
- Complexity 2962 2985 +23
============================================
Files 779 774 -5
Lines 19525 19515 -10
Branches 1924 1922 -2
============================================
+ Hits 10198 10377 +179
+ Misses 8473 8282 -191
- Partials 854 856 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.34% <36.76%> (-8.50%)` | `25.00 <3.00> (ø)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `58.51% <44.00%> (-6.30%)` | `17.00 <1.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <2.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `68.18% <100.00%> (+1.51%)` | `8.00 <2.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [19 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f&el=desc) will **decrease** coverage by `20.32%`.
> The diff coverage is `7.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.25% 31.92% -20.33%
+ Complexity 2963 1837 -1126
=============================================
Files 778 765 -13
Lines 19523 19114 -409
Branches 1924 1891 -33
=============================================
- Hits 10201 6102 -4099
- Misses 8472 12564 +4092
+ Partials 850 448 -402
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [235 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [ce2469d...2d3e245](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `1.17%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 51.91% -1.18%
+ Complexity 2988 2948 -40
============================================
Files 778 780 +2
Lines 19518 19568 +50
Branches 1924 1927 +3
============================================
- Hits 10362 10159 -203
- Misses 8297 8567 +270
+ Partials 859 842 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
| [...ap/server/core/storage/ttl/DataTTLKeeperTimer.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS90dGwvRGF0YVRUTEtlZXBlclRpbWVyLmphdmE=) | `29.03% <0.00%> (-48.39%)` | `2.00% <0.00%> (-4.00%)` | |
| ... and [20 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#discussion_r454822740
##########
File path: oap-server/pom.xml
##########
@@ -64,7 +64,7 @@
<h2.version>1.4.196</h2.version>
<commons-dbcp.version>1.4</commons-dbcp.version>
<commons-io.version>2.6</commons-io.version>
- <elasticsearch.version>6.3.2</elasticsearch.version>
+ <elasticsearch.version>6.8.10</elasticsearch.version>
Review comment:
Could we don't do this? Once you did, I remember, you can't access 6.3-6.7 server any more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `46.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.03% 52.96% -0.08%
+ Complexity 2987 2984 -3
============================================
Files 779 1418 +639
Lines 19525 30774 +11249
Branches 1924 3419 +1495
============================================
+ Hits 10355 16299 +5944
- Misses 8309 13674 +5365
+ Partials 861 801 -60
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `57.82% <43.93%> (-5.02%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.38% <0.00%> (-65.92%)` | `1.00% <0.00%> (-7.00%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
| ... and [967 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `0.51%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.03% 52.51% -0.52%
+ Complexity 2987 2960 -27
============================================
Files 779 775 -4
Lines 19525 19428 -97
Branches 1924 1915 -9
============================================
- Hits 10355 10203 -152
- Misses 8309 8381 +72
+ Partials 861 844 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
| [...ap/server/core/storage/ttl/DataTTLKeeperTimer.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS90dGwvRGF0YVRUTEtlZXBlclRpbWVyLmphdmE=) | `29.03% <0.00%> (-48.39%)` | `2.00% <0.00%> (-4.00%)` | |
| [...storage/plugin/influxdb/base/HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0hpc3RvcnlEZWxldGVEQU8uamF2YQ==) | `33.33% <0.00%> (-33.34%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [17 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **increase** coverage by `0.36%`.
> The diff coverage is `46.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 53.03% 53.39% +0.36%
- Complexity 2987 2990 +3
============================================
Files 779 777 -2
Lines 19525 19444 -81
Branches 1924 1916 -8
============================================
+ Hits 10355 10383 +28
+ Misses 8309 8199 -110
- Partials 861 862 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.59% <43.93%> (-4.26%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | | | |
| [...ache/skywalking/apm/agent/core/util/FileUtils.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9GaWxlVXRpbHMuamF2YQ==) | | | |
| [...apache/skywalking/apm/agent/core/util/IOUtils.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9JT1V0aWxzLmphdmE=) | | | |
| [.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh) | | | |
| ... and [4 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f&el=desc) will **decrease** coverage by `52.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.25% 0.00% -52.26%
============================================
Files 778 160 -618
Lines 19523 3971 -15552
Branches 1924 476 -1448
============================================
- Hits 10201 0 -10201
+ Misses 8472 3971 -4501
+ Partials 850 0 -850
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [737 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [ce2469d...2d3e245](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `1.09%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 51.99% -1.10%
+ Complexity 2988 2955 -33
============================================
Files 778 780 +2
Lines 19518 19568 +50
Branches 1924 1927 +3
============================================
- Hits 10362 10174 -188
- Misses 8297 8552 +255
+ Partials 859 842 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
| [...ap/server/core/storage/ttl/DataTTLKeeperTimer.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS90dGwvRGF0YVRUTEtlZXBlclRpbWVyLmphdmE=) | `29.03% <0.00%> (-48.39%)` | `2.00% <0.00%> (-4.00%)` | |
| ... and [13 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `48.64%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.03% 53.00% -0.03%
Complexity 2987 2987
============================================
Files 779 779
Lines 19525 19598 +73
Branches 1924 1925 +1
============================================
+ Hits 10355 10388 +33
- Misses 8309 8347 +38
- Partials 861 863 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `57.82% <42.64%> (-5.02%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `62.96% <50.00%> (+1.85%)` | `18.00 <1.00> (+1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <71.42%> (-1.22%)` | `9.00 <2.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `65.21% <71.42%> (-1.45%)` | `8.00 <2.00> (ø)` | |
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `60.37% <0.00%> (-13.21%)` | `9.00% <0.00%> (-1.00%)` | |
| [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | |
| ... and [3 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...9f50fa8](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **increase** coverage by `2.89%`.
> The diff coverage is `48.64%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 50.15% 53.04% +2.89%
- Complexity 2897 2990 +93
============================================
Files 777 780 +3
Lines 19519 19602 +83
Branches 1924 1925 +1
============================================
+ Hits 9789 10398 +609
+ Misses 8911 8342 -569
- Partials 819 862 +43
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `57.82% <42.64%> (-1.20%)` | `25.00 <2.00> (+1.00)` | :arrow_down: |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `62.96% <50.00%> (-1.86%)` | `18.00 <1.00> (ø)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <71.42%> (-1.22%)` | `9.00 <2.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `65.21% <71.42%> (-1.45%)` | `8.00 <2.00> (ø)` | |
| [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | | | |
| [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [26 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...0525a4e](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `0.19%`.
> The diff coverage is `46.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 52.89% -0.20%
+ Complexity 2988 2984 -4
============================================
Files 778 780 +2
Lines 19518 19578 +60
Branches 1924 1928 +4
============================================
- Hits 10362 10355 -7
- Misses 8297 8365 +68
+ Partials 859 858 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.59% <43.93%> (-4.26%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | | | |
| ... and [3 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `53.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 0.00% -53.09%
============================================
Files 778 162 -616
Lines 19518 4021 -15497
Branches 1924 480 -1444
============================================
- Hits 10362 0 -10362
+ Misses 8297 4021 -4276
+ Partials 859 0 -859
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [736 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `12.54%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 53.08% 40.54% -12.55%
+ Complexity 2988 2185 -803
=============================================
Files 778 752 -26
Lines 19518 18917 -601
Branches 1924 1862 -62
=============================================
- Hits 10362 7669 -2693
- Misses 8297 10658 +2361
+ Partials 859 590 -269
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [188 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `52.23%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.23% 0.00% -52.24%
============================================
Files 779 149 -630
Lines 19525 3776 -15749
Branches 1924 447 -1477
============================================
- Hits 10198 0 -10198
+ Misses 8473 3776 -4697
+ Partials 854 0 -854
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [745 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `47.13%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=========================================
Coverage 52.23% 52.23%
+ Complexity 2962 2961 -1
=========================================
Files 779 780 +1
Lines 19525 19564 +39
Branches 1924 1911 -13
=========================================
+ Hits 10198 10219 +21
- Misses 8473 8502 +29
+ Partials 854 843 -11
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.34% <36.76%> (-8.50%)` | `25.00 <3.00> (ø)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `58.51% <44.00%> (-6.30%)` | `17.00 <1.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <1.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `68.18% <100.00%> (+1.51%)` | `8.00 <1.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [30 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...929f455](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `53.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.03% 0.00% -53.04%
============================================
Files 779 163 -616
Lines 19525 4064 -15461
Branches 1924 483 -1441
============================================
- Hits 10355 0 -10355
+ Misses 8309 4064 -4245
+ Partials 861 0 -861
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [733 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...9f50fa8](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `1.38%`.
> The diff coverage is `47.79%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.23% 50.84% -1.39%
+ Complexity 2962 2916 -46
============================================
Files 779 774 -5
Lines 19525 19505 -20
Branches 1924 1921 -3
============================================
- Hits 10198 9918 -280
- Misses 8473 8756 +283
+ Partials 854 831 -23
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.34% <36.76%> (-8.50%)` | `25.00 <3.00> (ø)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `58.51% <44.00%> (-6.30%)` | `17.00 <1.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <2.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `68.18% <100.00%> (+1.51%)` | `8.00 <2.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [28 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `48.64%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 53.03% 53.05% +0.02%
- Complexity 2987 2990 +3
============================================
Files 779 779
Lines 19525 19598 +73
Branches 1924 1925 +1
============================================
+ Hits 10355 10398 +43
- Misses 8309 8338 +29
- Partials 861 862 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `57.82% <42.64%> (-5.02%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `62.96% <50.00%> (+1.85%)` | `18.00 <1.00> (+1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <71.42%> (-1.22%)` | `9.00 <2.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `65.21% <71.42%> (-1.45%)` | `8.00 <2.00> (ø)` | |
| [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | | | |
| ... and [1 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...9f50fa8](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `17.47%`.
> The diff coverage is `47.61%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.23% 34.75% -17.48%
+ Complexity 2962 1948 -1014
=============================================
Files 779 757 -22
Lines 19525 19034 -491
Branches 1924 1886 -38
=============================================
- Hits 10198 6616 -3582
- Misses 8473 11928 +3455
+ Partials 854 490 -364
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `15.38% <0.00%> (-34.62%)` | `8.00 <0.00> (-5.00)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.34% <36.76%> (-8.50%)` | `25.00 <3.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <2.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [230 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **increase** coverage by `0.36%`.
> The diff coverage is `46.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 53.03% 53.39% +0.36%
- Complexity 2987 2990 +3
============================================
Files 779 777 -2
Lines 19525 19444 -81
Branches 1924 1916 -8
============================================
+ Hits 10355 10383 +28
+ Misses 8309 8199 -110
- Partials 861 862 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.59% <43.93%> (-4.26%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...apache/skywalking/apm/agent/core/util/IOUtils.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9JT1V0aWxzLmphdmE=) | | | |
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | | | |
| [...ache/skywalking/apm/agent/core/util/FileUtils.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9GaWxlVXRpbHMuamF2YQ==) | | | |
| [.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh) | | | |
| ... and [4 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `52.23%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.23% 0.00% -52.24%
============================================
Files 779 161 -618
Lines 19525 3984 -15541
Branches 1924 476 -1448
============================================
- Hits 10198 0 -10198
+ Misses 8473 3984 -4489
+ Partials 854 0 -854
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [736 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...929f455](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **increase** coverage by `0.36%`.
> The diff coverage is `46.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 53.03% 53.39% +0.36%
- Complexity 2987 2990 +3
============================================
Files 779 777 -2
Lines 19525 19444 -81
Branches 1924 1916 -8
============================================
+ Hits 10355 10383 +28
+ Misses 8309 8199 -110
- Partials 861 862 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.59% <43.93%> (-4.26%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | | | |
| [...ache/skywalking/apm/agent/core/util/FileUtils.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9GaWxlVXRpbHMuamF2YQ==) | | | |
| [...apache/skywalking/apm/agent/core/util/IOUtils.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9JT1V0aWxzLmphdmE=) | | | |
| [.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh) | | | |
| ... and [4 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `13.48%`.
> The diff coverage is `47.79%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.23% 38.74% -13.49%
+ Complexity 2962 2185 -777
=============================================
Files 779 773 -6
Lines 19525 19464 -61
Branches 1924 1920 -4
=============================================
- Hits 10198 7542 -2656
- Misses 8473 11359 +2886
+ Partials 854 563 -291
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `15.38% <0.00%> (-34.62%)` | `8.00 <0.00> (-5.00)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.34% <36.76%> (-8.50%)` | `25.00 <3.00> (ø)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `58.51% <44.00%> (-6.30%)` | `17.00 <1.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <2.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `68.18% <100.00%> (+1.51%)` | `8.00 <2.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [181 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f&el=desc) will **decrease** coverage by `52.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.25% 0.00% -52.26%
============================================
Files 778 159 -619
Lines 19523 3945 -15578
Branches 1924 471 -1453
============================================
- Hits 10201 0 -10201
+ Misses 8472 3945 -4527
+ Partials 850 0 -850
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [738 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [ce2469d...2d3e245](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#discussion_r456914367
##########
File path: oap-server/server-storage-plugin/storage-elasticsearch7-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch7/client/ElasticSearch7Client.java
##########
@@ -256,9 +292,9 @@ public void synchronousBulk(BulkRequest request) {
int size = request.requests().size();
BulkResponse responses = client.bulk(request, RequestOptions.DEFAULT);
log.info("Synchronous bulk took time: {} millis, size: {}", responses.getTook().getMillis(), size);
- } catch (IOException e) {
- log.error(e.getMessage(), e);
- }
+ healthChecker.health();
+ } catch (Throwable t) {
+ healthChecker.unHealth(t); }
Review comment:
This seems a format issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **increase** coverage by `0.36%`.
> The diff coverage is `46.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 53.03% 53.39% +0.36%
- Complexity 2987 2990 +3
============================================
Files 779 777 -2
Lines 19525 19444 -81
Branches 1924 1916 -8
============================================
+ Hits 10355 10383 +28
+ Misses 8309 8199 -110
- Partials 861 862 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.59% <43.93%> (-4.26%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...ache/skywalking/apm/agent/core/util/FileUtils.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9GaWxlVXRpbHMuamF2YQ==) | | | |
| [...apache/skywalking/apm/agent/core/util/IOUtils.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9JT1V0aWxzLmphdmE=) | | | |
| [.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh) | | | |
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | | | |
| ... and [4 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/62f76881de990917f229e5121e9094f977599da3&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `48.64%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.09% 53.04% -0.06%
+ Complexity 2993 2990 -3
============================================
Files 1419 780 -639
Lines 30727 19602 -11125
Branches 3419 1925 -1494
============================================
- Hits 16315 10398 -5917
+ Misses 13612 8342 -5270
- Partials 800 862 +62
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `57.82% <42.64%> (-4.34%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `62.96% <50.00%> (-1.86%)` | `18.00 <1.00> (ø)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <71.42%> (-1.22%)` | `9.00 <2.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `65.21% <71.42%> (-1.45%)` | `8.00 <2.00> (ø)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [971 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [62f7688...0cf9633](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `1.78%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 51.30% -1.79%
+ Complexity 2988 2930 -58
============================================
Files 778 779 +1
Lines 19518 19529 +11
Branches 1924 1926 +2
============================================
- Hits 10362 10019 -343
- Misses 8297 8685 +388
+ Partials 859 825 -34
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
| [...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=) | `3.50% <0.00%> (-59.65%)` | `2.00% <0.00%> (-12.00%)` | |
| ... and [17 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `18.43%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 53.08% 34.65% -18.44%
+ Complexity 2988 1926 -1062
=============================================
Files 778 747 -31
Lines 19518 18807 -711
Branches 1924 1842 -82
=============================================
- Hits 10362 6518 -3844
- Misses 8297 11798 +3501
+ Partials 859 491 -368
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [244 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `1.82%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 51.26% -1.83%
+ Complexity 2988 2927 -61
============================================
Files 778 777 -1
Lines 19518 19523 +5
Branches 1924 1926 +2
============================================
- Hits 10362 10009 -353
- Misses 8297 8688 +391
+ Partials 859 826 -33
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
| [...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=) | `3.50% <0.00%> (-59.65%)` | `2.00% <0.00%> (-12.00%)` | |
| ... and [21 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f&el=desc) will **decrease** coverage by `21.73%`.
> The diff coverage is `6.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.25% 30.51% -21.74%
+ Complexity 2963 1762 -1201
=============================================
Files 778 759 -19
Lines 19523 19037 -486
Branches 1924 1873 -51
=============================================
- Hits 10201 5810 -4391
- Misses 8472 12778 +4306
+ Partials 850 449 -401
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `11.36% <0.00%> (-80.31%)` | `3.00 <0.00> (-7.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `47.88% <37.50%> (-5.64%)` | `11.00 <1.00> (-2.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [279 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [ce2469d...2d3e245](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f&el=desc) will **decrease** coverage by `20.32%`.
> The diff coverage is `7.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.25% 31.92% -20.33%
+ Complexity 2963 1837 -1126
=============================================
Files 778 765 -13
Lines 19523 19114 -409
Branches 1924 1891 -33
=============================================
- Hits 10201 6102 -4099
- Misses 8472 12564 +4092
+ Partials 850 448 -402
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [235 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [ce2469d...2d3e245](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f&el=desc) will **decrease** coverage by `20.32%`.
> The diff coverage is `7.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.25% 31.92% -20.33%
+ Complexity 2963 1837 -1126
=============================================
Files 778 765 -13
Lines 19523 19114 -409
Branches 1924 1891 -33
=============================================
- Hits 10201 6102 -4099
- Misses 8472 12564 +4092
+ Partials 850 448 -402
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [235 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [ce2469d...2d3e245](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `1.10%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 51.98% -1.11%
+ Complexity 2988 2954 -34
============================================
Files 778 780 +2
Lines 19518 19568 +50
Branches 1924 1927 +3
============================================
- Hits 10362 10172 -190
- Misses 8297 8553 +256
+ Partials 859 843 -16
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
| [...ap/server/core/storage/ttl/DataTTLKeeperTimer.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS90dGwvRGF0YVRUTEtlZXBlclRpbWVyLmphdmE=) | `29.03% <0.00%> (-48.39%)` | `2.00% <0.00%> (-4.00%)` | |
| ... and [14 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `20.79%`.
> The diff coverage is `20.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.23% 31.43% -20.80%
+ Complexity 2962 1776 -1186
=============================================
Files 779 749 -30
Lines 19525 18779 -746
Branches 1924 1835 -89
=============================================
- Hits 10198 5904 -4294
- Misses 8473 12432 +3959
+ Partials 854 443 -411
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `15.38% <0.00%> (-34.62%)` | `8.00 <0.00> (-5.00)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.63% <0.00%> (-60.59%)` | `2.00 <0.00> (-7.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [274 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `48.64%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 53.03% 53.05% +0.02%
- Complexity 2987 2990 +3
============================================
Files 779 779
Lines 19525 19598 +73
Branches 1924 1925 +1
============================================
+ Hits 10355 10398 +43
- Misses 8309 8338 +29
- Partials 861 862 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `57.82% <42.64%> (-5.02%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `62.96% <50.00%> (+1.85%)` | `18.00 <1.00> (+1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <71.42%> (-1.22%)` | `9.00 <2.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `65.21% <71.42%> (-1.45%)` | `8.00 <2.00> (ø)` | |
| [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | | | |
| ... and [1 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...9f50fa8](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **increase** coverage by `0.16%`.
> The diff coverage is `52.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 52.23% 52.39% +0.16%
- Complexity 2962 2967 +5
============================================
Files 779 778 -1
Lines 19525 19576 +51
Branches 1924 1926 +2
============================================
+ Hits 10198 10257 +59
- Misses 8473 8474 +1
+ Partials 854 845 -9
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.69% <44.11%> (-4.15%)` | `26.00 <3.00> (+1.00)` | :arrow_down: |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `62.96% <50.00%> (-1.86%)` | `18.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <2.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `68.18% <100.00%> (+1.51%)` | `8.00 <2.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [20 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...929f455](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 52.83% -0.26%
+ Complexity 2988 2983 -5
============================================
Files 778 780 +2
Lines 19518 19578 +60
Branches 1924 1928 +4
============================================
- Hits 10362 10344 -18
- Misses 8297 8376 +79
+ Partials 859 858 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `49.73% <0.00%> (-0.53%)` | `10.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | | | |
| ... and [4 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `53.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.03% 0.00% -53.04%
============================================
Files 779 160 -619
Lines 19525 4047 -15478
Branches 1924 483 -1441
============================================
- Hits 10355 0 -10355
+ Misses 8309 4047 -4262
+ Partials 861 0 -861
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [734 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...9f50fa8](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `46.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 53.03% 53.12% +0.08%
- Complexity 2987 2990 +3
============================================
Files 779 1417 +638
Lines 19525 30733 +11208
Branches 1924 3421 +1497
============================================
+ Hits 10355 16326 +5971
- Misses 8309 13604 +5295
+ Partials 861 803 -58
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `57.82% <43.93%> (-5.02%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| ... and [969 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...9f50fa8](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `1.77%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 51.31% -1.78%
+ Complexity 2988 2930 -58
============================================
Files 778 777 -1
Lines 19518 19523 +5
Branches 1924 1926 +2
============================================
- Hits 10362 10019 -343
- Misses 8297 8679 +382
+ Partials 859 825 -34
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
| [...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=) | `3.50% <0.00%> (-59.65%)` | `2.00% <0.00%> (-12.00%)` | |
| ... and [19 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `14.78%`.
> The diff coverage is `11.36%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 53.03% 38.25% -14.79%
+ Complexity 2987 2144 -843
=============================================
Files 779 766 -13
Lines 19525 19197 -328
Branches 1924 1872 -52
=============================================
- Hits 10355 7343 -3012
- Misses 8309 11304 +2995
+ Partials 861 550 -311
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `13.75% <0.00%> (-52.47%)` | `3.00 <0.00> (-6.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `16.74% <3.03%> (-46.11%)` | `8.00 <1.00> (-17.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [201 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `13.63%`.
> The diff coverage is `47.61%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.23% 38.59% -13.64%
+ Complexity 2962 2134 -828
=============================================
Files 779 757 -22
Lines 19525 19034 -491
Branches 1924 1886 -38
=============================================
- Hits 10198 7347 -2851
- Misses 8473 11135 +2662
+ Partials 854 552 -302
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `15.38% <0.00%> (-34.62%)` | `8.00 <0.00> (-5.00)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.34% <36.76%> (-8.50%)` | `25.00 <3.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <2.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [193 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `17.81%`.
> The diff coverage is `11.36%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 53.08% 35.27% -17.82%
+ Complexity 2988 2020 -968
=============================================
Files 778 775 -3
Lines 19518 19512 -6
Branches 1924 1926 +2
=============================================
- Hits 10362 6882 -3480
- Misses 8297 12117 +3820
+ Partials 859 513 -346
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `13.75% <0.00%> (-52.47%)` | `3.00 <0.00> (-6.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `16.74% <3.03%> (-46.11%)` | `8.00 <1.00> (-17.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [200 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `18.72%`.
> The diff coverage is `11.36%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 53.08% 34.36% -18.73%
+ Complexity 2988 1983 -1005
=============================================
Files 778 775 -3
Lines 19518 19509 -9
Branches 1924 1926 +2
=============================================
- Hits 10362 6705 -3657
- Misses 8297 12292 +3995
+ Partials 859 512 -347
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `13.75% <0.00%> (-52.47%)` | `3.00 <0.00> (-6.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `16.74% <3.03%> (-46.11%)` | `8.00 <1.00> (-17.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [222 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f&el=desc) will **decrease** coverage by `20.32%`.
> The diff coverage is `7.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.25% 31.92% -20.33%
+ Complexity 2963 1837 -1126
=============================================
Files 778 765 -13
Lines 19523 19114 -409
Branches 1924 1891 -33
=============================================
- Hits 10201 6102 -4099
- Misses 8472 12564 +4092
+ Partials 850 448 -402
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [235 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [ce2469d...2d3e245](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `12.46%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 53.08% 40.62% -12.47%
+ Complexity 2988 2236 -752
=============================================
Files 778 768 -10
Lines 19518 19317 -201
Branches 1924 1895 -29
=============================================
- Hits 10362 7848 -2514
- Misses 8297 10868 +2571
+ Partials 859 601 -258
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [173 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f&el=desc) will **decrease** coverage by `52.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.25% 0.00% -52.26%
============================================
Files 778 150 -628
Lines 19523 3796 -15727
Branches 1924 463 -1461
============================================
- Hits 10201 0 -10201
+ Misses 8472 3796 -4676
+ Partials 850 0 -850
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [743 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [ce2469d...2d3e245](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `0.19%`.
> The diff coverage is `46.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 52.89% -0.20%
+ Complexity 2988 2984 -4
============================================
Files 778 780 +2
Lines 19518 19578 +60
Branches 1924 1928 +4
============================================
- Hits 10362 10355 -7
- Misses 8297 8365 +68
+ Partials 859 858 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.59% <43.93%> (-4.26%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | | | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [3 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f&el=desc) will **decrease** coverage by `21.73%`.
> The diff coverage is `6.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.25% 30.51% -21.74%
+ Complexity 2963 1762 -1201
=============================================
Files 778 760 -18
Lines 19523 19042 -481
Branches 1924 1873 -51
=============================================
- Hits 10201 5810 -4391
- Misses 8472 12783 +4311
+ Partials 850 449 -401
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `11.36% <0.00%> (-80.31%)` | `3.00 <0.00> (-7.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `47.88% <37.50%> (-5.64%)` | `11.00 <1.00> (-2.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [278 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [ce2469d...2d3e245](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `48.64%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.03% 52.99% -0.04%
+ Complexity 2987 2985 -2
============================================
Files 779 779
Lines 19525 19598 +73
Branches 1924 1925 +1
============================================
+ Hits 10355 10386 +31
- Misses 8309 8349 +40
- Partials 861 863 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `57.82% <42.64%> (-5.02%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `62.96% <50.00%> (+1.85%)` | `18.00 <1.00> (+1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <71.42%> (-1.22%)` | `9.00 <2.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `65.21% <71.42%> (-1.45%)` | `8.00 <2.00> (ø)` | |
| [...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `60.37% <0.00%> (-13.21%)` | `9.00% <0.00%> (-1.00%)` | |
| ... and [4 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...9f50fa8](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `1.75%`.
> The diff coverage is `44.76%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.23% 50.47% -1.76%
+ Complexity 2962 2827 -135
============================================
Files 779 758 -21
Lines 19525 19023 -502
Branches 1924 1869 -55
============================================
- Hits 10198 9602 -596
- Misses 8473 8617 +144
+ Partials 854 804 -50
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `51.73% <32.35%> (-11.11%)` | `24.00 <3.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <2.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| ... and [62 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **increase** coverage by `0.36%`.
> The diff coverage is `46.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 53.03% 53.39% +0.36%
- Complexity 2987 2990 +3
============================================
Files 779 777 -2
Lines 19525 19444 -81
Branches 1924 1916 -8
============================================
+ Hits 10355 10383 +28
+ Misses 8309 8199 -110
- Partials 861 862 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.59% <43.93%> (-4.26%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...apache/skywalking/apm/agent/core/util/IOUtils.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9JT1V0aWxzLmphdmE=) | | | |
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | | | |
| [...ache/skywalking/apm/agent/core/util/FileUtils.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9GaWxlVXRpbHMuamF2YQ==) | | | |
| [.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh) | | | |
| ... and [4 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `17.39%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 53.03% 35.64% -17.40%
+ Complexity 2987 1975 -1012
=============================================
Files 779 746 -33
Lines 19525 18754 -771
Branches 1924 1837 -87
=============================================
- Hits 10355 6684 -3671
- Misses 8309 11559 +3250
+ Partials 861 511 -350
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [235 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `3.97%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.03% 49.06% -3.98%
+ Complexity 2987 2815 -172
============================================
Files 779 768 -11
Lines 19525 19225 -300
Branches 1924 1874 -50
============================================
- Hits 10355 9432 -923
- Misses 8309 8989 +680
+ Partials 861 804 -57
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [62 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...0ea856b](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f&el=desc) will **decrease** coverage by `22.26%`.
> The diff coverage is `7.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.25% 29.98% -22.27%
+ Complexity 2963 1714 -1249
=============================================
Files 778 755 -23
Lines 19523 18933 -590
Branches 1924 1879 -45
=============================================
- Hits 10201 5677 -4524
- Misses 8472 12819 +4347
+ Partials 850 437 -413
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [290 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [ce2469d...2d3e245](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `17.70%`.
> The diff coverage is `20.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 52.23% 34.52% -17.71%
+ Complexity 2962 1933 -1029
=============================================
Files 779 757 -22
Lines 19525 18962 -563
Branches 1924 1863 -61
=============================================
- Hits 10198 6546 -3652
- Misses 8473 11909 +3436
+ Partials 854 507 -347
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `15.38% <0.00%> (-34.62%)` | `8.00 <0.00> (-5.00)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.63% <0.00%> (-60.59%)` | `2.00 <0.00> (-7.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [232 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...929f455](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `0.19%`.
> The diff coverage is `46.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 52.89% -0.20%
+ Complexity 2988 2984 -4
============================================
Files 778 780 +2
Lines 19518 19578 +60
Branches 1924 1928 +4
============================================
- Hits 10362 10355 -7
- Misses 8297 8365 +68
+ Partials 859 858 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.59% <43.93%> (-4.26%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | | | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [3 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `52.23%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.23% 0.00% -52.24%
============================================
Files 779 150 -629
Lines 19525 3799 -15726
Branches 1924 463 -1461
============================================
- Hits 10198 0 -10198
+ Misses 8473 3799 -4674
+ Partials 854 0 -854
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [743 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...929f455](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `1.02%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 52.06% -1.03%
+ Complexity 2988 2948 -40
============================================
Files 778 775 -3
Lines 19518 19512 -6
Branches 1924 1926 +2
============================================
- Hits 10362 10159 -203
- Misses 8297 8511 +214
+ Partials 859 842 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
| [...ap/server/core/storage/ttl/DataTTLKeeperTimer.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS90dGwvRGF0YVRUTEtlZXBlclRpbWVyLmphdmE=) | `29.03% <0.00%> (-48.39%)` | `2.00% <0.00%> (-4.00%)` | |
| ... and [21 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc&el=desc) will **decrease** coverage by `13.76%`.
> The diff coverage is `48.64%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
=============================================
- Coverage 53.03% 39.26% -13.77%
+ Complexity 2987 2201 -786
=============================================
Files 779 775 -4
Lines 19525 19545 +20
Branches 1924 1924
=============================================
- Hits 10355 7675 -2680
- Misses 8309 11288 +2979
+ Partials 861 582 -279
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `57.82% <42.64%> (-5.02%)` | `25.00 <2.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `62.96% <50.00%> (+1.85%)` | `18.00 <1.00> (+1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <71.42%> (-1.22%)` | `9.00 <2.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `65.21% <71.42%> (-1.45%)` | `8.00 <2.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [174 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [9372e11...9f50fa8](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `4.45%`.
> The diff coverage is `44.76%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.23% 47.77% -4.46%
+ Complexity 2962 2692 -270
============================================
Files 779 755 -24
Lines 19525 18916 -609
Branches 1924 1844 -80
============================================
- Hits 10198 9038 -1160
- Misses 8473 9125 +652
+ Partials 854 753 -101
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `51.73% <32.35%> (-11.11%)` | `24.00 <3.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <2.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [89 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...a6843b0](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **increase** coverage by `0.83%`.
> The diff coverage is `52.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 52.23% 53.06% +0.83%
- Complexity 2962 2992 +30
============================================
Files 779 781 +2
Lines 19525 19621 +96
Branches 1924 1927 +3
============================================
+ Hits 10198 10411 +213
+ Misses 8473 8353 -120
- Partials 854 857 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.69% <44.11%> (-4.15%)` | `26.00 <3.00> (+1.00)` | :arrow_down: |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `62.96% <50.00%> (-1.86%)` | `18.00 <1.00> (ø)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <2.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `68.18% <100.00%> (+1.51%)` | `8.00 <2.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [13 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...929f455](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **increase** coverage by `0.28%`.
> The diff coverage is `47.13%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
+ Coverage 52.23% 52.51% +0.28%
+ Complexity 2962 2961 -1
============================================
Files 779 775 -4
Lines 19525 19459 -66
Branches 1924 1900 -24
============================================
+ Hits 10198 10219 +21
+ Misses 8473 8397 -76
+ Partials 854 843 -11
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `46.15% <0.00%> (-3.85%)` | `13.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.34% <36.76%> (-8.50%)` | `25.00 <3.00> (ø)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `58.51% <44.00%> (-6.30%)` | `17.00 <1.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <55.55%> (-2.82%)` | `12.00 <1.00> (-1.00)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <70.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...ary/client/healthcheck/DelegatedHealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0RlbGVnYXRlZEhlYWx0aENoZWNrZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.53% <100.00%> (+1.31%)` | `9.00 <1.00> (ø)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `68.18% <100.00%> (+1.51%)` | `8.00 <1.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `95.34% <100.00%> (+3.68%)` | `9.00 <0.00> (-1.00)` | :arrow_up: |
| [...lking/oap/server/telemetry/api/MetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL01ldHJpY3NDcmVhdG9yLmphdmE=) | `28.57% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [35 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...929f455](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/977062bafba6289df14e252aab803e0008c26ef4&el=desc) will **decrease** coverage by `52.23%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 52.23% 0.00% -52.24%
============================================
Files 779 160 -619
Lines 19525 3979 -15546
Branches 1924 476 -1448
============================================
- Hits 10198 0 -10198
+ Misses 8473 3979 -4494
+ Partials 854 0 -854
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (-13.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [737 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [977062b...929f455](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e356da4b0e264a7617b3356febe6d6e25361f20a&el=desc) will **decrease** coverage by `0.49%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.08% 52.59% -0.50%
+ Complexity 2988 2948 -40
============================================
Files 778 768 -10
Lines 19518 19317 -201
Branches 1924 1895 -29
============================================
- Hits 10362 10159 -203
- Misses 8297 8316 +19
+ Partials 859 842 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.18% <36.36%> (-8.66%)` | `24.00 <2.00> (-1.00)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
| [...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `65.00% <66.66%> (-1.22%)` | `9.00 <1.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
| [...ap/server/core/storage/ttl/DataTTLKeeperTimer.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS90dGwvRGF0YVRUTEtlZXBlclRpbWVyLmphdmE=) | `29.03% <0.00%> (-48.39%)` | `2.00% <0.00%> (-4.00%)` | |
| ... and [29 more](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=footer). Last update [e356da4...17a2b93](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org