You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2023/06/28 06:53:57 UTC
[superset] branch master updated: feat(tags): move tags from navbar to settings (#24518)
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new a846e8a58d feat(tags): move tags from navbar to settings (#24518)
a846e8a58d is described below
commit a846e8a58d21f6e854e2b970c4878782d2ac9356
Author: Hugh A. Miles II <hu...@gmail.com>
AuthorDate: Wed Jun 28 02:53:49 2023 -0400
feat(tags): move tags from navbar to settings (#24518)
Co-authored-by: Daniel Vaz Gaspar <da...@gmail.com>
---
superset/charts/commands/warm_up_cache.py | 1 -
superset/databases/api.py | 4 +---
superset/datasets/commands/warm_up_cache.py | 1 -
superset/initialization/__init__.py | 11 ++---------
4 files changed, 3 insertions(+), 14 deletions(-)
diff --git a/superset/charts/commands/warm_up_cache.py b/superset/charts/commands/warm_up_cache.py
index 6fe9f94ffa..97d5c4fe1e 100644
--- a/superset/charts/commands/warm_up_cache.py
+++ b/superset/charts/commands/warm_up_cache.py
@@ -30,7 +30,6 @@ from superset.views.utils import get_dashboard_extra_filters, get_form_data, get
class ChartWarmUpCacheCommand(BaseCommand):
- # pylint: disable=too-many-arguments
def __init__(
self,
chart_or_id: Union[int, Slice],
diff --git a/superset/databases/api.py b/superset/databases/api.py
index 8f7569af92..98932e28e2 100644
--- a/superset/databases/api.py
+++ b/superset/databases/api.py
@@ -383,9 +383,7 @@ class DatabaseRestApi(BaseSupersetModelRestApi):
# Return SSH Tunnel and hide passwords if any
if item.get("ssh_tunnel"):
- item["ssh_tunnel"] = mask_password_info(
- new_model.ssh_tunnel # pylint: disable=no-member
- )
+ item["ssh_tunnel"] = mask_password_info(new_model.ssh_tunnel)
return self.response(201, id=new_model.id, result=item)
except DatabaseInvalidError as ex:
diff --git a/superset/datasets/commands/warm_up_cache.py b/superset/datasets/commands/warm_up_cache.py
index 62044e7224..64becc9cd6 100644
--- a/superset/datasets/commands/warm_up_cache.py
+++ b/superset/datasets/commands/warm_up_cache.py
@@ -28,7 +28,6 @@ from superset.models.slice import Slice
class DatasetWarmUpCacheCommand(BaseCommand):
- # pylint: disable=too-many-arguments
def __init__(
self,
db_name: str,
diff --git a/superset/initialization/__init__.py b/superset/initialization/__init__.py
index 3d7d9817f7..6354606006 100644
--- a/superset/initialization/__init__.py
+++ b/superset/initialization/__init__.py
@@ -156,7 +156,7 @@ class SupersetAppInitializer: # pylint: disable=too-many-public-methods
from superset.sqllab.api import SqlLabRestApi
from superset.tags.api import TagRestApi
from superset.views.alerts import AlertView, ReportView
- from superset.views.all_entities import TaggedObjectsModelView, TaggedObjectView
+ from superset.views.all_entities import TaggedObjectView
from superset.views.annotations import AnnotationLayerView
from superset.views.api import Api
from superset.views.chart.views import SliceAsync, SliceModelView
@@ -366,20 +366,13 @@ class SupersetAppInitializer: # pylint: disable=too-many-public-methods
category="SQL Lab",
category_label=__("SQL Lab"),
)
- appbuilder.add_view(
- TaggedObjectsModelView,
- "All Entities",
- label=__("All Entities"),
- icon="",
- category_icon="",
- menu_cond=lambda: feature_flag_manager.is_feature_enabled("TAGGING_SYSTEM"),
- )
appbuilder.add_view(
TagModelView,
"Tags",
label=__("Tags"),
icon="",
category_icon="",
+ category="Manage",
menu_cond=lambda: feature_flag_manager.is_feature_enabled("TAGGING_SYSTEM"),
)
appbuilder.add_api(LogRestApi)