You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by tk...@apache.org on 2024/03/22 07:57:35 UTC

(incubator-kie-drools) branch dev-new-parser updated: [incubator-kie-drools#5710] [new-parser] Unable to resolve method (from new) in a query (#5795)

This is an automated email from the ASF dual-hosted git repository.

tkobayas pushed a commit to branch dev-new-parser
in repository https://gitbox.apache.org/repos/asf/incubator-kie-drools.git


The following commit(s) were added to refs/heads/dev-new-parser by this push:
     new 609a3361e4 [incubator-kie-drools#5710] [new-parser] Unable to resolve method (from new) in a query (#5795)
609a3361e4 is described below

commit 609a3361e4330c1870bafe450639a3c4d5eeb447
Author: Toshiya Kobayashi <to...@gmail.com>
AuthorDate: Fri Mar 22 16:57:29 2024 +0900

    [incubator-kie-drools#5710] [new-parser] Unable to resolve method (from new) in a query (#5795)
---
 .../org/drools/drl/parser/antlr4/MiscDRLParserTest.java   | 15 +++++++++++++++
 .../java/org/drools/drl/parser/antlr4/DRLVisitorImpl.java |  2 +-
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/drools-drl/drools-drl-parser-tests/src/test/java/org/drools/drl/parser/antlr4/MiscDRLParserTest.java b/drools-drl/drools-drl-parser-tests/src/test/java/org/drools/drl/parser/antlr4/MiscDRLParserTest.java
index ebc86082aa..59dadb6598 100644
--- a/drools-drl/drools-drl-parser-tests/src/test/java/org/drools/drl/parser/antlr4/MiscDRLParserTest.java
+++ b/drools-drl/drools-drl-parser-tests/src/test/java/org/drools/drl/parser/antlr4/MiscDRLParserTest.java
@@ -3755,4 +3755,19 @@ class MiscDRLParserTest {
         assertThat(annotationDescr.getName()).isEqualTo("watch");
         assertThat(annotationDescr.getSingleValueAsString()).isEqualTo("!*, age");
     }
+
+    @Test
+    void fromNew() {
+        final String text = "package org.drools\n" +
+                "rule R1\n" +
+                "when\n" +
+                "    $p : Person() from new Person(\"John\", 30)\n" +
+                "then\n" +
+                "end\n";
+        PackageDescr packageDescr = parser.parse(text);
+        RuleDescr ruleDescr = packageDescr.getRules().get(0);
+        PatternDescr patternDescr = (PatternDescr) ruleDescr.getLhs().getDescrs().get(0);
+        FromDescr fromDescr = (FromDescr) patternDescr.getSource();
+        assertThat(fromDescr.getDataSource().toString()).isEqualTo("new Person(\"John\", 30)");
+    }
 }
diff --git a/drools-drl/drools-drl-parser/src/main/java/org/drools/drl/parser/antlr4/DRLVisitorImpl.java b/drools-drl/drools-drl-parser/src/main/java/org/drools/drl/parser/antlr4/DRLVisitorImpl.java
index 42205cebc9..6efefc7e60 100644
--- a/drools-drl/drools-drl-parser/src/main/java/org/drools/drl/parser/antlr4/DRLVisitorImpl.java
+++ b/drools-drl/drools-drl-parser/src/main/java/org/drools/drl/parser/antlr4/DRLVisitorImpl.java
@@ -548,7 +548,7 @@ public class DRLVisitorImpl extends DRLParserBaseVisitor<Object> {
     @Override
     public FromDescr visitFromExpression(DRLParser.FromExpressionContext ctx) {
         FromDescr fromDescr = new FromDescr();
-        fromDescr.setDataSource(new MVELExprDescr(ctx.getText()));
+        fromDescr.setDataSource(new MVELExprDescr(getTextPreservingWhitespace(ctx)));
         return fromDescr;
     }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org