You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Hang Chen <ch...@apache.org> on 2022/11/21 12:02:11 UTC

[VOTE] Release 4.14.6, release candidate #0

Hi everyone,
Please review and vote on the release candidate #0 for version 4.14.6,
as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

The complete staging area is available for your review, which includes:
* Release notes [1]
* The official Apache source and binary distributions to be deployed to
dist.apache.org [2]
* All artifacts to be deployed to the Maven Central Repository [3]
* Source code tag "v4.14.6-rc0" [4] with git sha [5]

BookKeeper's KEYS file contains the PGP keys we used to sign this release:
https://dist.apache.org/repos/dist/release/bookkeeper/KEYS

Please download these packages and review this release candidate:

- Review release notes
- Download the source package (verify shasum, and asc) and follow the
instructions to build and run the bookkeeper service.
- Download the binary package (verify shasum, and asc) and follow the
instructions to run the bookkeeper service.
- Review the maven repo, release tag, licenses, and any other things you think
it is important to release.

The vote will be open for at least 72 hours. It is adopted by the majority
approval, with at least 3 PMC affirmative votes.

Thanks,
Release Manager

[1] https://github.com/apache/bookkeeper/pull/3659/files
[2] https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.14.6-rc0/
[3] https://repository.apache.org/content/repositories/orgapachebookkeeper-1076/
[4] https://github.com/apache/bookkeeper/tree/v4.14.6-rc0
[5] 9f453834c6039fac46dc19130288dbf0b2996f2e

Re: [VOTE] Release 4.14.6, release candidate #0

Posted by Enrico Olivelli <eo...@gmail.com>.
Chen,
I saw on repository.apache.org that we still have a dangling staging
repository for this RC

I have dropped it

Enrico

Il giorno lun 19 dic 2022 alle ore 06:12 Hang Chen
<ch...@apache.org> ha scritto:
>
> Hi guys,
>      One issue is the direct memory metric, incompatible with JDK8
> introduced by [1] and fixed by [2]. I will close this vote and create
> a new candidate soon.
>
> Thanks,
> Hang
>
> [1] https://github.com/apache/bookkeeper/pull/3252
> [2] https://github.com/apache/bookkeeper/pull/3677
>
> Enrico Olivelli <eo...@gmail.com> 于2022年12月19日周一 05:20写道:
> >
> > +1 (binding)
> >
> > Enrico
> >
> > Il giorno gio 1 dic 2022 alle ore 07:30 Yong Zhang
> > <zh...@gmail.com> ha scritto:
> > >
> > > okay. Make sense.
> > >
> > > --
> > > Yong
> > >
> > > On Thu, 1 Dec 2022 at 07:52, Andrey Yegorov <an...@datastax.com>
> > > wrote:
> > >
> > > > +1 (binding)
> > > >
> > > > * ran bookkeeper standalone
> > > > * ran bookkeeper localbookie
> > > > * built from sources (mac, intel), ran some tests
> > > > * spot-checked maven repo
> > > >
> > > > @Yong - as I understand, build on M1 is not a regression for 4.14.x so it
> > > > should not be a blocker.
> > > >
> > > > On Mon, Nov 21, 2022 at 4:03 AM Hang Chen <ch...@apache.org> wrote:
> > > >
> > > > > Hi everyone,
> > > > > Please review and vote on the release candidate #0 for version 4.14.6,
> > > > > as follows:
> > > > > [ ] +1, Approve the release
> > > > > [ ] -1, Do not approve the release (please provide specific comments)
> > > > >
> > > > > The complete staging area is available for your review, which includes:
> > > > > * Release notes [1]
> > > > > * The official Apache source and binary distributions to be deployed to
> > > > > dist.apache.org [2]
> > > > > * All artifacts to be deployed to the Maven Central Repository [3]
> > > > > * Source code tag "v4.14.6-rc0" [4] with git sha [5]
> > > > >
> > > > > BookKeeper's KEYS file contains the PGP keys we used to sign this
> > > > release:
> > > > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> > > > >
> > > > > Please download these packages and review this release candidate:
> > > > >
> > > > > - Review release notes
> > > > > - Download the source package (verify shasum, and asc) and follow the
> > > > > instructions to build and run the bookkeeper service.
> > > > > - Download the binary package (verify shasum, and asc) and follow the
> > > > > instructions to run the bookkeeper service.
> > > > > - Review the maven repo, release tag, licenses, and any other things you
> > > > > think
> > > > > it is important to release.
> > > > >
> > > > > The vote will be open for at least 72 hours. It is adopted by the
> > > > majority
> > > > > approval, with at least 3 PMC affirmative votes.
> > > > >
> > > > > Thanks,
> > > > > Release Manager
> > > > >
> > > > > [1] https://github.com/apache/bookkeeper/pull/3659/files
> > > > > [2]
> > > > > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.14.6-rc0/
> > > > > [3]
> > > > >
> > > > https://repository.apache.org/content/repositories/orgapachebookkeeper-1076/
> > > > > [4] https://github.com/apache/bookkeeper/tree/v4.14.6-rc0
> > > > > [5] 9f453834c6039fac46dc19130288dbf0b2996f2e
> > > > >
> > > >
> > > >
> > > > --
> > > > Andrey Yegorov
> > > >

Re: [VOTE] Release 4.14.6, release candidate #0

Posted by Hang Chen <ch...@apache.org>.
Hi guys,
     One issue is the direct memory metric, incompatible with JDK8
introduced by [1] and fixed by [2]. I will close this vote and create
a new candidate soon.

Thanks,
Hang

[1] https://github.com/apache/bookkeeper/pull/3252
[2] https://github.com/apache/bookkeeper/pull/3677

Enrico Olivelli <eo...@gmail.com> 于2022年12月19日周一 05:20写道:
>
> +1 (binding)
>
> Enrico
>
> Il giorno gio 1 dic 2022 alle ore 07:30 Yong Zhang
> <zh...@gmail.com> ha scritto:
> >
> > okay. Make sense.
> >
> > --
> > Yong
> >
> > On Thu, 1 Dec 2022 at 07:52, Andrey Yegorov <an...@datastax.com>
> > wrote:
> >
> > > +1 (binding)
> > >
> > > * ran bookkeeper standalone
> > > * ran bookkeeper localbookie
> > > * built from sources (mac, intel), ran some tests
> > > * spot-checked maven repo
> > >
> > > @Yong - as I understand, build on M1 is not a regression for 4.14.x so it
> > > should not be a blocker.
> > >
> > > On Mon, Nov 21, 2022 at 4:03 AM Hang Chen <ch...@apache.org> wrote:
> > >
> > > > Hi everyone,
> > > > Please review and vote on the release candidate #0 for version 4.14.6,
> > > > as follows:
> > > > [ ] +1, Approve the release
> > > > [ ] -1, Do not approve the release (please provide specific comments)
> > > >
> > > > The complete staging area is available for your review, which includes:
> > > > * Release notes [1]
> > > > * The official Apache source and binary distributions to be deployed to
> > > > dist.apache.org [2]
> > > > * All artifacts to be deployed to the Maven Central Repository [3]
> > > > * Source code tag "v4.14.6-rc0" [4] with git sha [5]
> > > >
> > > > BookKeeper's KEYS file contains the PGP keys we used to sign this
> > > release:
> > > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> > > >
> > > > Please download these packages and review this release candidate:
> > > >
> > > > - Review release notes
> > > > - Download the source package (verify shasum, and asc) and follow the
> > > > instructions to build and run the bookkeeper service.
> > > > - Download the binary package (verify shasum, and asc) and follow the
> > > > instructions to run the bookkeeper service.
> > > > - Review the maven repo, release tag, licenses, and any other things you
> > > > think
> > > > it is important to release.
> > > >
> > > > The vote will be open for at least 72 hours. It is adopted by the
> > > majority
> > > > approval, with at least 3 PMC affirmative votes.
> > > >
> > > > Thanks,
> > > > Release Manager
> > > >
> > > > [1] https://github.com/apache/bookkeeper/pull/3659/files
> > > > [2]
> > > > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.14.6-rc0/
> > > > [3]
> > > >
> > > https://repository.apache.org/content/repositories/orgapachebookkeeper-1076/
> > > > [4] https://github.com/apache/bookkeeper/tree/v4.14.6-rc0
> > > > [5] 9f453834c6039fac46dc19130288dbf0b2996f2e
> > > >
> > >
> > >
> > > --
> > > Andrey Yegorov
> > >

Re: [VOTE] Release 4.14.6, release candidate #0

Posted by Enrico Olivelli <eo...@gmail.com>.
+1 (binding)

Enrico

Il giorno gio 1 dic 2022 alle ore 07:30 Yong Zhang
<zh...@gmail.com> ha scritto:
>
> okay. Make sense.
>
> --
> Yong
>
> On Thu, 1 Dec 2022 at 07:52, Andrey Yegorov <an...@datastax.com>
> wrote:
>
> > +1 (binding)
> >
> > * ran bookkeeper standalone
> > * ran bookkeeper localbookie
> > * built from sources (mac, intel), ran some tests
> > * spot-checked maven repo
> >
> > @Yong - as I understand, build on M1 is not a regression for 4.14.x so it
> > should not be a blocker.
> >
> > On Mon, Nov 21, 2022 at 4:03 AM Hang Chen <ch...@apache.org> wrote:
> >
> > > Hi everyone,
> > > Please review and vote on the release candidate #0 for version 4.14.6,
> > > as follows:
> > > [ ] +1, Approve the release
> > > [ ] -1, Do not approve the release (please provide specific comments)
> > >
> > > The complete staging area is available for your review, which includes:
> > > * Release notes [1]
> > > * The official Apache source and binary distributions to be deployed to
> > > dist.apache.org [2]
> > > * All artifacts to be deployed to the Maven Central Repository [3]
> > > * Source code tag "v4.14.6-rc0" [4] with git sha [5]
> > >
> > > BookKeeper's KEYS file contains the PGP keys we used to sign this
> > release:
> > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> > >
> > > Please download these packages and review this release candidate:
> > >
> > > - Review release notes
> > > - Download the source package (verify shasum, and asc) and follow the
> > > instructions to build and run the bookkeeper service.
> > > - Download the binary package (verify shasum, and asc) and follow the
> > > instructions to run the bookkeeper service.
> > > - Review the maven repo, release tag, licenses, and any other things you
> > > think
> > > it is important to release.
> > >
> > > The vote will be open for at least 72 hours. It is adopted by the
> > majority
> > > approval, with at least 3 PMC affirmative votes.
> > >
> > > Thanks,
> > > Release Manager
> > >
> > > [1] https://github.com/apache/bookkeeper/pull/3659/files
> > > [2]
> > > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.14.6-rc0/
> > > [3]
> > >
> > https://repository.apache.org/content/repositories/orgapachebookkeeper-1076/
> > > [4] https://github.com/apache/bookkeeper/tree/v4.14.6-rc0
> > > [5] 9f453834c6039fac46dc19130288dbf0b2996f2e
> > >
> >
> >
> > --
> > Andrey Yegorov
> >

Re: [VOTE] Release 4.14.6, release candidate #0

Posted by Yong Zhang <zh...@gmail.com>.
okay. Make sense.

--
Yong

On Thu, 1 Dec 2022 at 07:52, Andrey Yegorov <an...@datastax.com>
wrote:

> +1 (binding)
>
> * ran bookkeeper standalone
> * ran bookkeeper localbookie
> * built from sources (mac, intel), ran some tests
> * spot-checked maven repo
>
> @Yong - as I understand, build on M1 is not a regression for 4.14.x so it
> should not be a blocker.
>
> On Mon, Nov 21, 2022 at 4:03 AM Hang Chen <ch...@apache.org> wrote:
>
> > Hi everyone,
> > Please review and vote on the release candidate #0 for version 4.14.6,
> > as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > The complete staging area is available for your review, which includes:
> > * Release notes [1]
> > * The official Apache source and binary distributions to be deployed to
> > dist.apache.org [2]
> > * All artifacts to be deployed to the Maven Central Repository [3]
> > * Source code tag "v4.14.6-rc0" [4] with git sha [5]
> >
> > BookKeeper's KEYS file contains the PGP keys we used to sign this
> release:
> > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> >
> > Please download these packages and review this release candidate:
> >
> > - Review release notes
> > - Download the source package (verify shasum, and asc) and follow the
> > instructions to build and run the bookkeeper service.
> > - Download the binary package (verify shasum, and asc) and follow the
> > instructions to run the bookkeeper service.
> > - Review the maven repo, release tag, licenses, and any other things you
> > think
> > it is important to release.
> >
> > The vote will be open for at least 72 hours. It is adopted by the
> majority
> > approval, with at least 3 PMC affirmative votes.
> >
> > Thanks,
> > Release Manager
> >
> > [1] https://github.com/apache/bookkeeper/pull/3659/files
> > [2]
> > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.14.6-rc0/
> > [3]
> >
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1076/
> > [4] https://github.com/apache/bookkeeper/tree/v4.14.6-rc0
> > [5] 9f453834c6039fac46dc19130288dbf0b2996f2e
> >
>
>
> --
> Andrey Yegorov
>

Re: [VOTE] Release 4.14.6, release candidate #0

Posted by Andrey Yegorov <an...@datastax.com>.
+1 (binding)

* ran bookkeeper standalone
* ran bookkeeper localbookie
* built from sources (mac, intel), ran some tests
* spot-checked maven repo

@Yong - as I understand, build on M1 is not a regression for 4.14.x so it
should not be a blocker.

On Mon, Nov 21, 2022 at 4:03 AM Hang Chen <ch...@apache.org> wrote:

> Hi everyone,
> Please review and vote on the release candidate #0 for version 4.14.6,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
> * Release notes [1]
> * The official Apache source and binary distributions to be deployed to
> dist.apache.org [2]
> * All artifacts to be deployed to the Maven Central Repository [3]
> * Source code tag "v4.14.6-rc0" [4] with git sha [5]
>
> BookKeeper's KEYS file contains the PGP keys we used to sign this release:
> https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>
> Please download these packages and review this release candidate:
>
> - Review release notes
> - Download the source package (verify shasum, and asc) and follow the
> instructions to build and run the bookkeeper service.
> - Download the binary package (verify shasum, and asc) and follow the
> instructions to run the bookkeeper service.
> - Review the maven repo, release tag, licenses, and any other things you
> think
> it is important to release.
>
> The vote will be open for at least 72 hours. It is adopted by the majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Release Manager
>
> [1] https://github.com/apache/bookkeeper/pull/3659/files
> [2]
> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.14.6-rc0/
> [3]
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1076/
> [4] https://github.com/apache/bookkeeper/tree/v4.14.6-rc0
> [5] 9f453834c6039fac46dc19130288dbf0b2996f2e
>


-- 
Andrey Yegorov

Re: [VOTE] Release 4.14.6, release candidate #0

Posted by Yong Zhang <zh...@gmail.com>.
Thanks Hang for driving this release!

I am sorry to -1 because the source code built failed on M1.

I failed to build the source code on Mac M1, then I found we needed to
cherry-pick this PR
https://github.com/apache/bookkeeper/pull/3175/files to make it build
successfully on M1.

On Tue, 29 Nov 2022 at 18:59, lordcheng10 <lo...@gmail.com> wrote:

> +1
>
> Hang Chen <ch...@apache.org> 于2022年11月21日周一 20:03写道:
>
> > Hi everyone,
> > Please review and vote on the release candidate #0 for version 4.14.6,
> > as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > The complete staging area is available for your review, which includes:
> > * Release notes [1]
> > * The official Apache source and binary distributions to be deployed to
> > dist.apache.org [2]
> > * All artifacts to be deployed to the Maven Central Repository [3]
> > * Source code tag "v4.14.6-rc0" [4] with git sha [5]
> >
> > BookKeeper's KEYS file contains the PGP keys we used to sign this
> release:
> > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> >
> > Please download these packages and review this release candidate:
> >
> > - Review release notes
> > - Download the source package (verify shasum, and asc) and follow the
> > instructions to build and run the bookkeeper service.
> > - Download the binary package (verify shasum, and asc) and follow the
> > instructions to run the bookkeeper service.
> > - Review the maven repo, release tag, licenses, and any other things you
> > think
> > it is important to release.
> >
> > The vote will be open for at least 72 hours. It is adopted by the
> majority
> > approval, with at least 3 PMC affirmative votes.
> >
> > Thanks,
> > Release Manager
> >
> > [1] https://github.com/apache/bookkeeper/pull/3659/files
> > [2]
> > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.14.6-rc0/
> > [3]
> >
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1076/
> > [4] https://github.com/apache/bookkeeper/tree/v4.14.6-rc0
> > [5] 9f453834c6039fac46dc19130288dbf0b2996f2e
> >
>

Re: [VOTE] Release 4.14.6, release candidate #0

Posted by lordcheng10 <lo...@gmail.com>.
+1

Hang Chen <ch...@apache.org> 于2022年11月21日周一 20:03写道:

> Hi everyone,
> Please review and vote on the release candidate #0 for version 4.14.6,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
> * Release notes [1]
> * The official Apache source and binary distributions to be deployed to
> dist.apache.org [2]
> * All artifacts to be deployed to the Maven Central Repository [3]
> * Source code tag "v4.14.6-rc0" [4] with git sha [5]
>
> BookKeeper's KEYS file contains the PGP keys we used to sign this release:
> https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>
> Please download these packages and review this release candidate:
>
> - Review release notes
> - Download the source package (verify shasum, and asc) and follow the
> instructions to build and run the bookkeeper service.
> - Download the binary package (verify shasum, and asc) and follow the
> instructions to run the bookkeeper service.
> - Review the maven repo, release tag, licenses, and any other things you
> think
> it is important to release.
>
> The vote will be open for at least 72 hours. It is adopted by the majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Release Manager
>
> [1] https://github.com/apache/bookkeeper/pull/3659/files
> [2]
> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.14.6-rc0/
> [3]
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1076/
> [4] https://github.com/apache/bookkeeper/tree/v4.14.6-rc0
> [5] 9f453834c6039fac46dc19130288dbf0b2996f2e
>