You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Jack McCluskey (Jira)" <ji...@apache.org> on 2022/03/01 21:16:00 UTC

[jira] [Updated] (BEAM-14012) Add go fmt CI check

     [ https://issues.apache.org/jira/browse/BEAM-14012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jack McCluskey updated BEAM-14012:
----------------------------------
    Fix Version/s: 2.38.0
       Resolution: Fixed
           Status: Resolved  (was: In Progress)

> Add go fmt CI check
> -------------------
>
>                 Key: BEAM-14012
>                 URL: https://issues.apache.org/jira/browse/BEAM-14012
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-go
>            Reporter: Danny McCormick
>            Assignee: Jack McCluskey
>            Priority: P2
>             Fix For: 2.38.0
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Right now, we occasionally notice that checked in files have not been formatted properly (e.g. [https://github.com/apache/beam/pull/16973).] It would be nice to catch these as a precommit check (it could be something as simple as a quick Actions or Jira job that runs:
> ```
> go fmt sdks/go/...
> git diff-index --quiet HEAD – || (echo "Run go fmt before checking in changes" && exit 1)}}
> {{```}}
> That way we push the work to the original authors and let robots enforce linting :)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)