You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/08/10 02:16:53 UTC
[GitHub] [pulsar] zymap commented on a change in pull request #4927:
[Transaction][Buffer] Provide an asynchronous method to create a
transaction buffer
zymap commented on a change in pull request #4927: [Transaction][Buffer] Provide an asynchronous method to create a transaction buffer
URL: https://github.com/apache/pulsar/pull/4927#discussion_r312686700
##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java
##########
@@ -114,6 +114,8 @@ private TopicName(String completeTopicName) {
completeTopicName = TopicDomain.persistent.name() + "://" + completeTopicName;
} else if (parts.length == 1) {
completeTopicName = TopicDomain.persistent.name() + "://" + PUBLIC_TENANT + "/" + DEFAULT_NAMESPACE + "/" + parts[0];
+ } else if (parts.length == 5) {
Review comment:
Because I add the transaction suffix `/_txnlog`, the topic name will be `tenant/namespace/topic/_txnlog`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services